From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753488AbcLGTyM (ORCPT ); Wed, 7 Dec 2016 14:54:12 -0500 Received: from mga04.intel.com ([192.55.52.120]:6056 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932677AbcLGTyK (ORCPT ); Wed, 7 Dec 2016 14:54:10 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,315,1477983600"; d="scan'208";a="15056560" Message-ID: <1481140355.30772.17.camel@linux.intel.com> Subject: Re: [PATCH v4 5/5] i2c: designware: Cleaning comments and formatation From: Andy Shevchenko To: Luis Oliveira , wsa@the-dreams.de, robh+dt@kernel.org, mark.rutland@arm.com, jarkko.nikula@linux.intel.com, mika.westerberg@linux.intel.com, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ramiro.Oliveira@synopsys.com, Joao.Pinto@synopsys.com, CARLOS.PALMINHA@synopsys.com Date: Wed, 07 Dec 2016 21:52:35 +0200 In-Reply-To: <02856fdb6ce3230a4ac1ba0958938ad51e763205.1481131072.git.lolivei@synopsys.com> References: <02856fdb6ce3230a4ac1ba0958938ad51e763205.1481131072.git.lolivei@synopsys.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.2-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2016-12-07 at 17:55 +0000, Luis Oliveira wrote: > - Missspelling, comment formatation and fix a string of >   the existing code > Good, but after addressing below comments: Acked-by: Andy Shevchenko > --- a/drivers/i2c/busses/i2c-designware-slave.c > +++ b/drivers/i2c/busses/i2c-designware-slave.c > @@ -70,8 +70,8 @@ int i2c_dw_init_slave(struct dw_i2c_dev *dev) >   /* Configure register access mode 16bit */ >   dev->accessor_flags |= ACCESS_16BIT; >   } else if (reg != DW_IC_COMP_TYPE_VALUE) { > - dev_err(dev->dev, "Unknown Synopsys component type: " > - "0x%08x\n", reg); > + dev_err(dev->dev, > +  "Unknown Synopsys component type: 0x%08x\n", reg); Keep indentation like some_call(param, param2, ... paramX, paramY, ...); It applies to all your new code you bring by this series. > @@ -181,8 +181,10 @@ int i2c_dw_reg_slave(struct i2c_client *slave) >   return -EBUSY; >   if (slave->flags & I2C_CLIENT_TEN) >   return -EAFNOSUPPORT; > - /* set slave address in the IC_SAR register, > - * the address to which the DW_apb_i2c responds */ > + /* > +  * set slave address in the IC_SAR register, > +  * the address to which the DW_apb_i2c responds Again, Capital letter here, dot at the end of sentence. You may fix (if you want to) the rest of comment lines in entire driver. > +  */ >   >   __i2c_dw_enable(dev, false); >   dw_writel(dev, slave->addr, DW_IC_SAR); -- Andy Shevchenko Intel Finland Oy