From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933718AbcLHBcU (ORCPT ); Wed, 7 Dec 2016 20:32:20 -0500 Received: from mail-wj0-f182.google.com ([209.85.210.182]:33475 "EHLO mail-wj0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932522AbcLHBcS (ORCPT ); Wed, 7 Dec 2016 20:32:18 -0500 From: Rasmus Villemoes To: Tejun Heo , Andrew Morton Cc: linux-kernel@vger.kernel.org, Lai Jiangshan , Jens Axboe , Greg Kroah-Hartman , Rasmus Villemoes Subject: [RFC 02/10] lib/idr.c: delete useless condition Date: Thu, 8 Dec 2016 02:22:57 +0100 Message-Id: <1481160187-9652-3-git-send-email-linux@rasmusvillemoes.dk> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1481160187-9652-1-git-send-email-linux@rasmusvillemoes.dk> References: <1481160187-9652-1-git-send-email-linux@rasmusvillemoes.dk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Whether or not we have a spare ida_bitmap hanging off ida->free_bitmap doesn't seem related to whether the embedded struct idr may have a spare struct idr_layer in its free list. So the only thing this condition does is increase the chance that we end up calling get_from_free_list in vain. Signed-off-by: Rasmus Villemoes --- lib/idr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/idr.c b/lib/idr.c index 9cbfae251d77..1e786f817e66 100644 --- a/lib/idr.c +++ b/lib/idr.c @@ -991,7 +991,7 @@ int ida_get_new_above(struct ida *ida, int starting_id, int *p_id) * Throw away extra resources one by one after each successful * allocation. */ - if (ida->idr.id_free_cnt || ida->free_bitmap) { + if (ida->idr.id_free_cnt) { struct idr_layer *p = get_from_free_list(&ida->idr); if (p) kmem_cache_free(idr_layer_cache, p); -- 2.1.4