From: Andrew Jeffery <andrew@aj.id.au>
To: Joel Stanley <joel@jms.id.au>
Cc: "Lee Jones" <lee.jones@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Corey Minyard" <minyard@acm.org>,
"Cédric Le Goater" <clg@kaod.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/6] mfd: dt: Add bindings for the Aspeed LPC Host Controller (LHC)
Date: Thu, 08 Dec 2016 22:38:26 +1030 [thread overview]
Message-ID: <1481198906.3112.4.camel@aj.id.au> (raw)
In-Reply-To: <CACPK8XfuZ14Ud3Kginut7f0-_-UjTB-=Pma-9WwNecF93k0Ktg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2249 bytes --]
On Thu, 2016-12-08 at 12:42 +1030, Joel Stanley wrote:
> > On Tue, Dec 6, 2016 at 1:23 PM, Andrew Jeffery <andrew@aj.id.au> wrote:
> > The LPC bus pinmux configuration on fifth generation Aspeed SoCs depends
> > on bits in both the System Control Unit and the LPC Host Controller.
> >
> > The Aspeed LPC Host Controller is described as a child node of the
> > LPC host-range syscon device for arbitration of access by the host
> > controller and pinmux drivers.
> >
> > > > Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> > ---
> > .../devicetree/bindings/mfd/aspeed-lpc.txt | 22 ++++++++++++++++++++++
> > 1 file changed, 22 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
> > index a97131aba446..9de318ef72da 100644
> > --- a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
> > +++ b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
> > > > @@ -109,3 +109,25 @@ lpc: lpc@1e789000 {
> > };
> > };
> >
> > +Host Node Children
> > +==================
> > +
> > +LPC Host Controller
> > +-------------------
> > +
> > +The Aspeed LPC Host Controller configures the Low Pin Count (LPC) bus behaviour
> > +between the host and the baseboard management controller. The registers exist
> > +in the "host" portion of the Aspeed LPC controller, which must be the parent of
> > +the LPC host controller node.
> > +
> > +Required properties:
> > +- compatible: "aspeed,ast2500-lhc";
>
> Can you remind me why this binding doesn't cover the ast2400?
Partly that we haven't yet needed the LHC for the AST2400.
Mostly that I overlooked it.
If there are other problems with series I'll address this issue, but if
not we can add it when we need it down the track.
Andrew
>
> Cheers,
>
> Joel
>
> > +- reg: contains offset/length value of the LHC memory
> > + region.
> > +
> > +Example:
> > +
> > > > +lhc: lhc@20 {
> > + compatible = "aspeed,ast2500-lhc";
> > + reg = <0x20 0x24 0x48 0x8>;
> > +};
> > --
> > 2.9.3
> >
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2016-12-08 12:08 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-06 2:53 [PATCH v3 0/6] mfd: dt: Add bindings for the Aspeed MFDs Andrew Jeffery
2016-12-06 2:53 ` [PATCH v3 1/6] mfd: dt: Fix "indicates" typo in mfd bindings document Andrew Jeffery
2016-12-07 15:08 ` Linus Walleij
2016-12-09 22:42 ` Rob Herring
2017-01-03 17:49 ` Lee Jones
2016-12-06 2:53 ` [PATCH v3 2/6] mfd: dt: ranges, #address-cells and #size-cells as optional properties Andrew Jeffery
2016-12-09 22:49 ` Rob Herring
2016-12-09 22:55 ` Andrew Jeffery
2017-01-03 17:49 ` Lee Jones
2016-12-06 2:53 ` [PATCH v3 3/6] mfd: dt: Add Aspeed Low Pin Count Controller bindings Andrew Jeffery
2016-12-07 15:11 ` Linus Walleij
2016-12-08 2:07 ` Joel Stanley
2016-12-12 15:28 ` Rob Herring
2017-01-03 17:49 ` Lee Jones
2016-12-06 2:53 ` [PATCH v3 4/6] mfd: dt: Add bindings for the Aspeed LPC Host Controller (LHC) Andrew Jeffery
2016-12-07 15:12 ` Linus Walleij
2016-12-08 2:12 ` Joel Stanley
2016-12-08 12:08 ` Andrew Jeffery [this message]
2016-12-12 15:30 ` Rob Herring
2016-12-13 4:40 ` Andrew Jeffery
2017-01-03 17:49 ` Lee Jones
2016-12-06 2:53 ` [PATCH v3 5/6] mfd: dt: Add bindings for the Aspeed SoC Display Controller (GFX) Andrew Jeffery
2017-01-03 17:49 ` Lee Jones
2016-12-06 2:53 ` [PATCH v3 6/6] mfd: dt: Move syscon bindings to syscon subdirectory Andrew Jeffery
2016-12-12 15:39 ` Rob Herring
2016-12-13 4:53 ` Andrew Jeffery
2016-12-13 11:07 ` Lee Jones
2016-12-13 12:05 ` Andrew Jeffery
2016-12-13 12:17 ` Arnd Bergmann
2016-12-13 12:39 ` Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481198906.3112.4.camel@aj.id.au \
--to=andrew@aj.id.au \
--cc=clg@kaod.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=minyard@acm.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).