From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932506AbcLLLBJ (ORCPT ); Mon, 12 Dec 2016 06:01:09 -0500 Received: from mail-he1eur01on0092.outbound.protection.outlook.com ([104.47.0.92]:29318 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932181AbcLLLBH (ORCPT ); Mon, 12 Dec 2016 06:01:07 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=peda@axentia.se; From: Peter Rosin To: linux-kernel@vger.kernel.org Cc: Peter Rosin , Sebastian Reichel , Rob Herring , Mark Rutland , linux-pm@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH 1/3] power: supply: bq24735-charger: simplify register update to stop charging Date: Mon, 12 Dec 2016 12:00:22 +0100 Message-Id: <1481540424-19293-2-git-send-email-peda@axentia.se> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1481540424-19293-1-git-send-email-peda@axentia.se> References: <1481540424-19293-1-git-send-email-peda@axentia.se> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [217.210.101.82] X-ClientProxiedBy: DB6PR0701CA0027.eurprd07.prod.outlook.com (10.168.7.165) To DB6PR0201MB2309.eurprd02.prod.outlook.com (10.169.222.148) X-MS-Office365-Filtering-Correlation-Id: 96f782e1-7ac8-414a-dcd6-08d4227e278a X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:DB6PR0201MB2309; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0201MB2309;3:1+/vIJFwz93Ng8DRtCILrCZx/nw5ORJP6dFolYX+J6ZOYUGxC8p+OTZH1u8ONz48S/ud5eGwaYiJ3WSWKtZeUNkMqub7OqUnkdL+KSM3JSfau3aelzmvXLIGBTxtEk54nkjrtykPTxDyHZLLR7HKMFY0WyvkUAPFWE2fUxmEkYwrF7MGCf7JO9QYr8wV7y3j0YoiyLBm9Fo+yp8Gl6xBpzMq1miBMbkEivLN4zFhGD6vQ/cNaDZTObpTRz+Q4pw3vtW6a6V6AaH6VK88gBp0AQ== X-Microsoft-Exchange-Diagnostics: 1;DB6PR0201MB2309;25:OsDpQI+xva3nUbV+zn9H1yHhTrsBJ6r4YCGMpm6Qw9HIlUdCFGoJpn64fSLIyHvy/YlsCk1+yzpn6ZFuWKQeUS3ujhTFykI8u5VWNwAGs8xvktr0kcK9zYCXoSu15Wlf7napAwLKFGTRPGwL7P5eh6NCGsjLl5opMsTmJUpODoZLk0gNjbceeOTkTJ4fsAMWteO9oCqU6ihbn06ZCPUjJn9GdbT29w+lFqTZTJ1C3WL5eKC+HnexELMyN7LoNutZs5VawvTQJnrE/w7SPiDupSUc9YyHcfsCPfD1PPuGOWFr3b2iCO248p662n7dI57hJuzuz0r1oWCTlDJ2v7ueVqwOm5wmh4hF8/P3UctfOZ9j5PBIgsYVVPVDYfEYpt4fY5xuOyHTOPloaSevQD7ahh++PGILW9l5VTTx7ZoWUJ6UspxLoso4WeFQcHj+cRLmJH3o0vNO1s9nKgolX15OS4t2Ei2raKm/bKErxt6ifAPZzcZde6H95MsNXH2dm4VA/9r//aAM0o0LihwIWIDrvPfzyOxzsWKNrRQtxuMvuJSokZbDz+c4MrKY6Ak2DAuAl6s9xzVcX89LwYLPWz4Be8oOBu6LZbX8r0OOK2J5UlVgjDmAfI3A9csIYJyep5gR5D/Yxc2lkElY5CazTWEMb/uYxyuAkeU4jl/3c1U9XYUA/4HqZdXAylW7kCKQlZOTUNhUZ3CkYViRJLrw1+/idYkyy5UHOozOfh8II7WtxYX9TubsjIsb/kM1dk1kJi8/e+Xe5zn1RW+Gg80zn3gJL96Ebm7RNOQdZSaRZqHtnik= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0201MB2309;31:/xhfu8JlnloSOsyWPqKvzQOYIIZHrB8QwLCyPrsmo4VBpAJqG0IAcfpF/cttAFp21hXcin8tgPyORSJCp5B9+YzqlpoomhAuk3K35tq4G6nB7pRQo9Aic2MGChV//i6Zn8V7yf7HxICUHg4DwQMAOutPlxD7JdCxfWJSOywxia2PuqEGgPGTEAx+dZMymtNo8iD7p2SJjse6aoWIYzNBAyBmKLh5FWTjeKMLCGUtUJ6fK+s9qE9/LRb7kobqJFgWE/nr6bCj3DFW6/y1N5GRzQ==;4:jCy4HOS/AClUFwilU88zcdWFDURu9sl/5hnuyIQ5pmUiOO6lDHF0y3oYpiaLEiJUcN4hk7jXn5tmKp630tkKeI/eVSQtwsphudoHZmWe8L/tFCNPlNRibu1AbDMvyVpMnV+oB3owRfUK9qFUYPUgrUHE8vJkvIEvoezH2Z00MktMAFSK7sbnc3rqnTF39cKSDERmt6kgOFXnIyy9TKmfC2w3H2u7/qPuI7jcC/bhRLkQ9Xegggf4fQcrRV2pliX06dF7StJRNu2sjdXBajbMAqDnsF5Ywz5ZCgEDZB7nVoaFf/+LimfQdbmgKO+mJWe9f5YWbh4vhBOC1WH8j8/SyEc76IyuM6JvKIyIzA0cyOjGQ0sW5JGRItrtTcMGm7H3LO42V9oxkpdxLPIgbLyY6Ba6+qSldkPM/b665WReTUKNx2q7UIKajuXd21vOgxMNru+8ASIeI7jFD7zaipvWNfcX6npd+idwvWePv6E2IcmCL+kXdJFHCDkzTnrioVcbNhSag7EXZLCLyUnCpSx5unJP0PUIXE5MvimdvC8cGpfH7BkiZ+AeHdN2VZYdvsXtx3M6sd6sv1i0dxThbgBBgY1MeyM/ktAOImB43cSEVh2Qt2QamejED2vG2e+WsZhL X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041248)(2016111802025)(20161123555025)(20161123560025)(20161123564025)(20161123562025)(6043046)(6072148);SRVR:DB6PR0201MB2309;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0201MB2309; X-Forefront-PRVS: 0154C61618 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6069001)(7916002)(39450400003)(39830400002)(39410400002)(189002)(199003)(36756003)(2950100002)(5660300001)(48376002)(97736004)(50466002)(2361001)(7736002)(575784001)(68736007)(106356001)(86362001)(305945005)(76176999)(105586002)(2906002)(92566002)(50986999)(74482002)(50226002)(5003940100001)(6916009)(8676002)(6512006)(42186005)(33646002)(189998001)(2351001)(81166006)(4326007)(6506006)(81156014)(6486002)(110136003)(3846002)(6116002)(66066001)(38730400001)(47776003)(101416001)(6666003)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:DB6PR0201MB2309;H:localhost.localdomain;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DB6PR0201MB2309;23:29weHPZarvOIt80ZBAplvRj0IhnFu9jiTIuUu73?= =?us-ascii?Q?9H0zljsBf6E4KvyXzVaHkSKvgsrMBDai+udoAxAxyLsZhRHShmmAyN2RmjqV?= =?us-ascii?Q?MahoFMWXDAZaBV3ptNcLdhUCkHdP4TcA28hjUhIjJb/Ek7ANE6BoSmPBoKW8?= =?us-ascii?Q?9MOVR1fjV9w19cRgCGb/9Atla2VCQeotdttht4808r06+BX2c72lmxGDiV7H?= =?us-ascii?Q?Lz6U0Ilt6ADSbq0juWw6WxJ9S8EeGhk9B8o6pESFEtfjR4L0lSZVC+Jb7BiW?= =?us-ascii?Q?rbMCvzNk10fggqyqGLnvIfRsPryzmeXAX0RRVwM8W8c6lgKciJZ6LaQvjUBk?= =?us-ascii?Q?gOl2uNhyLBA+G38qWV2Ut1ivE6e8Kgf2lv1qXZHoUrlWBlQo60kcGPi/QX4f?= =?us-ascii?Q?1HkDNzzzYkjXLRn1uU+jXxNX89/AyZfqn/VH0Lq0Vp/HS1FGnV5FP3E2C/ip?= =?us-ascii?Q?aL/fr+w1sHCZzXdSkTKDLG8cAet70whxvkghdMjqnqhTVxQmJkVcrzAXF40B?= =?us-ascii?Q?thMrZkzHP6e+2h/wrEtfvFDEZjQIIN7yrSDgYDs7JUsT2zXpEOcYg8dOUXo8?= =?us-ascii?Q?Jxs+ZqB0M1kbo/z1ItJu5F6hOgZnLekJkC5Ip/CKUCUdwYSEJD57n2H2CtVU?= =?us-ascii?Q?3sQ0mn5AVbpUGC5R9ICdWpSKBHe1oTA/cTwq/Oc+nWxTMkTRe8B6t78VyZDq?= =?us-ascii?Q?2/wrxIkenNlsuAdj9OtNiuBdAG6fqS5vxYX5671Ary0E/vVCnZPzJlwFyaUF?= =?us-ascii?Q?HPiyZoSBH2gqDP5e5I2kfREFvaVisvUFPrIpfzcwBlGUgpwNh7iszjIaby1w?= =?us-ascii?Q?QM+kklr3+rjq3lDsRMli1Agv9vEDxj0lk6VSaA8kt+bi6I8QUu8E/mBp/w/S?= =?us-ascii?Q?5wnYodwjKgfLuuTVJ6dfRfbMpc9Dlz504w9H3+FVEQnsp89x0KF404FLBUL9?= =?us-ascii?Q?29r3nUYWLagb7xR0biuRP4GY7F3ni0COFvMKPlLtcWirja1t+vPw2EHX0Bpv?= =?us-ascii?Q?gVEGFj2qe7r/NC0NJ3Tx36Fceh8O/6vJa18WZ9XdqHudzXi+ly636IeHGqFq?= =?us-ascii?Q?Q+5nHo+jm14I+7kl5L+bylP6IN0sj5w8z4zxhLXAa8nO7K3CETyd0RrIlChw?= =?us-ascii?Q?79QZtUpC9V2b7Ma/hK4bA0uklXebVY83sdX5bC2BjbpCHtbGSNP/uodkrI4T?= =?us-ascii?Q?tWuTylb7jcKnvC2RR4bNJsBlB9jIYOtEQxunrd0uhpjInfzQofKLlA4GK3Q?= =?us-ascii?Q?=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0201MB2309;6:cXlIo6NOQDsjkM1jfGyGY7BB3XnA+O7WNC+K+NYKJsggqsLnKegbOqbT3n20ms8zgbOTOt2ZyDmTezHaMf0g/IY0gUVZTp7EbXsxOL5houPo3CVwjEV8ys40/AqaBA3+JtgcgwfBaFSs/M/ljgtpAEMBtH4K3f/nXUyZ3uFjpgTqMDgtK0GC+6LCQm7d5QmSoN+9TnA5iV5le1HXDivwhzETQtMRZqvTrLnYARTcU6rnKCaXd3+9limyXDsdIIrsW0RlgZwtjT14BjoGPx0mPjKvXf68LERuebXtyiAqhD1nxX1YdYdztz0a3iIZSQFakGqQN5LbIrIstVGkn1ILakSrnQ2wfF5lAJIQL7JDPDWQOJygMBcSWlTK9B+8YUVWw5r+0JJDXjBpmztpbP/nT9MgtA+zR0fa71GXIHZ7/UOIy98Y71ORXJXAgMGGNNv+;5:RCZXmyA02I/uayDhrKRwZPWQC3iTHijPIU+3F2Thj2vEHUWvksktGy1Ai//gzFr2Sk84ApKTnkRUVNqoMzko66cqSvYdkozEmWeDlHQiFYxf2Sqv98hQgC0jS6ZtFEK7i2dbUgZW4wlAZucaDWSk3RaHnDLrlFWYx9PL5Qhc9uE=;24:XANgDYG7GnLnMPfzhmxVOjwyMDZ1HdgsFDrJtIDbTstmCJgAbgOJz0Ro+RDCauOJWvOWwWPcRybWNz/xyLsfY3xRG7oNFRkRHgOXp6XG7+k= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DB6PR0201MB2309;7:Aj+YHA4AMnSTozjwJBzjnPdEw55ltnrSdbdS8NiDJTws6z9X7DG7xiN6Pf7zc4EpETk5gSzIIVPMD1sqoPnCsm6hKoo67Z+OkpxlzpVHenefdLwE/IEFn8Nhs6VF7g8y7FVv1gwrqq74bXEmgn+fCnqgPZgGhqh+nqFE52iJeLzOttLD6g/+MsIGvTkc6bLEsRxrvmzclGdiJJBXP4mrmlSF4Y3y76yZfcSFTnxd+n6Q7KIL9IdBBjuaHO8qjax4QfefxmE/7sBQHUla4s8//J/p5/BvvZBc7kMHWjbPbVUJ2t5etgoFeTTtTEoQfjpwoCQCDIUAh5ZZNdWEJImlwy+IXCFSeOnxgbqy4J6HMqDHpATXa+1cODQEk91i07Dd+56DkzJ/Qwk6pa4Q0Lz3Ajlqlg7gdRK3KIWXz4HvYYgg/XE/k3hX4FGkSSZEvXiPzN+PswDjW9QobgUrMPg7+g== X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2016 11:00:58.0699 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0201MB2309 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Providing value bits outside of the mask is pointless. Signed-off-by: Peter Rosin --- drivers/power/supply/bq24735-charger.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/power/supply/bq24735-charger.c b/drivers/power/supply/bq24735-charger.c index eb7783b42e0a..1d5c9206e0ed 100644 --- a/drivers/power/supply/bq24735-charger.c +++ b/drivers/power/supply/bq24735-charger.c @@ -111,8 +111,7 @@ static inline int bq24735_enable_charging(struct bq24735 *charger) return 0; return bq24735_update_word(charger->client, BQ24735_CHG_OPT, - BQ24735_CHG_OPT_CHARGE_DISABLE, - ~BQ24735_CHG_OPT_CHARGE_DISABLE); + BQ24735_CHG_OPT_CHARGE_DISABLE, 0); } static inline int bq24735_disable_charging(struct bq24735 *charger) -- 2.1.4