From: kys@exchange.microsoft.com
To: linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
ohering@suse.com, linux-scsi@vger.kernel.org, apw@canonical.com,
vkuznets@redhat.com, jasowang@redhat.com,
martin.petersen@oracle.com, hare@suse.de,
James.Bottomley@HansenPartnership.com
Cc: Long Li <longli@microsoft.com>,
"K. Y. Srinivasan" <kys@microsoft.com>, <stable@vger.kernel.org>
Subject: [PATCH 5/6] storvsc: properly handle SRB_ERROR when sense message is present
Date: Wed, 14 Dec 2016 18:46:02 -0800 [thread overview]
Message-ID: <1481769963-2069-5-git-send-email-kys@exchange.microsoft.com> (raw)
In-Reply-To: <1481769963-2069-1-git-send-email-kys@exchange.microsoft.com>
From: Long Li <longli@microsoft.com>
When sense message is present on error, we should pass along to the upper
layer to decide how to deal with the error.
This patch fixes connectivity issues with Fiber Channel devices.
Signed-off-by: Long Li <longli@microsoft.com>
Reviewed-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Cc: <stable@vger.kernel.org>
---
drivers/scsi/storvsc_drv.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
index 3209387..3c92dc2 100644
--- a/drivers/scsi/storvsc_drv.c
+++ b/drivers/scsi/storvsc_drv.c
@@ -925,6 +925,13 @@ static void storvsc_handle_error(struct vmscsi_request *vm_srb,
switch (SRB_STATUS(vm_srb->srb_status)) {
case SRB_STATUS_ERROR:
/*
+ * Let upper layer deal with error when
+ * sense message is present.
+ */
+
+ if (vm_srb->srb_status & SRB_STATUS_AUTOSENSE_VALID)
+ break;
+ /*
* If there is an error; offline the device since all
* error recovery strategies would have already been
* deployed on the host side. However, if the command
--
1.7.4.1
next prev parent reply other threads:[~2016-12-15 0:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-15 2:45 [PATCH 0/6] storvsc: Miscellaneous fixes and enhancements kys
2016-12-15 2:45 ` [PATCH 1/6] storvsc: Enable tracking of queue depth kys
2016-12-15 2:45 ` [PATCH 2/6] storvsc: Remove the restriction on max segment size kys
2016-12-15 2:46 ` [PATCH 3/6] storvsc: Enable multi-queue support kys
2016-12-15 2:46 ` [PATCH 4/6] storvsc: use tagged SRB requests if supported by the device kys
2016-12-15 2:46 ` kys [this message]
2016-12-15 2:46 ` [PATCH 6/6] storvsc: properly set residual data length on errors kys
2016-12-20 22:43 ` [PATCH 0/6] storvsc: Miscellaneous fixes and enhancements Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481769963-2069-5-git-send-email-kys@exchange.microsoft.com \
--to=kys@exchange.microsoft.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=hare@suse.de \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=martin.petersen@oracle.com \
--cc=ohering@suse.com \
--cc=stable@vger.kernel.org \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).