* [PATCH] net: wireless: marvell: libertas: constify cfg80211_ops structures
@ 2016-12-17 22:57 Bhumika Goyal
2016-12-30 13:02 ` Kalle Valo
2016-12-30 13:56 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Bhumika Goyal @ 2016-12-17 22:57 UTC (permalink / raw)
To: julia.lawall, kvalo, libertas-dev, linux-wireless, netdev, linux-kernel
Cc: Bhumika Goyal
cfg80211_ops structures are only passed as an argument to the function
wiphy_new. This argument is of type const, so cfg80211_ops strutures
having this property can be declared as const.
Done using Coccinelle
@r1 disable optional_qualifier @
identifier i;
position p;
@@
static struct cfg80211_ops i@p = {...};
@ok1@
identifier r1.i;
position p;
@@
wiphy_new(&i@p,...)
@bad@
position p!={r1.p,ok1.p};
identifier r1.i;
@@
i@p
@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
struct cfg80211_ops i;
File size before:
text data bss dec hex filename
21225 1954 16 23195 5a9b wireless/marvell/libertas/cfg.o
File size after:
text data bss dec hex filename
22041 1154 16 23211 5aab wireless/marvell/libertas/cfg.o
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
drivers/net/wireless/marvell/libertas/cfg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/marvell/libertas/cfg.c b/drivers/net/wireless/marvell/libertas/cfg.c
index 7ff2efa..3f97acb 100644
--- a/drivers/net/wireless/marvell/libertas/cfg.c
+++ b/drivers/net/wireless/marvell/libertas/cfg.c
@@ -2086,7 +2086,7 @@ static int lbs_set_power_mgmt(struct wiphy *wiphy, struct net_device *dev,
* Initialization
*/
-static struct cfg80211_ops lbs_cfg80211_ops = {
+static const struct cfg80211_ops lbs_cfg80211_ops = {
.set_monitor_channel = lbs_cfg_set_monitor_channel,
.libertas_set_mesh_channel = lbs_cfg_set_mesh_channel,
.scan = lbs_cfg_scan,
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: net: wireless: marvell: libertas: constify cfg80211_ops structures
2016-12-17 22:57 [PATCH] net: wireless: marvell: libertas: constify cfg80211_ops structures Bhumika Goyal
@ 2016-12-30 13:02 ` Kalle Valo
2016-12-30 13:56 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2016-12-30 13:02 UTC (permalink / raw)
To: Bhumika Goyal
Cc: julia.lawall, libertas-dev, linux-wireless, netdev, linux-kernel,
Bhumika Goyal
Bhumika Goyal <bhumirks@gmail.com> wrote:
> cfg80211_ops structures are only passed as an argument to the function
> wiphy_new. This argument is of type const, so cfg80211_ops strutures
> having this property can be declared as const.
> Done using Coccinelle
>
> @r1 disable optional_qualifier @
> identifier i;
> position p;
> @@
> static struct cfg80211_ops i@p = {...};
>
> @ok1@
> identifier r1.i;
> position p;
> @@
> wiphy_new(&i@p,...)
>
> @bad@
> position p!={r1.p,ok1.p};
> identifier r1.i;
> @@
> i@p
>
> @depends on !bad disable optional_qualifier@
> identifier r1.i;
> @@
> +const
> struct cfg80211_ops i;
>
> File size before:
> text data bss dec hex filename
> 21225 1954 16 23195 5a9b wireless/marvell/libertas/cfg.o
>
> File size after:
> text data bss dec hex filename
> 22041 1154 16 23211 5aab wireless/marvell/libertas/cfg.o
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
The prefix should be "libertas:", I can fix that before I commit.
--
https://patchwork.kernel.org/patch/9479131/
Documentation about submitting wireless patches and checking status
from patchwork:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: libertas: constify cfg80211_ops structures
2016-12-17 22:57 [PATCH] net: wireless: marvell: libertas: constify cfg80211_ops structures Bhumika Goyal
2016-12-30 13:02 ` Kalle Valo
@ 2016-12-30 13:56 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2016-12-30 13:56 UTC (permalink / raw)
To: Bhumika Goyal
Cc: julia.lawall, libertas-dev, linux-wireless, netdev, linux-kernel,
Bhumika Goyal
Bhumika Goyal <bhumirks@gmail.com> wrote:
> cfg80211_ops structures are only passed as an argument to the function
> wiphy_new. This argument is of type const, so cfg80211_ops strutures
> having this property can be declared as const.
> Done using Coccinelle
>
> @r1 disable optional_qualifier @
> identifier i;
> position p;
> @@
> static struct cfg80211_ops i@p = {...};
>
> @ok1@
> identifier r1.i;
> position p;
> @@
> wiphy_new(&i@p,...)
>
> @bad@
> position p!={r1.p,ok1.p};
> identifier r1.i;
> @@
> i@p
>
> @depends on !bad disable optional_qualifier@
> identifier r1.i;
> @@
> +const
> struct cfg80211_ops i;
>
> File size before:
> text data bss dec hex filename
> 21225 1954 16 23195 5a9b wireless/marvell/libertas/cfg.o
>
> File size after:
> text data bss dec hex filename
> 22041 1154 16 23211 5aab wireless/marvell/libertas/cfg.o
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Patch applied to wireless-drivers-next.git, thanks.
26eb994d5239 libertas: constify cfg80211_ops structures
--
https://patchwork.kernel.org/patch/9479131/
Documentation about submitting wireless patches and checking status
from patchwork:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-12-30 13:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-17 22:57 [PATCH] net: wireless: marvell: libertas: constify cfg80211_ops structures Bhumika Goyal
2016-12-30 13:02 ` Kalle Valo
2016-12-30 13:56 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).