From: Wei Yang <richard.weiyang@gmail.com>
To: trivial@kernel.org, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Wei Yang <richard.weiyang@gmail.com>
Subject: [PATCH V2 1/2] mm/memblock.c: trivial code refine in memblock_is_region_memory()
Date: Sun, 18 Dec 2016 14:47:49 +0000 [thread overview]
Message-ID: <1482072470-26151-2-git-send-email-richard.weiyang@gmail.com> (raw)
In-Reply-To: <1482072470-26151-1-git-send-email-richard.weiyang@gmail.com>
The base address is already guaranteed to be in the region by
memblock_search().
This patch removes the check on base.
Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
---
mm/memblock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/memblock.c b/mm/memblock.c
index 7608bc3..cd85303 100644
--- a/mm/memblock.c
+++ b/mm/memblock.c
@@ -1615,7 +1615,7 @@ int __init_memblock memblock_is_region_memory(phys_addr_t base, phys_addr_t size
if (idx == -1)
return 0;
- return memblock.memory.regions[idx].base <= base &&
+ return /* memblock.memory.regions[idx].base <= base && */
(memblock.memory.regions[idx].base +
memblock.memory.regions[idx].size) >= end;
}
--
2.5.0
next prev parent reply other threads:[~2016-12-18 14:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-18 14:47 [PATCH V2 0/2] mm/memblock.c: fix potential bug and code refine Wei Yang
2016-12-18 14:47 ` Wei Yang [this message]
2016-12-19 15:15 ` [PATCH V2 1/2] mm/memblock.c: trivial code refine in memblock_is_region_memory() Michal Hocko
2016-12-20 16:35 ` Wei Yang
2016-12-21 7:48 ` Michal Hocko
2016-12-21 12:43 ` Wei Yang
2016-12-21 12:48 ` Michal Hocko
2016-12-21 13:15 ` Wei Yang
2016-12-18 14:47 ` [PATCH V2 2/2] mm/memblock.c: check return value of memblock_reserve() in memblock_virt_alloc_internal() Wei Yang
2016-12-19 15:21 ` Michal Hocko
2016-12-20 16:48 ` Wei Yang
2016-12-21 7:51 ` Michal Hocko
2016-12-21 13:13 ` Wei Yang
2016-12-21 13:22 ` Michal Hocko
2016-12-21 14:39 ` Wei Yang
2016-12-21 14:52 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1482072470-26151-2-git-send-email-richard.weiyang@gmail.com \
--to=richard.weiyang@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).