linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] USB: cypress_m8: remove unused variable
@ 2016-12-18 22:29 Sudip Mukherjee
  2016-12-19 11:08 ` Johan Hovold
  0 siblings, 1 reply; 4+ messages in thread
From: Sudip Mukherjee @ 2016-12-18 22:29 UTC (permalink / raw)
  To: Johan Hovold, Greg Kroah-Hartman; +Cc: linux-kernel, linux-usb, Sudip Mukherjee

The variable havedata was only being set but never used afterwards.

Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
---
 drivers/usb/serial/cypress_m8.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/usb/serial/cypress_m8.c b/drivers/usb/serial/cypress_m8.c
index bbeeb2b..90110de 100644
--- a/drivers/usb/serial/cypress_m8.c
+++ b/drivers/usb/serial/cypress_m8.c
@@ -1069,7 +1069,6 @@ static void cypress_read_int_callback(struct urb *urb)
 	unsigned char *data = urb->transfer_buffer;
 	unsigned long flags;
 	char tty_flag = TTY_NORMAL;
-	int havedata = 0;
 	int bytes = 0;
 	int result;
 	int i = 0;
@@ -1118,16 +1117,12 @@ static void cypress_read_int_callback(struct urb *urb)
 		priv->current_status = data[0] & 0xF8;
 		bytes = data[1] + 2;
 		i = 2;
-		if (bytes > 2)
-			havedata = 1;
 		break;
 	case packet_format_2:
 		/* This is for the CY7C63743... */
 		priv->current_status = data[0] & 0xF8;
 		bytes = (data[0] & 0x07) + 1;
 		i = 1;
-		if (bytes > 1)
-			havedata = 1;
 		break;
 	}
 	spin_unlock_irqrestore(&priv->lock, flags);
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] USB: cypress_m8: remove unused variable
  2016-12-18 22:29 [PATCH] USB: cypress_m8: remove unused variable Sudip Mukherjee
@ 2016-12-19 11:08 ` Johan Hovold
  2017-01-02  9:41   ` Johan Hovold
  0 siblings, 1 reply; 4+ messages in thread
From: Johan Hovold @ 2016-12-19 11:08 UTC (permalink / raw)
  To: Sudip Mukherjee; +Cc: Johan Hovold, Greg Kroah-Hartman, linux-kernel, linux-usb

On Sun, Dec 18, 2016 at 10:29:27PM +0000, Sudip Mukherjee wrote:
> The variable havedata was only being set but never used afterwards.
> 
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>

Thanks, I'll queue this up for 4.11.

Johan

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] USB: cypress_m8: remove unused variable
  2016-12-19 11:08 ` Johan Hovold
@ 2017-01-02  9:41   ` Johan Hovold
  2017-01-02  9:47     ` Johan Hovold
  0 siblings, 1 reply; 4+ messages in thread
From: Johan Hovold @ 2017-01-02  9:41 UTC (permalink / raw)
  To: Sudip Mukherjee; +Cc: Johan Hovold, Greg Kroah-Hartman, linux-kernel, linux-usb

On Mon, Dec 19, 2016 at 12:08:39PM +0100, Johan Hovold wrote:
> On Sun, Dec 18, 2016 at 10:29:27PM +0000, Sudip Mukherjee wrote:
> > The variable havedata was only being set but never used afterwards.
> > 
> > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
> 
> Thanks, I'll queue this up for 4.11.

Now applied, thanks.

Johan

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] USB: cypress_m8: remove unused variable
  2017-01-02  9:41   ` Johan Hovold
@ 2017-01-02  9:47     ` Johan Hovold
  0 siblings, 0 replies; 4+ messages in thread
From: Johan Hovold @ 2017-01-02  9:47 UTC (permalink / raw)
  To: Sudip Mukherjee; +Cc: Johan Hovold, Greg Kroah-Hartman, linux-kernel, linux-usb

On Mon, Jan 02, 2017 at 10:41:03AM +0100, Johan Hovold wrote:
> On Mon, Dec 19, 2016 at 12:08:39PM +0100, Johan Hovold wrote:
> > On Sun, Dec 18, 2016 at 10:29:27PM +0000, Sudip Mukherjee wrote:
> > > The variable havedata was only being set but never used afterwards.
> > > 
> > > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
> > 
> > Thanks, I'll queue this up for 4.11.
> 
> Now applied, thanks.

Oh, wait. Please resend this one and make sure your From (author)
address matches your Signed-off-by tag.

Thanks,
Johan

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-01-02  9:47 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-18 22:29 [PATCH] USB: cypress_m8: remove unused variable Sudip Mukherjee
2016-12-19 11:08 ` Johan Hovold
2017-01-02  9:41   ` Johan Hovold
2017-01-02  9:47     ` Johan Hovold

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).