From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761677AbcLRWo7 (ORCPT ); Sun, 18 Dec 2016 17:44:59 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:35127 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758506AbcLRWo6 (ORCPT ); Sun, 18 Dec 2016 17:44:58 -0500 From: Sudip Mukherjee To: Valentina Manea , Shuah Khan , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Sudip Mukherjee Subject: [PATCH] usbip: vudc: check for NULL before use Date: Sun, 18 Dec 2016 22:44:51 +0000 Message-Id: <1482101091-3969-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org to_vep() is doing a container_of() on _ep. It is better to do the NULL check first and then use it. Signed-off-by: Sudip Mukherjee --- drivers/usb/usbip/vudc_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/usbip/vudc_dev.c b/drivers/usb/usbip/vudc_dev.c index 968471b..32ea604 100644 --- a/drivers/usb/usbip/vudc_dev.c +++ b/drivers/usb/usbip/vudc_dev.c @@ -388,10 +388,10 @@ static int vep_dequeue(struct usb_ep *_ep, struct usb_request *_req) unsigned long flags; int ret = 0; - ep = to_vep(_ep); if (!_ep) return -EINVAL; + ep = to_vep(_ep); udc = ep_to_vudc(ep); if (!udc->driver) return -ESHUTDOWN; -- 1.9.1