From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754578AbcLSXhf (ORCPT ); Mon, 19 Dec 2016 18:37:35 -0500 Received: from mail-io0-f173.google.com ([209.85.223.173]:34024 "EHLO mail-io0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754053AbcLSXhb (ORCPT ); Mon, 19 Dec 2016 18:37:31 -0500 From: Laura Abbott To: Herbert Xu , "David S. Miller" , Ard Biesheuvel , Giovanni Cabiddu Cc: Laura Abbott , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Mark Rutland , Christopher Covington Subject: [PATCH] crypto: testmgr: Use linear alias for test input Date: Mon, 19 Dec 2016 15:37:26 -0800 Message-Id: <1482190646-7720-1-git-send-email-labbott@redhat.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christopher Covington reported a crash on aarch64 on recent Fedora kernels: kernel BUG at ./include/linux/scatterlist.h:140! Internal error: Oops - BUG: 0 [#1] PREEMPT SMP Modules linked in: CPU: 2 PID: 752 Comm: cryptomgr_test Not tainted 4.9.0-11815-ge93b1cc #162 Hardware name: linux,dummy-virt (DT) task: ffff80007c650080 task.stack: ffff800008910000 PC is at sg_init_one+0xa0/0xb8 LR is at sg_init_one+0x24/0xb8 ... [] sg_init_one+0xa0/0xb8 [] test_acomp+0x10c/0x438 [] alg_test_comp+0xb0/0x118 [] alg_test+0x17c/0x2f0 [] cryptomgr_test+0x44/0x50 [] kthread+0xf8/0x128 [] ret_from_fork+0x10/0x50 The test vectors used for input are part of the kernel image. These inputs are passed as a buffer to sg_init_one which eventually blows up with BUG_ON(!virt_addr_valid(buf)). On arm64, virt_addr_valid returns false for the kernel image since virt_to_page will not return the correct page. The kernel image is also aliased to the linear map so get the linear alias and pass that to the scatterlist instead. Reported-by: Christopher Covington Fixes: d7db7a882deb ("crypto: acomp - update testmgr with support for acomp") Signed-off-by: Laura Abbott --- x86 supports virt_addr_valid working on kernel image addresses but arm64 is more strict. This is the direction things have been moving with my CONFIG_DEBUG_VIRTUAL series for arm64 which is tightening the definition of __pa/__pa_symbol. --- crypto/testmgr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/crypto/testmgr.c b/crypto/testmgr.c index f616ad7..f5bac10 100644 --- a/crypto/testmgr.c +++ b/crypto/testmgr.c @@ -1464,7 +1464,7 @@ static int test_acomp(struct crypto_acomp *tfm, struct comp_testvec *ctemplate, memset(output, 0, dlen); init_completion(&result.completion); - sg_init_one(&src, ctemplate[i].input, ilen); + sg_init_one(&src, __va(__pa_symbol(ctemplate[i].input)), ilen); sg_init_one(&dst, output, dlen); req = acomp_request_alloc(tfm); @@ -1513,7 +1513,7 @@ static int test_acomp(struct crypto_acomp *tfm, struct comp_testvec *ctemplate, memset(output, 0, dlen); init_completion(&result.completion); - sg_init_one(&src, dtemplate[i].input, ilen); + sg_init_one(&src, __va(__pa_symbol(dtemplate[i].input)), ilen); sg_init_one(&dst, output, dlen); req = acomp_request_alloc(tfm); -- 2.7.4