From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757801AbcLTMF2 (ORCPT ); Tue, 20 Dec 2016 07:05:28 -0500 Received: from mail-db5eur01on0133.outbound.protection.outlook.com ([104.47.2.133]:47488 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757531AbcLTMFZ (ORCPT ); Tue, 20 Dec 2016 07:05:25 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=peda@axentia.se; From: Peter Rosin To: linux-kernel@vger.kernel.org Cc: Peter Rosin , Sebastian Reichel , linux-pm@vger.kernel.org Subject: [PATCH 1/3] power: supply: bq24735: move down bq24735_{en,dis}able_charging Date: Tue, 20 Dec 2016 12:33:00 +0100 Message-Id: <1482233582-29770-2-git-send-email-peda@axentia.se> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1482233582-29770-1-git-send-email-peda@axentia.se> References: <1482233582-29770-1-git-send-email-peda@axentia.se> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [217.210.101.82] X-ClientProxiedBy: DB5PR0101CA0002.eurprd01.prod.exchangelabs.com (10.165.200.140) To DB6PR0201MB2312.eurprd02.prod.outlook.com (10.169.222.151) X-MS-Office365-Filtering-Correlation-Id: 379cafa5-dae4-4fc4-6da6-08d428cc0024 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:DB6PR0201MB2312; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0201MB2312;3:oCcRVRPVi8J6GQMCrhntqpHhUTs1R0RPQ2JC9dNCcawK0ReBCx7kJQJBlkOBjru1L4WInyCrPWHyGi9QemfQQ34GVfKGVlaocEt0gdpfAMV8FmVF/aKFdz6p6lQhREmUWXTt6EysUURHFW7XjquAPV3xSRLVJ1QqpOOPTsFmr+MxcR59wAIverdl5jUzwF41orkLtlxLKfXBYPj7M4RxrdFFCejiOjFhRMABwRXf6aPKf9hjPNmF8ayXvz50GzUVzVDkT5YqMbwzCBomeWAFUw== X-Microsoft-Exchange-Diagnostics: 1;DB6PR0201MB2312;25:gioX4Lwc94RvoDRkdX80yJXQwMbT5XFMqJQZ2w8XXZfKOa8EsdRm8oKIs+g9HYqUzT3jvwKg29zT19MVWQHKFoEXQ06BhykEqAwwjDQuNi6uepzoDUpsb4T74CuCmhHlhrUhdLaS8u/mz4QVO9HoSvjZ8qgK1LE7qZ1jNHkyjmtEAnNd2lhX5x1v/Q3H/9ui3j+1yOkw59KIx6aqaWqgh7PXUxZR/sI3ADBA5sFVGV1WTereCBZiNwXuwERsw+GepximXqFBBUrRx7w1UC5YsoUgvjKcqzTplTgjXM+zZwTf4nOou4pENOxrEXYUuSmxRK1wm/Z9oFeDkIkbgiX9WEPD/bLgEWWzp6f9dzgB1zHvsJDabIisfjES9kJA9AG7RyEbKGKtA2fIYU2S1A9JhdsbMDPDHVGfFA1d8p9Nli4/WxrLHVHwdTWAeWBlj5QMxNZHo26AM9p/xfXvQIeRox7fN83UMCy/3VynGv2UsKAqidEKs6NyRQTzRnjE63+mTslsilPfb87S78e7CcSMuR5xPvU6KP7oZYd2DkXitosDIsOd0Zgrfk797JTydIsLTVPDA/qaWWSwZWyoy/ZTNqpNM6v9gkT4h+qZ22GgBFQPuxfwVA6MfnGSmCxG+WYeGVWDAtBbfkXusjggQUX+prgj2VAXJscclNF8xRA+/2bFNKstSr9GhF/hET2zKw5b4TlAAxLDNce/m/2Q8ePJqt5yk2ZSFCgZrSXolBSU+BOSuNAgiaQJn/Uq37reRExRHLj17Z4dIyK+apGWcwJW1Q== X-Microsoft-Exchange-Diagnostics: 1;DB6PR0201MB2312;31:hWxVyExtJygShzPUZhKOTA3449dOPbptIGzVNfWW9d505Oo8o8EpvvwB5k/RnBDVE+LFd+8y+7yBA4Cky1fTQeGPeJciGPNQt4vcR7gTmQTEzbUdxFP95rflZCodbHQRSeF+NtKgCtnYocBnRUfq6uUHSbEOBjFTDA6Km1BmDx9UZ4GsQji0YQ0gfeFkbR5whroFkrtoNzNdVrgt9rHwDWbBE03OowtoZAgEwHq73wLN9RwP01+7f6Kd2VOGO13E;4:VP7EfxdJTqkJRK015NuwHu+av0MsAdcxtU9bnTHgrG2hNZgy57i8sBXc+rbSwbwieqUrWD5oCU/fHZErpfYgTf0hfvIEGIAEuyUo5Equ/5tLorpKJQPq6YSaZcu2JFpWveUNn0D2h8P+tzV0pcXbmJurC3DW8vezV1WNisvBstOvZqA4k2IHrHdbUYEppJh2kpr6s3NISRj9lbpRIvkeiNNG8R/XuzA1wOoVSabhwc3EBviWaZAgrOxfX46N1nsOBWKSuzIA648tZ9xoIl5HkPdozkqVXueVN+46zMujIKdietZYb5kp7Aar9hl8Mjwt3xq6h4beY5JfPyEgyVFuddSv5/M91afSaKi+s8JIgrHJn8e91xC089Ki0IndbmCqhVO2V/ODxhZBKFgY+uZYwwT4oaTQGm7vQivptYrP3/KHrUgEgoY4EWSL6Eo1IAOwI7FHuOYKtYatLNRN9kxFm83VIQX8YHvkczE1fmsabGfsxAXOtqd5mRdKy39XbCR9C65kJ5oarxCjJDPUDGIi/7tmGXqG0s5dTFrrGSu2+j9kRe+HAo7ZR7t3LUCLrZSZ2ctfUx8Xkl27O6iG4e8lRq/A36cqyJMLZkZH9lii4Vv6u1LliRJgK48TrlcVjrxN X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041248)(20161123562025)(20161123564025)(2016111802025)(20161123560025)(20161123555025)(6072148)(6043046);SRVR:DB6PR0201MB2312;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0201MB2312; X-Forefront-PRVS: 0162ACCC24 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6069001)(6009001)(7916002)(39830400002)(39450400003)(39410400002)(189002)(199003)(6916009)(86362001)(2351001)(97736004)(6486002)(2906002)(6506006)(101416001)(6512006)(2361001)(92566002)(7736002)(25786008)(305945005)(50226002)(68736007)(38730400001)(106356001)(8676002)(42186005)(81166006)(48376002)(50466002)(74482002)(36756003)(5660300001)(76176999)(4326007)(33646002)(81156014)(50986999)(66066001)(3846002)(189998001)(6666003)(110136003)(5003940100001)(6116002)(2950100002)(47776003)(105586002)(142933001)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:DB6PR0201MB2312;H:localhost.localdomain;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DB6PR0201MB2312;23:JCk1CvN+SdFMfLy4+dAyFaJe0V7cZcjhJ8EZCqD?= =?us-ascii?Q?WMw6BHYWbAeqkROGklKjHbfmUM1GVv1gpG5CUUfFCoVpdM6fUNNijO5cS/QL?= =?us-ascii?Q?AWAetRLchSKETkZjRl8zkMDon4OCzRjWrJjZHDsggB3Xfb6mgqKVfn2FfQmi?= =?us-ascii?Q?MTTe79hhezipeJAcS68FSxry91+OwfmHyTraS5nFTKdMRJPu3JT+pwDv2mh9?= =?us-ascii?Q?Y17o8yO3uRBOCgdbix4EtIsZlv2PZ+xdnzSA74zOHBlcHEJmsDXkuee3dnpA?= =?us-ascii?Q?jx2DavbWp7vk4PNL+ukJ3KVEfbdDFnrjm8B1rlYU8SZ7W0i+oBBbvaYqs9O8?= =?us-ascii?Q?YAxMyYp1YH9kyK7Ch+5QUWrJysk5i0JJHfuCd41QU570oI1SZ4bl6NLbxuAM?= =?us-ascii?Q?siaJlIArRo7cAHscjYP9CvDzC4rlDkwcPIPxCaBeG/xXt738m4/ccx0KvJqc?= =?us-ascii?Q?z1GyTw5T/yG1rRAUp1UZwGNjuEZRF7rygZr82XvbhiZErj6ijOjWkYUSMHwH?= =?us-ascii?Q?XzyRK+sVY/mIQnndU7ZKyveMKj96tKnapE3t6eI1RzeoLEvkc7WIWs4801FN?= =?us-ascii?Q?c6F80ZQDeJd+GDObEhFeMSX8ojw6gQ1Jqk75rKVq8ciecHN5L7y439/EJ8O+?= =?us-ascii?Q?d0tM+UMkPUC39MYoEbQQFirYraUo2YgH2J95sH6fBAQPManSQKR/Y0UpNOf3?= =?us-ascii?Q?NBpKISXcWJbWOJ/A+UOgetWpZdFibenYixu5jZaWplI/YTE5/i3oNeka1NFj?= =?us-ascii?Q?vfI73YBcqzgosSTSWa0boZ1C821pNg/HwjhkggSbFp62oORjWjUy6IwjrUQw?= =?us-ascii?Q?+YUejP9iXlxVVJghlGdqL72QO9+PbGxQjJOkaIxi08zMSNKT60jk8xjuv8NN?= =?us-ascii?Q?EO1Mr54+itINuTDf3U6u+qWSzw/d9SzMdTTCvCqrNt3lc8a4+20V5KetPNiz?= =?us-ascii?Q?/0hF4psZFJGhFcgv6ooYhL2ujXuhIZ32Byk9chSNNMQHundoV1Im09wWDkA/?= =?us-ascii?Q?k7A10beHdDksNCqXrHjgNipme7wC5n35zNZXwnF+GEHXjPuu7JRVhXRXjpRM?= =?us-ascii?Q?5cvK+zCjZBu1Mpwsvm0jd4PsaT8SMeXcAyUaavhM2mb9J729Ys/BSUna/NEf?= =?us-ascii?Q?qxK+bc8sqWiNDjpi0axn3qgxy/tTq+TgbOdOqyfsswcAx2kZV9LNIr0YQ5ei?= =?us-ascii?Q?LWqt/NCXGNn6ZzefKf2SeHh54aifw7MTmaRMqwHrI0OBGqwjvRAC/8hxoiId?= =?us-ascii?Q?zJPUTYYUkTqQzOrGwefg=3D?= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0201MB2312;6:QFMnEX5/ZVaeNu1HXK6HnyJ4SpBpF1meQQihdeSyidrTLY5iYZ10Q7Swmz24BStR+qWMZU3b/WwhmwHzFHHr39TEFU1uXX73UrmAd0DeUP0FZ4Rrf/7Y0feiQ+r77SfPK2CpdzKjUZLHoMZDXz2aylksfRGaLKR4V+x0/UV76nVv5t8fVJBMKyqDKpKCewXCiIEU1WSdTIGbxZe3xa375qkZWXbKj71EJD3feb8Tcu1tQbGSPAWEWCtBUsLseLc8KJhwVZ/RmjBYpuGtILsmmVZvG40vgWDcqArmvtXJ/pXZqWN1BFwGHAFShG+v2w56/flT3lWUxofwcYHMlkTG4jCxXKzBMBUCejLvwy26Jggxzt87aI6lQm11eRLk/WAJt0AQeryFzEKHkvaJki30TZ5WGlAsrFg3oCQZaPtnme51Nsh+z828jQ2WLxoLp+tY;5:AvFBaR7EFWclQezqACJ3KNc7RKqNau5lcdi+gvewQ8ZUVXoMCL4l1KdB46G4PCDkDCJ0JRWq5VP24UVBHvaX6AvEKl4lehCnq2GqFqd0Iq5BUvfqdflkGcZ48KdmBqwHtFgNWGLbBN56/aHLgOeRrQ==;24:42+Rf3MRX//1vEKUlBtEtdTtOYZrurtmurc3/i6l+yYEfZmcDgO4W4ctQjUuXjB0wQqf/pJlA4NyCr7e5OGxsEut+YwNc6xVuQbwQiH07Ec= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DB6PR0201MB2312;7:69IQ4csKz9ShSPwhuNUQu4ftf9Olg7Rkmv/hz7k0n+CSLU+Ed49PE6WAtNTPEkXuDKdV6eikkaZ+ev3S8R8+98WHpI1MibfLRPcwwL6g2tzTms48/XlhwFO9wPr8ROK4rUMT1+kW8wY13Y0pQ37qPhkDq7u8YnVswUFdY8yc+z5TTkWW4SFYofzLDoMYYgkX4iqXLdwTGzFF0QaFFDGvPV7/xbPv3DQKxRteIYv6/DKxXKf6exLrr+YUUJISz8VXXohJRAqqBSPf6oT3AsfX/8DWkgkgvaTGTT/B1dZjyLxd2Jnrz3X9NnLyfHNRiaqUyipLv4py1LDug23WX5I/67h8tcf2gffpDcQDHY3asoiUJZUZXhDssn64FKhSa2ZsYPxC7vUSTUBc3cvofwPRTYbH3gLSbR3/tfTMei6yQII433MNvS/KUcQZz8OBp3pcbLJb5/B6kWrlbSQPjMWWJg== X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2016 11:33:20.0343 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0201MB2312 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org bq24735_enable_charging() needs to call bq24735_config_charging(), which is something to change later, this is just a preparatory patch. Signed-off-by: Peter Rosin --- drivers/power/supply/bq24735-charger.c | 38 +++++++++++++++++----------------- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/drivers/power/supply/bq24735-charger.c b/drivers/power/supply/bq24735-charger.c index 8a0242c13b7e..2787c19d6696 100644 --- a/drivers/power/supply/bq24735-charger.c +++ b/drivers/power/supply/bq24735-charger.c @@ -107,25 +107,6 @@ static int bq24735_update_word(struct i2c_client *client, u8 reg, return bq24735_write_word(client, reg, tmp); } -static inline int bq24735_enable_charging(struct bq24735 *charger) -{ - if (charger->pdata->ext_control) - return 0; - - return bq24735_update_word(charger->client, BQ24735_CHG_OPT, - BQ24735_CHG_OPT_CHARGE_DISABLE, 0); -} - -static inline int bq24735_disable_charging(struct bq24735 *charger) -{ - if (charger->pdata->ext_control) - return 0; - - return bq24735_update_word(charger->client, BQ24735_CHG_OPT, - BQ24735_CHG_OPT_CHARGE_DISABLE, - BQ24735_CHG_OPT_CHARGE_DISABLE); -} - static int bq24735_config_charger(struct bq24735 *charger) { struct bq24735_platform *pdata = charger->pdata; @@ -177,6 +158,25 @@ static int bq24735_config_charger(struct bq24735 *charger) return 0; } +static inline int bq24735_enable_charging(struct bq24735 *charger) +{ + if (charger->pdata->ext_control) + return 0; + + return bq24735_update_word(charger->client, BQ24735_CHG_OPT, + BQ24735_CHG_OPT_CHARGE_DISABLE, 0); +} + +static inline int bq24735_disable_charging(struct bq24735 *charger) +{ + if (charger->pdata->ext_control) + return 0; + + return bq24735_update_word(charger->client, BQ24735_CHG_OPT, + BQ24735_CHG_OPT_CHARGE_DISABLE, + BQ24735_CHG_OPT_CHARGE_DISABLE); +} + static bool bq24735_charger_is_present(struct bq24735 *charger) { if (charger->status_gpio) { -- 2.1.4