From: Joe Perches <joe@perches.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>,
linux-i2c@vger.kernel.org
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Wolfram Sang <wsa@the-dreams.de>
Subject: Re: [PATCH] i2c: uniphier[-f]: fix bool logic calculation
Date: Tue, 20 Dec 2016 09:55:38 -0800 [thread overview]
Message-ID: <1482256538.1984.23.camel@perches.com> (raw)
In-Reply-To: <CAK7LNATrR9dSuuUZR98f=uOZqSGqUBnUNZmrUqUZgubHHE+X4A@mail.gmail.com>
On Wed, 2016-12-21 at 01:20 +0900, Masahiro Yamada wrote:
> Hi.
>
> I have not got any comment, but does this seem
> a right thing to do?
> This code is working, but it should not depend on how "bool" is
> typedef'ed, or the bit position of I2C_M_RD.
<shrug>
I think bool can be guaranteed to be _Bool.
So a change not necessary as the original code
has a c90 guarantee of the same result.
6.3.1.2 Boolean type
1
When any scalar value is converted to _Bool, the result is 0 if the value compares equal
to 0; otherwise, the result is 1.
> 2016-10-19 13:38 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
[]
> > diff --git a/drivers/i2c/busses/i2c-uniphier-f.c b/drivers/i2c/busses/i2c-uniphier-f.c
[]
> > @@ -309,7 +309,7 @@ static int uniphier_fi2c_master_xfer_one(struct i2c_adapter *adap,
> > struct i2c_msg *msg, bool stop)
> > {
> > struct uniphier_fi2c_priv *priv = i2c_get_adapdata(adap);
> > - bool is_read = msg->flags & I2C_M_RD;
> > + bool is_read = !!(msg->flags & I2C_M_RD);
> > unsigned long time_left;
> >
> > dev_dbg(&adap->dev, "%s: addr=0x%02x, len=%d, stop=%d\n",
next prev parent reply other threads:[~2016-12-20 17:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 4:38 Masahiro Yamada
2016-12-20 16:20 ` Masahiro Yamada
2016-12-20 17:55 ` Joe Perches [this message]
2016-12-21 15:39 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1482256538.1984.23.camel@perches.com \
--to=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
--cc=yamada.masahiro@socionext.com \
--subject='Re: [PATCH] i2c: uniphier[-f]: fix bool logic calculation' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).