From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756918AbcLUDYf (ORCPT ); Tue, 20 Dec 2016 22:24:35 -0500 Received: from smtprelay0184.hostedemail.com ([216.40.44.184]:60840 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755266AbcLUDYd (ORCPT ); Tue, 20 Dec 2016 22:24:33 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2691:2828:3138:3139:3140:3141:3142:3353:3622:3865:3867:3868:3870:3871:3872:3873:4321:5007:8957:10004:10400:10848:11232:11657:11658:11914:12043:12296:12438:12740:12760:12895:13069:13071:13161:13229:13311:13357:13439:14096:14097:14180:14659:14721:21080:30012:30054:30080:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: dog03_5b20de91eaf32 X-Filterd-Recvd-Size: 2575 Message-ID: <1482290625.1984.33.camel@perches.com> Subject: Re: [PATCH] indention and space fixes to align with linux style From: Joe Perches To: Scott Matheina , gregkh@linuxfoundation.org Cc: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Hartmut Knaack , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Tue, 20 Dec 2016 19:23:45 -0800 In-Reply-To: <1482289187-7276-1-git-send-email-scott@matheina.com> References: <1482289187-7276-1-git-send-email-scott@matheina.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.1-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-12-20 at 20:58 -0600, Scott Matheina wrote: > Fixed indention and space issues to align the code with the linux style guide. [] > diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c [] > @@ -176,16 +176,16 @@ > */ > > struct adt7316_chip_info { > - struct adt7316_bus bus; > - u16 ldac_pin; > - u16 int_mask; /* 0x2f */ > - u8 config1; > - u8 config2; > - u8 config3; > - u8 dac_config; /* DAC config */ > - u8 ldac_config; /* LDAC config */ > - u8 dac_bits; /* 8, 10, 12 */ > - u8 id; /* chip id */ > + struct adt7316_bus bus; > + u16 ldac_pin; > + u16 int_mask; /* 0x2f */ > + u8 config1; > + u8 config2; > + u8 config3; > + u8 dac_config; /* DAC config */ > + u8 ldac_config; /* LDAC config */ > + u8 dac_bits; /* 8, 10, 12 */ > + u8 id; /* chip id */ > }; Hello Scott. I believe you're relatively new at this patch submission stuff. The style above is fine and doesn't need to be changed. It is not in CodingStyle as preferred one way or the other. > /* > @@ -212,13 +212,12 @@ struct adt7316_chip_info { > */ > > struct adt7316_limit_regs { > - u16 data_high; > - u16 data_low; > + u16 data_high; > + u16 data_low; > }; > > static ssize_t adt7316_show_enabled(struct device *dev, > - struct device_attribute *attr, > - char *buf) > + struct device_attribute *attr, char *buf) This one isn't either but it is a very common style in net/, drivers/net, and drivers/staging though.