linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [v1] gpu: drm: sti: sti_vtac:- Handle return NULL error from devm_ioremap_nocache
@ 2016-12-21  5:22 Arvind Yadav
  2017-01-04  9:31 ` Vincent ABRIOU
  0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2016-12-21  5:22 UTC (permalink / raw)
  To: benjamin.gaignard, vincent.abriou, airlied; +Cc: dri-devel, linux-kernel

Here, If devm_ioremap_nocache will fail. It will return NULL.
Kernel can run into a NULL-pointer dereference. This error check
will avoid NULL pointer dereference.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/gpu/drm/sti/sti_vtac.c |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/sti/sti_vtac.c b/drivers/gpu/drm/sti/sti_vtac.c
index cf7fe8a..dd749e9 100644
--- a/drivers/gpu/drm/sti/sti_vtac.c
+++ b/drivers/gpu/drm/sti/sti_vtac.c
@@ -191,6 +191,10 @@ static int sti_vtac_probe(struct platform_device *pdev)
 	if (res) {
 		vtac->phy_regs = devm_ioremap_nocache(dev, res->start,
 						 resource_size(res));
+			if (!vtac->phy_regs) {
+				DRM_ERROR("failed to remap I/O memory\n");
+				return -ENOMEM;
+			}
 		sti_vtac_tx_set_config(vtac);
 	} else {
 
-- 
1.7.9.5

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [v1] gpu: drm: sti: sti_vtac:- Handle return NULL error from devm_ioremap_nocache
  2016-12-21  5:22 [v1] gpu: drm: sti: sti_vtac:- Handle return NULL error from devm_ioremap_nocache Arvind Yadav
@ 2017-01-04  9:31 ` Vincent ABRIOU
  0 siblings, 0 replies; 2+ messages in thread
From: Vincent ABRIOU @ 2017-01-04  9:31 UTC (permalink / raw)
  To: Arvind Yadav, benjamin.gaignard, airlied; +Cc: dri-devel, linux-kernel

Hi Arvind,

Thank for this patch.
Since sti_vtac.c file is deprecated, I rather suppress the sti_vtac.c file.
I just push a new patch to suppress it.

Thank for pointing this out.
Br
Vincent

On 12/21/2016 06:22 AM, Arvind Yadav wrote:
> Here, If devm_ioremap_nocache will fail. It will return NULL.
> Kernel can run into a NULL-pointer dereference. This error check
> will avoid NULL pointer dereference.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>  drivers/gpu/drm/sti/sti_vtac.c |    4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/sti/sti_vtac.c b/drivers/gpu/drm/sti/sti_vtac.c
> index cf7fe8a..dd749e9 100644
> --- a/drivers/gpu/drm/sti/sti_vtac.c
> +++ b/drivers/gpu/drm/sti/sti_vtac.c
> @@ -191,6 +191,10 @@ static int sti_vtac_probe(struct platform_device *pdev)
>  	if (res) {
>  		vtac->phy_regs = devm_ioremap_nocache(dev, res->start,
>  						 resource_size(res));
> +			if (!vtac->phy_regs) {
> +				DRM_ERROR("failed to remap I/O memory\n");
> +				return -ENOMEM;
> +			}
>  		sti_vtac_tx_set_config(vtac);
>  	} else {
>
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-01-04  9:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-21  5:22 [v1] gpu: drm: sti: sti_vtac:- Handle return NULL error from devm_ioremap_nocache Arvind Yadav
2017-01-04  9:31 ` Vincent ABRIOU

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).