linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ewan D. Milne" <emilne@redhat.com>
To: Burak Ok <burak-kernel@bur0k.de>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
	Martin K Petersen <martin.petersen@oracle.com>,
	James E J Bottomley <jejb@linux.vnet.ibm.com>,
	Sesidhar Baddela <sebaddel@cisco.com>,
	Karan Tilak Kumar <kartilak@cisco.com>,
	Narsimhulu Musini <nmusini@cisco.com>,
	linux-kernel@i4.cs.fau.de,
	Andreas Schaertl <andreas.schaertl@fau.de>
Subject: Re: [PATCH] snic: Return error code on memory allocation failure
Date: Wed, 21 Dec 2016 11:31:37 -0500	[thread overview]
Message-ID: <1482337897.8200.83.camel@localhost.localdomain> (raw)
In-Reply-To: <1482327953-4140-1-git-send-email-burak-kernel@bur0k.de>

On Wed, 2016-12-21 at 14:45 +0100, Burak Ok wrote:
> If a call to mempool_create_slab_pool() in snic_probe() returns NULL,
> return -ENOMEM to indicate failure. mempool_creat_slab_pool() only fails if
> it cannot allocate memory.
> 
> https://bugzilla.kernel.org/show_bug.cgi?id=189061
> 
> Reported-by: bianpan2010@ruc.edu.cn
> Signed-off-by: Burak Ok <burak-kernel@bur0k.de>
> Signed-off-by: Andreas Schaertl <andreas.schaertl@fau.de>
> ---
>  drivers/scsi/snic/snic_main.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/scsi/snic/snic_main.c b/drivers/scsi/snic/snic_main.c
> index 396b32d..7cf70aa 100644
> --- a/drivers/scsi/snic/snic_main.c
> +++ b/drivers/scsi/snic/snic_main.c
> @@ -591,6 +591,7 @@ snic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>  	if (!pool) {
>  		SNIC_HOST_ERR(shost, "dflt sgl pool creation failed\n");
>  
> +		ret = -ENOMEM;
>  		goto err_free_res;
>  	}
>  
> @@ -601,6 +602,7 @@ snic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>  	if (!pool) {
>  		SNIC_HOST_ERR(shost, "max sgl pool creation failed\n");
>  
> +		ret = -ENOMEM;
>  		goto err_free_dflt_sgl_pool;
>  	}
>  
> @@ -611,6 +613,7 @@ snic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>  	if (!pool) {
>  		SNIC_HOST_ERR(shost, "snic tmreq info pool creation failed.\n");
>  
> +		ret = -ENOMEM;
>  		goto err_free_max_sgl_pool;
>  	}
>  

Reviewed-by: Ewan D. Milne <emilne@redhat.com>

  parent reply	other threads:[~2016-12-21 16:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-21 13:45 Burak Ok
2016-12-21 15:07 ` Narsimhulu Musini (nmusini)
2016-12-21 16:31 ` Ewan D. Milne [this message]
2017-01-06  1:46 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1482337897.8200.83.camel@localhost.localdomain \
    --to=emilne@redhat.com \
    --cc=andreas.schaertl@fau.de \
    --cc=burak-kernel@bur0k.de \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=kartilak@cisco.com \
    --cc=linux-kernel@i4.cs.fau.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=nmusini@cisco.com \
    --cc=sebaddel@cisco.com \
    --subject='Re: [PATCH] snic: Return error code on memory allocation failure' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).