From: Joe Perches <joe@perches.com>
To: Colin King <colin.king@canonical.com>, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: fddi: skfp: use %p format specifier for addresses rather than %x
Date: Wed, 21 Dec 2016 09:15:46 -0800 [thread overview]
Message-ID: <1482340546.1945.1.camel@perches.com> (raw)
In-Reply-To: <20161221160323.27780-1-colin.king@canonical.com>
On Wed, 2016-12-21 at 16:03 +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Trivial fix: Addresses should be printed using the %p format specifier
> rather than using %x.
The DB_TX, DB_RX, DB_GEN, and DB_SMT macros are quite ugly
because they don't match format and argument with __printf
and could be updated quite easily.
Does anyone still use these drivers?
next prev parent reply other threads:[~2016-12-21 17:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-21 16:03 [PATCH] net: fddi: skfp: use %p format specifier for addresses rather than %x Colin King
2016-12-21 17:15 ` Joe Perches [this message]
2016-12-21 20:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1482340546.1945.1.camel@perches.com \
--to=joe@perches.com \
--cc=colin.king@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).