From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760667AbcLURPv (ORCPT ); Wed, 21 Dec 2016 12:15:51 -0500 Received: from smtprelay0125.hostedemail.com ([216.40.44.125]:41306 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758289AbcLURPt (ORCPT ); Wed, 21 Dec 2016 12:15:49 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 30,2,0,,d41d8cd98f00b204,joe@perches.com,:::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1567:1593:1594:1711:1714:1730:1747:1777:1792:2194:2199:2393:2559:2562:2828:2895:3138:3139:3140:3141:3142:3622:3865:3868:4321:5007:7576:10004:10400:10848:11232:11658:11914:12296:12740:12760:12895:13069:13161:13229:13255:13311:13357:13439:13523:13524:14181:14659:14721:21080:21451:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: run27_4fa4729ddbc34 X-Filterd-Recvd-Size: 1180 Message-ID: <1482340546.1945.1.camel@perches.com> Subject: Re: [PATCH] net: fddi: skfp: use %p format specifier for addresses rather than %x From: Joe Perches To: Colin King , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org Date: Wed, 21 Dec 2016 09:15:46 -0800 In-Reply-To: <20161221160323.27780-1-colin.king@canonical.com> References: <20161221160323.27780-1-colin.king@canonical.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.1-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2016-12-21 at 16:03 +0000, Colin King wrote: > From: Colin Ian King > > Trivial fix: Addresses should be printed using the %p format specifier > rather than using %x. The DB_TX, DB_RX, DB_GEN, and DB_SMT macros are quite ugly because they don't match format and argument with __printf and could be updated quite easily. Does anyone still use these drivers?