From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S939002AbcLVKVx (ORCPT ); Thu, 22 Dec 2016 05:21:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35292 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754197AbcLVKVv (ORCPT ); Thu, 22 Dec 2016 05:21:51 -0500 Message-ID: <1482402107.3184.3.camel@redhat.com> Subject: Re: [PATCH] x86/efi Fix regression in efi_arch_mem_reserve From: Petr Oros Reply-To: poros@redhat.com To: Matt Fleming Cc: ard.biesheuvel@linaro.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 22 Dec 2016 11:21:47 +0100 In-Reply-To: <20161221223054.GG2225@codeblueprint.co.uk> References: <20161221131138.10512-1-poros@redhat.com> <20161221223054.GG2225@codeblueprint.co.uk> Organization: Red Hat Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 22 Dec 2016 10:21:51 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Matt Fleming píše v Wed 21. 12. 2016 v 22:30 +0000: > On Wed, 21 Dec, at 02:11:38PM, Petr Oros wrote: > > > >   Booting on EFI with ESRT table has been stop since commit: > >     8e80632 efi/esrt: Use efi_mem_reserve() and avoid a kmalloc() > > > >   This is caused by this commit: > >     816e761 efi: Allow drivers to reserve boot services forever > > > >   Problem is, that efi_memmap_insert need memory aligned > >   on EFI_PAGE_SIZE. If memory not aligned, efi_memmap_insert > >   just return and let efi.memmap in inconsistent state. > >   This breaking boot. > > > >   Tested in my machine, which stop booting > >   after upgrade to 4.9 > > > > Signed-off-by: Petr Oros > > --- > >  arch/x86/platform/efi/quirks.c | 2 +- > >  1 file changed, 1 insertion(+), 1 deletion(-) > > Could you provide some more information? Why does efi_memmap_insert() > require this alignment? How does booting "break"? If you see an Oops, > please post it here. Ooops, sorry, please ignore this patch. I overlooked efi_memmap_insert argument order. I bisected kernel and this patch breaking kernel boot but from other reason. Provided patch fixed kernel booting issue by mistake. -Petr