From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966236AbcLWA4l (ORCPT ); Thu, 22 Dec 2016 19:56:41 -0500 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:54966 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S941793AbcLWA4j (ORCPT ); Thu, 22 Dec 2016 19:56:39 -0500 Message-ID: <1482454594.2415.72.camel@HansenPartnership.com> Subject: Re: linux-next: build failure after merge of the scsi tree From: James Bottomley To: Stephen Rothwell , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Peter Zijlstra Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Manish Rangankar , "Martin K. Petersen" , Nilesh Javali , Adheer Chandravanshi , Chad Dupuis , Saurav Kashyap , Arun Easi , Sebastian Andrzej Siewior Date: Thu, 22 Dec 2016 16:56:34 -0800 In-Reply-To: <20161223114513.101402e4@canb.auug.org.au> References: <20161223114513.101402e4@canb.auug.org.au> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-12-23 at 11:45 +1100, Stephen Rothwell wrote: > Hi James, > > After merging the scsi tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/scsi/qedi/qedi_main.c: In function 'qedi_init': > drivers/scsi/qedi/qedi_main.c:2073:2: error: implicit declaration of > function 'register_hotcpu_notifier' [-Werror=implicit-function > -declaration] > register_hotcpu_notifier(&qedi_cpu_notifier); > ^ > drivers/scsi/qedi/qedi_main.c: In function 'qedi_cleanup': > drivers/scsi/qedi/qedi_main.c:2113:2: error: implicit declaration of > function 'unregister_hotcpu_notifier' [-Werror=implicit-function > -declaration] > unregister_hotcpu_notifier(&qedi_cpu_notifier); > ^ > > Caused by commit > > ace7f46ba5fd ("scsi: qedi: Add QLogic FastLinQ offload iSCSI driver > framework.") > > Interacting with commit > > 8e38db753d95 ("cpu/hotplug: Remove obsolete cpu hotplug > register/unregister functions") > > from the tip tree. Well, that's a bit of a problem given that the SCSI tree has a pending pull request including this driver. Thomas, can you do another fixup in your tip tree like you did for the two BNX2* drivers? Thanks, James