* [PATCH] ib umem: bugfix: mixed put_pid()s in ib_umem_get()
@ 2016-12-29 2:24 Kenneth Lee
2016-12-29 5:29 ` Leon Romanovsky
0 siblings, 1 reply; 2+ messages in thread
From: Kenneth Lee @ 2016-12-29 2:24 UTC (permalink / raw)
To: dledford, sean.hefty, hal.rosenstock
Cc: robin.murphy, jroedel, egtvedt, vgupta, liguozhu, dave.hansen,
lstoakes, krzk, sebott, markb, linux-rdma, linux-kernel
There are two bugfixes in this patch:
1. When the execution go to the ib_umem_odp_get() path, pid should be put
back.
2. When the memory allocation fail, the pid also should be put back before
exit.
Signed-off-by: Kenneth Lee <liguozhu@hisilicon.com>
---
drivers/infiniband/core/umem.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/infiniband/core/umem.c b/drivers/infiniband/core/umem.c
index 1e62a5f..4609b92 100644
--- a/drivers/infiniband/core/umem.c
+++ b/drivers/infiniband/core/umem.c
@@ -134,6 +134,7 @@ struct ib_umem *ib_umem_get(struct ib_ucontext *context, unsigned long addr,
IB_ACCESS_REMOTE_ATOMIC | IB_ACCESS_MW_BIND));
if (access & IB_ACCESS_ON_DEMAND) {
+ put_pid(umem->pid);
ret = ib_umem_odp_get(context, umem);
if (ret) {
kfree(umem);
@@ -149,6 +150,7 @@ struct ib_umem *ib_umem_get(struct ib_ucontext *context, unsigned long addr,
page_list = (struct page **) __get_free_page(GFP_KERNEL);
if (!page_list) {
+ put_pid(umem->pid);
kfree(umem);
return ERR_PTR(-ENOMEM);
}
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ib umem: bugfix: mixed put_pid()s in ib_umem_get()
2016-12-29 2:24 [PATCH] ib umem: bugfix: mixed put_pid()s in ib_umem_get() Kenneth Lee
@ 2016-12-29 5:29 ` Leon Romanovsky
0 siblings, 0 replies; 2+ messages in thread
From: Leon Romanovsky @ 2016-12-29 5:29 UTC (permalink / raw)
To: Kenneth Lee
Cc: dledford, sean.hefty, hal.rosenstock, robin.murphy, jroedel,
egtvedt, vgupta, dave.hansen, lstoakes, krzk, sebott, markb,
linux-rdma, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 723 bytes --]
On Thu, Dec 29, 2016 at 10:24:43AM +0800, Kenneth Lee wrote:
> There are two bugfixes in this patch:
>
> 1. When the execution go to the ib_umem_odp_get() path, pid should be put
> back.
> 2. When the memory allocation fail, the pid also should be put back before
> exit.
>
> Signed-off-by: Kenneth Lee <liguozhu@hisilicon.com>
Hi Kenneth,
Thank you for resubmitting it. This fix is important and no doubts that
it will be accepted, however you need to improve the patch a little bit
more.
CAn you please resubmit it according to Documentation/SubmittingPatches
and reviewers feedback?
Haggai's Reviewed-by tag, Fixes, changelog, version in title and
proper title (see it in git log for this subsystems).
Thanks
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-29 5:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-29 2:24 [PATCH] ib umem: bugfix: mixed put_pid()s in ib_umem_get() Kenneth Lee
2016-12-29 5:29 ` Leon Romanovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).