From: Kenneth Lee <liguozhu@hisilicon.com>
To: <dledford@redhat.com>, <sean.hefty@intel.com>,
<hal.rosenstock@gmail.com>
Cc: <robin.murphy@arm.com>, <jroedel@suse.de>, <egtvedt@samfundet.no>,
<vgupta@synopsys.com>, <liguozhu@hisilicon.com>,
<dave.hansen@linux.intel.com>, <lstoakes@gmail.com>,
<krzk@kernel.org>, <sebott@linux.vnet.ibm.com>,
<markb@mellanox.com>, <linux-rdma@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH v2] ib umem: bugfix: mixed put_pid()s in ib_umem_get()
Date: Thu, 29 Dec 2016 16:27:28 +0800 [thread overview]
Message-ID: <1483000048-183875-1-git-send-email-liguozhu@hisilicon.com> (raw)
There are two bugfixes in this patch:
1. When the execution go to the ib_umem_odp_get() path, pid should be put
back.
2. When the memory allocation fail, the pid also should be put back before
exit.
Signed-off-by: Kenneth Lee <liguozhu@hisilicon.com>
Reviewed-by: Haggai Eran <haggaie@mellanox.com>
---
Change from v1 to v2:
Correcting the patch title and description
drivers/infiniband/core/umem.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/infiniband/core/umem.c b/drivers/infiniband/core/umem.c
index 1e62a5f..4609b92 100644
--- a/drivers/infiniband/core/umem.c
+++ b/drivers/infiniband/core/umem.c
@@ -134,6 +134,7 @@ struct ib_umem *ib_umem_get(struct ib_ucontext *context, unsigned long addr,
IB_ACCESS_REMOTE_ATOMIC | IB_ACCESS_MW_BIND));
if (access & IB_ACCESS_ON_DEMAND) {
+ put_pid(umem->pid);
ret = ib_umem_odp_get(context, umem);
if (ret) {
kfree(umem);
@@ -149,6 +150,7 @@ struct ib_umem *ib_umem_get(struct ib_ucontext *context, unsigned long addr,
page_list = (struct page **) __get_free_page(GFP_KERNEL);
if (!page_list) {
+ put_pid(umem->pid);
kfree(umem);
return ERR_PTR(-ENOMEM);
}
--
1.9.1
next reply other threads:[~2016-12-29 8:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-29 8:27 Kenneth Lee [this message]
2016-12-29 8:17 ` [PATCH v2] ib umem: bugfix: mixed put_pid()s in ib_umem_get() Leon Romanovsky
2016-12-30 4:50 ` Kenneth Lee
2016-12-30 6:55 ` Leon Romanovsky
2016-12-30 10:24 ` Kenneth Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1483000048-183875-1-git-send-email-liguozhu@hisilicon.com \
--to=liguozhu@hisilicon.com \
--cc=dave.hansen@linux.intel.com \
--cc=dledford@redhat.com \
--cc=egtvedt@samfundet.no \
--cc=hal.rosenstock@gmail.com \
--cc=jroedel@suse.de \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=lstoakes@gmail.com \
--cc=markb@mellanox.com \
--cc=robin.murphy@arm.com \
--cc=sean.hefty@intel.com \
--cc=sebott@linux.vnet.ibm.com \
--cc=vgupta@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).