From: Olof Johansson <olof@lixom.net>
To: torvalds@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, linux-mm@vger.kernel.org,
Olof Johansson <olof@lixom.net>
Subject: [PATCH] mm/filemap: fix parameters to test_bit()
Date: Thu, 29 Dec 2016 14:16:07 -0800 [thread overview]
Message-ID: <1483049767-25944-1-git-send-email-olof@lixom.net> (raw)
In-Reply-To: <CA+55aFxGz8R8J9jLvKpLUgyhWVYcgtObhbHBP7eZzZyc05AODw@mail.gmail.com>
mm/filemap.c: In function 'clear_bit_unlock_is_negative_byte':
mm/filemap.c:933:9: error: too few arguments to function 'test_bit'
return test_bit(PG_waiters);
^~~~~~~~
In file included from arch/arm/include/asm/bitops.h:122:0,
from include/linux/bitops.h:36,
from include/linux/kernel.h:10,
from include/linux/list.h:8,
from include/linux/wait.h:6,
from include/linux/fs.h:5,
from lude/linux/dax.h:4,
from mm/filemap.c:14:
include/asm-generic/bitops/non-atomic.h:103:19: note: declared here
static inline int test_bit(int nr, const volatile unsigned long *addr)
^~~~~~~~
mm/filemap.c:934:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^
scripts/Makefile.build:293: recipe for target 'mm/filemap.o' failed
Fixes: b91e1302ad9b ('mm: optimize PageWaiters bit use for unlock_page()')
Signed-off-by: Olof Johansson <olof@lixom.net>
---
mm/filemap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/filemap.c b/mm/filemap.c
index 6b1d96f..d0e4d10 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -930,7 +930,7 @@ static inline bool clear_bit_unlock_is_negative_byte(long nr, volatile void *mem
{
clear_bit_unlock(nr, mem);
/* smp_mb__after_atomic(); */
- return test_bit(PG_waiters);
+ return test_bit(PG_waiters, mem);
}
#endif
--
2.8.0.rc3.29.gb552ff8
prev parent reply other threads:[~2016-12-29 22:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-25 3:00 [PATCH 0/2] PageWaiters again Nicholas Piggin
2016-12-25 3:00 ` [PATCH 1/2] mm: Use owner_priv bit for PageSwapCache, valid when PageSwapBacked Nicholas Piggin
2016-12-25 5:13 ` Hugh Dickins
2016-12-25 3:00 ` [PATCH 2/2] mm: add PageWaiters indicating tasks are waiting for a page bit Nicholas Piggin
2016-12-25 21:51 ` Linus Torvalds
2016-12-26 1:16 ` Nicholas Piggin
2016-12-26 19:07 ` Linus Torvalds
2016-12-27 11:19 ` Nicholas Piggin
2016-12-27 18:58 ` Linus Torvalds
2016-12-27 19:23 ` Linus Torvalds
2016-12-27 19:24 ` Linus Torvalds
2016-12-27 19:40 ` Linus Torvalds
2016-12-27 20:17 ` Linus Torvalds
2016-12-28 3:53 ` Nicholas Piggin
2016-12-28 19:17 ` Linus Torvalds
2016-12-29 4:08 ` Nicholas Piggin
2016-12-29 4:16 ` Linus Torvalds
2016-12-29 5:26 ` Nicholas Piggin
2017-01-03 10:24 ` Mel Gorman
2017-01-03 12:29 ` Nicholas Piggin
2017-01-03 17:18 ` Mel Gorman
2016-12-29 22:16 ` Olof Johansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1483049767-25944-1-git-send-email-olof@lixom.net \
--to=olof@lixom.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).