From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753427AbcL3CiI (ORCPT <rfc822;w@1wt.eu>);
        Thu, 29 Dec 2016 21:38:08 -0500
Received: from faui40.informatik.uni-erlangen.de ([131.188.34.40]:34723 "EHLO
        faui40.informatik.uni-erlangen.de" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1751075AbcL3CiH (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 29 Dec 2016 21:38:07 -0500
From: Thomas Preisner <thomas.preisner+linux@fau.de>
To: dave@thedillows.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-kernel@i4.cs.fau.de, milan.stephan+linux@fau.de,
        thomas.preisner+linux@fau.de, sergei.shtylyov@cogentembedded.com,
        davem@davemloft.net
Subject: Re: Re: [PATCH v3 2/2] drivers: net: ethernet: 3com: fix return value
Date: Fri, 30 Dec 2016 03:37:52 +0100
Message-Id: <1483065474-11512-1-git-send-email-thomas.preisner+linux@fau.de>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1482873453.20986.4.camel@dillow-glaptop.roam.corp.google.com>
References: <1482873453.20986.4.camel@dillow-glaptop.roam.corp.google.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 2016-12-27 at 22:17:35 +0100, David Dillow wrote:
>On Sun, 2016-12-25 at 01:30 +0100, Thomas Preisner wrote:
>> In some cases the return value of a failing function is not being used
>> and the function typhoon_init_one() returns another negative error
>> code instead.
>
>I'm not sure these changes are especially valuable, since we'll need to
>look at the dmesg log anyways to figure out what went wrong, but again I
>don't feel strongly.
>
>Fix up the subject issues and I'm happy to ack them.

As requested, here are the patchsets with the fixed subjects.
The subjects aswell as the subject prefixes are more precise now.
Hopefully that's ok.

Patch 1:
Makes the function typhoon_init_one() return a negative error code instead of 0.

Patch 2 [Optional]:
Makes the function typhoon_init_one() return the return value of the
corresponding failing function calls instead of a "fixed" negative error code.

With Regards,
Milan and Thomas