* [PATCH] iio: adc: imx25-gcq: Fix module autoload
@ 2017-01-02 12:45 Javier Martinez Canillas
2017-01-07 22:15 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Javier Martinez Canillas @ 2017-01-02 12:45 UTC (permalink / raw)
To: linux-kernel
Cc: Javier Martinez Canillas, Arnd Bergmann, linux-iio,
Hartmut Knaack, Markus Pargmann, Lars-Peter Clausen, Lee Jones,
Jonathan Cameron, Peter Meerwald-Stadler, Denis Carikli
If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.
Export the module alias information using the MODULE_DEVICE_TABLE() macro.
Before this patch:
$ modinfo drivers/iio/adc/fsl-imx25-gcq.ko | grep alias
$
After this patch:
$ modinfo drivers/iio/adc/fsl-imx25-gcq.ko | grep alias
alias: of:N*T*Cfsl,imx25-gcqC*
alias: of:N*T*Cfsl,imx25-gcq
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/iio/adc/fsl-imx25-gcq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/adc/fsl-imx25-gcq.c b/drivers/iio/adc/fsl-imx25-gcq.c
index 72b32c1ab257..ea264fa9e567 100644
--- a/drivers/iio/adc/fsl-imx25-gcq.c
+++ b/drivers/iio/adc/fsl-imx25-gcq.c
@@ -401,6 +401,7 @@ static const struct of_device_id mx25_gcq_ids[] = {
{ .compatible = "fsl,imx25-gcq", },
{ /* Sentinel */ }
};
+MODULE_DEVICE_TABLE(of, mx25_gcq_ids);
static struct platform_driver mx25_gcq_driver = {
.driver = {
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: adc: imx25-gcq: Fix module autoload
2017-01-02 12:45 [PATCH] iio: adc: imx25-gcq: Fix module autoload Javier Martinez Canillas
@ 2017-01-07 22:15 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2017-01-07 22:15 UTC (permalink / raw)
To: Javier Martinez Canillas, linux-kernel
Cc: Arnd Bergmann, linux-iio, Hartmut Knaack, Markus Pargmann,
Lars-Peter Clausen, Lee Jones, Peter Meerwald-Stadler,
Denis Carikli
On 02/01/17 12:45, Javier Martinez Canillas wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
>
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>
> Before this patch:
>
> $ modinfo drivers/iio/adc/fsl-imx25-gcq.ko | grep alias
> $
>
> After this patch:
>
> $ modinfo drivers/iio/adc/fsl-imx25-gcq.ko | grep alias
> alias: of:N*T*Cfsl,imx25-gcqC*
> alias: of:N*T*Cfsl,imx25-gcq
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Applied to the togreg branch of iio.git. Will push out as testing for
the autobuilders to play with it.
Thanks,
Jonathan
> ---
>
> drivers/iio/adc/fsl-imx25-gcq.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/adc/fsl-imx25-gcq.c b/drivers/iio/adc/fsl-imx25-gcq.c
> index 72b32c1ab257..ea264fa9e567 100644
> --- a/drivers/iio/adc/fsl-imx25-gcq.c
> +++ b/drivers/iio/adc/fsl-imx25-gcq.c
> @@ -401,6 +401,7 @@ static const struct of_device_id mx25_gcq_ids[] = {
> { .compatible = "fsl,imx25-gcq", },
> { /* Sentinel */ }
> };
> +MODULE_DEVICE_TABLE(of, mx25_gcq_ids);
>
> static struct platform_driver mx25_gcq_driver = {
> .driver = {
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-08 10:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-02 12:45 [PATCH] iio: adc: imx25-gcq: Fix module autoload Javier Martinez Canillas
2017-01-07 22:15 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).