From: Max Bires <jbires@google.com>
To: arnd@arndb.de
Cc: gregkh@linuxfoundation.org, josh@joshtriplett.org,
linux-kernel@vger.kernel.org, geert@linux-m68k.org,
Max Bires <jbires@google.com>
Subject: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on
Date: Tue, 3 Jan 2017 04:53:13 -0800 [thread overview]
Message-ID: <1483447993-45232-1-git-send-email-jbires@google.com> (raw)
In-Reply-To: <1481675545-84255-1-git-send-email-jbires@google.com>
Without a bool string present, using "# CONFIG_DEVPORT is not set" in
defconfig files would not actually unset devport. This ensured that
/dev/port was always on, but there are reasons a user may wish to disable
it (smaller kernel, attack surface reduction) if it's not being used. Adding
a message here in order to make this user visible.
Signed-off-by: Max Bires <jbires@google.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/char/Kconfig | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
index 7ad3127..e8fc493 100644
--- a/drivers/char/Kconfig
+++ b/drivers/char/Kconfig
@@ -589,10 +589,13 @@ config TELCLOCK
controlling the behavior of this hardware.
config DEVPORT
- bool
+ bool "/dev/port character device"
depends on !M68K
depends on ISA || PCI
default y
+ help
+ Say Y here if you want to support the /dev/port device. The
+ /dev/port device is similar to /dev/mem, but for I/O ports.
config DCC_TTY
tristate "DCC tty driver"
--
2.8.0.rc3.226.g39d4020
next prev parent reply other threads:[~2017-01-03 12:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-14 0:32 [PATCH] char: lack of bool string made CONFIG_DEVPORT always on Max
2016-12-14 0:58 ` Greg KH
2016-12-14 1:18 ` Max
2016-12-14 8:58 ` Geert Uytterhoeven
2016-12-14 9:11 ` Arnd Bergmann
2016-12-14 9:46 ` Josh Triplett
[not found] ` <CALVgH4S9b7JJj0wbR1N9Bd4tJB-CqJWfm_SPXv3z-m7U372ZmA@mail.gmail.com>
2017-01-02 20:49 ` Arnd Bergmann
2017-01-03 12:53 ` Max Bires [this message]
2017-01-03 13:52 ` Greg KH
2017-01-03 14:26 ` [PATCH] Without a bool string present, using "# CONFIG_DEVPORT is not set" in defconfig files would not actually unset devport. This esnured that /dev/port was always on, but there are reasons a user may wish to disable it (smaller kernel, attack surface reduction) if it's not being used. Adding a message here in order to make this user visible Max Bires
2017-01-03 14:34 ` Greg KH
2017-01-03 16:18 ` [PATCH] char: lack of bool string made CONFIG_DEVPORT always on Max Bires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1483447993-45232-1-git-send-email-jbires@google.com \
--to=jbires@google.com \
--cc=arnd@arndb.de \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).