From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S970343AbdAEJeG (ORCPT ); Thu, 5 Jan 2017 04:34:06 -0500 Received: from lucky1.263xmail.com ([211.157.147.135]:34040 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758200AbdAEJd2 (ORCPT ); Thu, 5 Jan 2017 04:33:28 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: shawn.lin@rock-chips.com X-FST-TO: kishon@ti.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: shawn.lin@rock-chips.com X-UNIQUE-TAG: <8c9528db280d41a5705c915d551df547> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 From: Shawn Lin To: Kishon Vijay Abraham I Cc: Rob Herring , devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, Heiko Stuebner , Douglas Anderson , linux-kernel@vger.kernel.org, Shawn Lin Subject: [PATCH 2/2] phy: rockchip-emmc: try to get drive impedance from DT Date: Thu, 5 Jan 2017 17:31:22 +0800 Message-Id: <1483608682-226716-2-git-send-email-shawn.lin@rock-chips.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1483608682-226716-1-git-send-email-shawn.lin@rock-chips.com> References: <1483608682-226716-1-git-send-email-shawn.lin@rock-chips.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Try to get drive impedance from DT and use it, otherwise use 50ohm by default in order not to break the existing boards as 50ohm works fine for them already. Signed-off-by: Shawn Lin --- drivers/phy/phy-rockchip-emmc.c | 29 ++++++++++++++++++++++++++++- 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/drivers/phy/phy-rockchip-emmc.c b/drivers/phy/phy-rockchip-emmc.c index f1b24f1..7fd4a3e 100644 --- a/drivers/phy/phy-rockchip-emmc.c +++ b/drivers/phy/phy-rockchip-emmc.c @@ -78,6 +78,7 @@ struct rockchip_emmc_phy { unsigned int reg_offset; + unsigned int drive_impedance; struct regmap *reg_base; struct clk *emmcclk; }; @@ -288,7 +289,7 @@ static int rockchip_emmc_phy_power_on(struct phy *phy) /* Drive impedance: 50 Ohm */ regmap_write(rk_phy->reg_base, rk_phy->reg_offset + GRF_EMMCPHY_CON6, - HIWORD_UPDATE(PHYCTRL_DR_50OHM, + HIWORD_UPDATE(rk_phy->drive_impedance, PHYCTRL_DR_MASK, PHYCTRL_DR_SHIFT)); @@ -346,6 +347,32 @@ static int rockchip_emmc_phy_probe(struct platform_device *pdev) return -EINVAL; } + rk_phy->drive_impedance = PHYCTRL_DR_50OHM; + if (!of_property_read_u32(dev->of_node, "drive_impedance", + &rk_phy->drive_impedance)) { + switch (rk_phy->drive_impedance) { + case 33: + rk_phy->drive_impedance = PHYCTRL_DR_33OHM; + break; + case 40: + rk_phy->drive_impedance = PHYCTRL_DR_40OHM; + break; + case 50: + rk_phy->drive_impedance = PHYCTRL_DR_50OHM; + break; + case 66: + rk_phy->drive_impedance = PHYCTRL_DR_66OHM; + break; + case 100: + rk_phy->drive_impedance = PHYCTRL_DR_100OHM; + break; + default: + dev_info(dev, "invalid drive impedance.\n"); + rk_phy->drive_impedance = PHYCTRL_DR_50OHM; + break; + } + } + rk_phy->reg_offset = reg_offset; rk_phy->reg_base = grf; -- 1.9.1