* [PATCH v3] soc: ti: wkup_m3_ipc: Drop wait from wkup_m3_rproc_boot_thread
@ 2017-01-05 22:00 Sarangdhar Joshi
2017-01-06 16:38 ` Tony Lindgren
2017-01-09 19:33 ` Tony Lindgren
0 siblings, 2 replies; 4+ messages in thread
From: Sarangdhar Joshi @ 2017-01-05 22:00 UTC (permalink / raw)
To: Ohad Ben-Cohen, Bjorn Andersson, Santosh Shilimkar, Tony Lindgren
Cc: Sarangdhar Joshi, linux-remoteproc, linux-kernel,
linux-arm-kernel, linux-arm-msm, Stephen Boyd, Trilok Soni,
Dave Gerlach
The function wkup_m3_rproc_boot_thread waits for asynchronous
firmware loading to parse the resource table before calling
rproc_boot(). However, as the resource table parsing has been
moved to rproc_boot(), there's no need to wait for the
asynchronous firmware loading completion. So, drop this.
CC: Dave Gerlach <d-gerlach@ti.com>
CC: Bjorn Andersson <bjorn.andersson@linaro.org>
Tested-by: Suman Anna <s-anna@ti.com>
Signed-off-by: Sarangdhar Joshi <spjoshi@codeaurora.org>
---
This patch seems to be doing an independent clean up now. Hence
removing it from the series.
Changes from v2:
* Updated the subject line as per Suman's comment
drivers/soc/ti/wkup_m3_ipc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c
index 8823cc8..8bfa44b 100644
--- a/drivers/soc/ti/wkup_m3_ipc.c
+++ b/drivers/soc/ti/wkup_m3_ipc.c
@@ -370,8 +370,6 @@ static void wkup_m3_rproc_boot_thread(struct wkup_m3_ipc *m3_ipc)
struct device *dev = m3_ipc->dev;
int ret;
- wait_for_completion(&m3_ipc->rproc->firmware_loading_complete);
-
init_completion(&m3_ipc->sync_complete);
ret = rproc_boot(m3_ipc->rproc);
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3] soc: ti: wkup_m3_ipc: Drop wait from wkup_m3_rproc_boot_thread
2017-01-05 22:00 [PATCH v3] soc: ti: wkup_m3_ipc: Drop wait from wkup_m3_rproc_boot_thread Sarangdhar Joshi
@ 2017-01-06 16:38 ` Tony Lindgren
2017-01-09 19:33 ` Tony Lindgren
1 sibling, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2017-01-06 16:38 UTC (permalink / raw)
To: Sarangdhar Joshi
Cc: Ohad Ben-Cohen, Bjorn Andersson, Santosh Shilimkar, Trilok Soni,
linux-arm-msm, Dave Gerlach, Stephen Boyd, linux-kernel,
linux-remoteproc, linux-arm-kernel
* Sarangdhar Joshi <spjoshi@codeaurora.org> [170105 14:01]:
> The function wkup_m3_rproc_boot_thread waits for asynchronous
> firmware loading to parse the resource table before calling
> rproc_boot(). However, as the resource table parsing has been
> moved to rproc_boot(), there's no need to wait for the
> asynchronous firmware loading completion. So, drop this.
Applying into omap-for-v4.11/drivers thanks.
Tony
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] soc: ti: wkup_m3_ipc: Drop wait from wkup_m3_rproc_boot_thread
2017-01-05 22:00 [PATCH v3] soc: ti: wkup_m3_ipc: Drop wait from wkup_m3_rproc_boot_thread Sarangdhar Joshi
2017-01-06 16:38 ` Tony Lindgren
@ 2017-01-09 19:33 ` Tony Lindgren
2017-01-09 19:39 ` Sarangdhar Joshi
1 sibling, 1 reply; 4+ messages in thread
From: Tony Lindgren @ 2017-01-09 19:33 UTC (permalink / raw)
To: Sarangdhar Joshi
Cc: Ohad Ben-Cohen, Bjorn Andersson, Santosh Shilimkar, Trilok Soni,
linux-arm-msm, Dave Gerlach, Stephen Boyd, linux-kernel,
linux-remoteproc, linux-arm-kernel
* Sarangdhar Joshi <spjoshi@codeaurora.org> [170105 14:01]:
> The function wkup_m3_rproc_boot_thread waits for asynchronous
> firmware loading to parse the resource table before calling
> rproc_boot(). However, as the resource table parsing has been
> moved to rproc_boot(), there's no need to wait for the
> asynchronous firmware loading completion. So, drop this.
>
> CC: Dave Gerlach <d-gerlach@ti.com>
> CC: Bjorn Andersson <bjorn.andersson@linaro.org>
> Tested-by: Suman Anna <s-anna@ti.com>
> Signed-off-by: Sarangdhar Joshi <spjoshi@codeaurora.org>
> ---
>
> This patch seems to be doing an independent clean up now. Hence
> removing it from the series.
>
> Changes from v2:
>
> * Updated the subject line as per Suman's comment
FYI, I already have v2 applied with subject:
"soc: ti: wkup_m3_ipc: Drop wait from wkup_m3_rproc_boot_thread"
Tony
> drivers/soc/ti/wkup_m3_ipc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c
> index 8823cc8..8bfa44b 100644
> --- a/drivers/soc/ti/wkup_m3_ipc.c
> +++ b/drivers/soc/ti/wkup_m3_ipc.c
> @@ -370,8 +370,6 @@ static void wkup_m3_rproc_boot_thread(struct wkup_m3_ipc *m3_ipc)
> struct device *dev = m3_ipc->dev;
> int ret;
>
> - wait_for_completion(&m3_ipc->rproc->firmware_loading_complete);
> -
> init_completion(&m3_ipc->sync_complete);
>
> ret = rproc_boot(m3_ipc->rproc);
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] soc: ti: wkup_m3_ipc: Drop wait from wkup_m3_rproc_boot_thread
2017-01-09 19:33 ` Tony Lindgren
@ 2017-01-09 19:39 ` Sarangdhar Joshi
0 siblings, 0 replies; 4+ messages in thread
From: Sarangdhar Joshi @ 2017-01-09 19:39 UTC (permalink / raw)
To: Tony Lindgren
Cc: Ohad Ben-Cohen, Bjorn Andersson, Santosh Shilimkar, Trilok Soni,
linux-arm-msm, Dave Gerlach, Stephen Boyd, linux-kernel,
linux-remoteproc, linux-arm-kernel
On 01/09/2017 11:33 AM, Tony Lindgren wrote:
> * Sarangdhar Joshi <spjoshi@codeaurora.org> [170105 14:01]:
>> The function wkup_m3_rproc_boot_thread waits for asynchronous
>> firmware loading to parse the resource table before calling
>> rproc_boot(). However, as the resource table parsing has been
>> moved to rproc_boot(), there's no need to wait for the
>> asynchronous firmware loading completion. So, drop this.
>>
>> CC: Dave Gerlach <d-gerlach@ti.com>
>> CC: Bjorn Andersson <bjorn.andersson@linaro.org>
>> Tested-by: Suman Anna <s-anna@ti.com>
>> Signed-off-by: Sarangdhar Joshi <spjoshi@codeaurora.org>
>> ---
>>
>> This patch seems to be doing an independent clean up now. Hence
>> removing it from the series.
>>
>> Changes from v2:
>>
>> * Updated the subject line as per Suman's comment
>
> FYI, I already have v2 applied with subject:
>
> "soc: ti: wkup_m3_ipc: Drop wait from wkup_m3_rproc_boot_thread"
Oh great. Thanks a lot Tony.
Regards,
Sarang
>
> Tony
>
>
>> drivers/soc/ti/wkup_m3_ipc.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c
>> index 8823cc8..8bfa44b 100644
>> --- a/drivers/soc/ti/wkup_m3_ipc.c
>> +++ b/drivers/soc/ti/wkup_m3_ipc.c
>> @@ -370,8 +370,6 @@ static void wkup_m3_rproc_boot_thread(struct wkup_m3_ipc *m3_ipc)
>> struct device *dev = m3_ipc->dev;
>> int ret;
>>
>> - wait_for_completion(&m3_ipc->rproc->firmware_loading_complete);
>> -
>> init_completion(&m3_ipc->sync_complete);
>>
>> ret = rproc_boot(m3_ipc->rproc);
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
>> a Linux Foundation Collaborative Project
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>>
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-01-09 19:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-05 22:00 [PATCH v3] soc: ti: wkup_m3_ipc: Drop wait from wkup_m3_rproc_boot_thread Sarangdhar Joshi
2017-01-06 16:38 ` Tony Lindgren
2017-01-09 19:33 ` Tony Lindgren
2017-01-09 19:39 ` Sarangdhar Joshi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).