From: David Lechner <david@lechnology.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Cc: David Lechner <david@lechnology.com>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 1/3] Input: pwm-beeper: suppress error message on probe defer
Date: Thu, 5 Jan 2017 20:43:52 -0600 [thread overview]
Message-ID: <1483670635-25060-2-git-send-email-david@lechnology.com> (raw)
In-Reply-To: <1483670635-25060-1-git-send-email-david@lechnology.com>
This suppress printing an error message when pwm_get/pwm_request returns
-EPROBE_DEFER. Otherwise you get a bunch of noise in the kernel log.
Signed-off-by: David Lechner <david@lechnology.com>
---
drivers/input/misc/pwm-beeper.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/input/misc/pwm-beeper.c b/drivers/input/misc/pwm-beeper.c
index 5f9655d..e76b710 100644
--- a/drivers/input/misc/pwm-beeper.c
+++ b/drivers/input/misc/pwm-beeper.c
@@ -109,9 +109,10 @@ static int pwm_beeper_probe(struct platform_device *pdev)
beeper->pwm = pwm_request(pwm_id, "pwm beeper");
}
- if (IS_ERR(beeper->pwm)) {
- error = PTR_ERR(beeper->pwm);
- dev_err(&pdev->dev, "Failed to request pwm device: %d\n", error);
+ error = PTR_ERR_OR_ZERO(beeper->pwm);
+ if (error) {
+ if (error != -EPROBE_DEFER)
+ dev_err(&pdev->dev, "Failed to request pwm device\n");
goto err_free;
}
--
2.7.4
next prev parent reply other threads:[~2017-01-06 2:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-06 2:43 [PATCH 0/3] Input: add optional enable gpio to pwm-beeper David Lechner
2017-01-06 2:43 ` David Lechner [this message]
2017-01-06 2:43 ` [PATCH 2/3] dt-bindings: Input: Add enable-gpios " David Lechner
2017-01-06 2:43 ` [PATCH 3/3] Input: pwm-beeper: add optional enable gpio David Lechner
2017-01-06 17:28 ` Andy Shevchenko
2017-01-06 17:45 ` David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1483670635-25060-2-git-send-email-david@lechnology.com \
--to=david@lechnology.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).