* [PATCH v2] arm64: dts: rockchip: add "rockchip,grf" property for RK3399 PMUCRU/CRU
@ 2017-01-09 7:02 Xing Zheng
2017-01-09 18:52 ` Doug Anderson
0 siblings, 1 reply; 3+ messages in thread
From: Xing Zheng @ 2017-01-09 7:02 UTC (permalink / raw)
To: heiko
Cc: dianders, linux-rockchip, Xing Zheng, Rob Herring, Mark Rutland,
Catalin Marinas, Will Deacon, Douglas Anderson, Caesar Wang,
Brian Norris, Shawn Lin, Jianqun Xu, Elaine Zhang, David Wu,
William wu, devicetree, linux-arm-kernel, linux-kernel
The structure rockchip_clk_provider needs to refer the GRF regmap
in somewhere, if the CRU node has not "rockchip,grf" property,
calling syscon_regmap_lookup_by_phandle will return an invalid GRF
regmap, and the MUXGRF type clock will be not supported.
Therefore, we need to add them.
Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
---
Changes in v2:
- referring pmugrf for PMUGRU
- fix the typo "invaild" in COMMIT message
arch/arm64/boot/dts/rockchip/rk3399.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
index 92b731f..a40e6d0 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
@@ -1090,6 +1090,7 @@
pmucru: pmu-clock-controller@ff750000 {
compatible = "rockchip,rk3399-pmucru";
reg = <0x0 0xff750000 0x0 0x1000>;
+ rockchip,grf = <&pmugrf>;
#clock-cells = <1>;
#reset-cells = <1>;
assigned-clocks = <&pmucru PLL_PPLL>;
@@ -1099,6 +1100,7 @@
cru: clock-controller@ff760000 {
compatible = "rockchip,rk3399-cru";
reg = <0x0 0xff760000 0x0 0x1000>;
+ rockchip,grf = <&grf>;
#clock-cells = <1>;
#reset-cells = <1>;
assigned-clocks =
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] arm64: dts: rockchip: add "rockchip,grf" property for RK3399 PMUCRU/CRU
2017-01-09 7:02 [PATCH v2] arm64: dts: rockchip: add "rockchip,grf" property for RK3399 PMUCRU/CRU Xing Zheng
@ 2017-01-09 18:52 ` Doug Anderson
2017-01-10 0:57 ` Xing Zheng
0 siblings, 1 reply; 3+ messages in thread
From: Doug Anderson @ 2017-01-09 18:52 UTC (permalink / raw)
To: Xing Zheng
Cc: Heiko Stübner, open list:ARM/Rockchip SoC...,
Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon,
Caesar Wang, Brian Norris, Shawn Lin, Jianqun Xu, Elaine Zhang,
David Wu, William wu, devicetree, linux-arm-kernel, linux-kernel
Hi,
On Sun, Jan 8, 2017 at 11:02 PM, Xing Zheng <zhengxing@rock-chips.com> wrote:
> The structure rockchip_clk_provider needs to refer the GRF regmap
> in somewhere, if the CRU node has not "rockchip,grf" property,
> calling syscon_regmap_lookup_by_phandle will return an invalid GRF
> regmap, and the MUXGRF type clock will be not supported.
>
> Therefore, we need to add them.
>
> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
> ---
>
> Changes in v2:
> - referring pmugrf for PMUGRU
> - fix the typo "invaild" in COMMIT message
>
> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
This looks sane to me, but before you land it you need to first send
up a (separate) patch that adjusts:
Documentation/devicetree/bindings/clock/rockchip,rk3399-cru.txt
...it would also be sorta nice if you included an a patch in your
series that actually uses this new functionality.
-Doug
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] arm64: dts: rockchip: add "rockchip,grf" property for RK3399 PMUCRU/CRU
2017-01-09 18:52 ` Doug Anderson
@ 2017-01-10 0:57 ` Xing Zheng
0 siblings, 0 replies; 3+ messages in thread
From: Xing Zheng @ 2017-01-10 0:57 UTC (permalink / raw)
To: Doug Anderson
Cc: Heiko Stübner, open list:ARM/Rockchip SoC...,
Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon,
Caesar Wang, Brian Norris, Shawn Lin, Jianqun Xu, Elaine Zhang,
David Wu, William wu, devicetree, linux-arm-kernel, linux-kernel
Hi Doug,
在 2017年01月10日 02:52, Doug Anderson 写道:
> This looks sane to me, but before you land it you need to first send
> up a (separate) patch that adjusts:
>
> Documentation/devicetree/bindings/clock/rockchip,rk3399-cru.txt
>
> ...it would also be sorta nice if you included an a patch in your
> series that actually uses this new functionality.
Sorry to miss it. Thanks for your reminding me.
--
- Xing Zheng
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-10 0:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-09 7:02 [PATCH v2] arm64: dts: rockchip: add "rockchip,grf" property for RK3399 PMUCRU/CRU Xing Zheng
2017-01-09 18:52 ` Doug Anderson
2017-01-10 0:57 ` Xing Zheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).