From: Eric Auger <eric.auger@redhat.com>
To: eric.auger@redhat.com, eric.auger.pro@gmail.com,
christoffer.dall@linaro.org, marc.zyngier@arm.com,
robin.murphy@arm.com, alex.williamson@redhat.com,
will.deacon@arm.com, joro@8bytes.org, tglx@linutronix.de,
jason@lakedaemon.net, linux-arm-kernel@lists.infradead.org
Cc: kvm@vger.kernel.org, drjones@redhat.com,
linux-kernel@vger.kernel.org, pranav.sawargaonkar@gmail.com,
iommu@lists.linux-foundation.org, punit.agrawal@arm.com,
diana.craciun@nxp.com, gpkulkarni@gmail.com,
shankerd@codeaurora.org, bharat.bhushan@nxp.com,
geethasowjanya.akula@gmail.com
Subject: [PATCH v7 17/19] vfio/type1: Allow transparent MSI IOVA allocation
Date: Mon, 9 Jan 2017 13:46:08 +0000 [thread overview]
Message-ID: <1483969570-3154-18-git-send-email-eric.auger@redhat.com> (raw)
In-Reply-To: <1483969570-3154-1-git-send-email-eric.auger@redhat.com>
When attaching a group to the container, check the group's
reserved regions and test whether the IOMMU translates MSI
transactions. If yes, we initialize an IOVA allocator through
the iommu_get_msi_cookie API. This will allow the MSI IOVAs
to be transparently allocated on MSI controller's compose().
Signed-off-by: Eric Auger <eric.auger@redhat.com>
---
v3 -> v4:
- test region's type: IOMMU_RESV_MSI
- restructure the code to prepare for safety assessment
- reword title
---
drivers/vfio/vfio_iommu_type1.c | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c
index 9266271..5651faf 100644
--- a/drivers/vfio/vfio_iommu_type1.c
+++ b/drivers/vfio/vfio_iommu_type1.c
@@ -39,6 +39,7 @@
#include <linux/pid_namespace.h>
#include <linux/mdev.h>
#include <linux/notifier.h>
+#include <linux/dma-iommu.h>
#define DRIVER_VERSION "0.2"
#define DRIVER_AUTHOR "Alex Williamson <alex.williamson@redhat.com>"
@@ -1181,6 +1182,28 @@ static struct vfio_group *find_iommu_group(struct vfio_domain *domain,
return NULL;
}
+static bool vfio_iommu_has_resv_msi(struct iommu_group *group,
+ phys_addr_t *base)
+{
+ struct list_head group_resv_regions;
+ struct iommu_resv_region *region, *next;
+ bool ret = false;
+
+ INIT_LIST_HEAD(&group_resv_regions);
+ iommu_get_group_resv_regions(group, &group_resv_regions);
+ list_for_each_entry(region, &group_resv_regions, list) {
+ if (region->type & IOMMU_RESV_MSI) {
+ *base = region->start;
+ ret = true;
+ goto out;
+ }
+ }
+out:
+ list_for_each_entry_safe(region, next, &group_resv_regions, list)
+ kfree(region);
+ return ret;
+}
+
static int vfio_iommu_type1_attach_group(void *iommu_data,
struct iommu_group *iommu_group)
{
@@ -1189,6 +1212,8 @@ static int vfio_iommu_type1_attach_group(void *iommu_data,
struct vfio_domain *domain, *d;
struct bus_type *bus = NULL, *mdev_bus;
int ret;
+ bool resv_msi;
+ phys_addr_t resv_msi_base;
mutex_lock(&iommu->lock);
@@ -1258,6 +1283,8 @@ static int vfio_iommu_type1_attach_group(void *iommu_data,
if (ret)
goto out_domain;
+ resv_msi = vfio_iommu_has_resv_msi(iommu_group, &resv_msi_base);
+
INIT_LIST_HEAD(&domain->group_list);
list_add(&group->next, &domain->group_list);
@@ -1304,6 +1331,9 @@ static int vfio_iommu_type1_attach_group(void *iommu_data,
if (ret)
goto out_detach;
+ if (resv_msi && iommu_get_msi_cookie(domain->domain, resv_msi_base))
+ goto out_detach;
+
list_add(&domain->next, &iommu->domain_list);
mutex_unlock(&iommu->lock);
--
1.9.1
next prev parent reply other threads:[~2017-01-09 13:47 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 13:45 [PATCH v7 00/19] KVM PCIe/MSI passthrough on ARM/ARM64 and IOVA reserved regions Eric Auger
2017-01-09 13:45 ` [PATCH v7 01/19] iommu/dma: Implement PCI allocation optimisation Eric Auger
2017-01-10 15:41 ` Robin Murphy
2017-01-09 13:45 ` [PATCH v7 02/19] iommu/dma: Allow MSI-only cookies Eric Auger
2017-01-09 13:45 ` [PATCH v7 03/19] iommu: Rename iommu_dm_regions into iommu_resv_regions Eric Auger
2017-01-09 13:45 ` [PATCH v7 04/19] iommu: Add a new type field in iommu_resv_region Eric Auger
2017-01-09 13:45 ` [PATCH v7 05/19] iommu: iommu_alloc_resv_region Eric Auger
2017-01-09 13:45 ` [PATCH v7 06/19] iommu: Only map direct mapped regions Eric Auger
2017-01-09 13:45 ` [PATCH v7 07/19] iommu: iommu_get_group_resv_regions Eric Auger
2017-01-09 13:45 ` [PATCH v7 08/19] iommu: Implement reserved_regions iommu-group sysfs file Eric Auger
2017-01-10 16:20 ` Auger Eric
2017-01-10 17:14 ` Joerg Roedel
2017-01-10 21:21 ` Auger Eric
2017-01-09 13:46 ` [PATCH v7 09/19] iommu/vt-d: Implement reserved region get/put callbacks Eric Auger
2017-01-09 13:46 ` [PATCH v7 10/19] iommu/amd: Declare MSI and HT regions as reserved IOVA regions Eric Auger
2017-01-09 13:46 ` [PATCH v7 11/19] iommu/arm-smmu: Implement reserved region get/put callbacks Eric Auger
2017-01-10 14:16 ` Will Deacon
2017-01-09 13:46 ` [PATCH v7 12/19] iommu/arm-smmu-v3: " Eric Auger
2017-01-10 14:17 ` Will Deacon
2017-01-09 13:46 ` [PATCH v7 13/19] irqdomain: Add irq domain MSI and MSI_REMAP flags Eric Auger
2017-01-10 11:50 ` Marc Zyngier
2017-01-09 13:46 ` [PATCH v7 14/19] genirq/msi: Set IRQ_DOMAIN_FLAG_MSI on MSI domain creation Eric Auger
2017-01-09 13:46 ` [PATCH v7 15/19] irqdomain: irq_domain_check_msi_remap Eric Auger
2017-01-10 11:54 ` Marc Zyngier
2017-01-09 13:46 ` [PATCH v7 16/19] irqchip/gicv3-its: Sets IRQ_DOMAIN_FLAG_MSI_REMAP Eric Auger
2017-01-10 11:57 ` Marc Zyngier
2017-01-09 13:46 ` Eric Auger [this message]
2017-01-09 13:46 ` [PATCH v7 18/19] vfio/type1: Check MSI remapping at irq domain level Eric Auger
2017-01-09 13:46 ` [PATCH v7 19/19] iommu/arm-smmu: Do not advertise IOMMU_CAP_INTR_REMAP anymore Eric Auger
2017-01-10 14:17 ` Will Deacon
2017-01-10 14:09 ` [PATCH v7 00/19] KVM PCIe/MSI passthrough on ARM/ARM64 and IOVA reserved regions Joerg Roedel
2017-01-10 14:15 ` Will Deacon
2017-01-10 15:58 ` Auger Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1483969570-3154-18-git-send-email-eric.auger@redhat.com \
--to=eric.auger@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=bharat.bhushan@nxp.com \
--cc=christoffer.dall@linaro.org \
--cc=diana.craciun@nxp.com \
--cc=drjones@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=geethasowjanya.akula@gmail.com \
--cc=gpkulkarni@gmail.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jason@lakedaemon.net \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=pranav.sawargaonkar@gmail.com \
--cc=punit.agrawal@arm.com \
--cc=robin.murphy@arm.com \
--cc=shankerd@codeaurora.org \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).