From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Igor Guryanov" <Igor.Guryanov@synopsys.com>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>
Subject: Re: [PATCH 1/2] arc: rename xCCM sections so they are not merged in global .data/.text
Date: Mon, 9 Jan 2017 15:08:06 +0000 [thread overview]
Message-ID: <1483974486.2890.36.camel@synopsys.com> (raw)
In-Reply-To: <6d3a6876-402f-c237-f9a2-88aad3179ead@synopsys.com>
Hi Vineet,
On Thu, 2016-12-22 at 16:25 -0800, Vineet Gupta wrote:
> On 12/22/2016 06:09 AM, Alexey Brodkin wrote:
> > diff --git a/arch/arc/include/asm/linkage.h b/arch/arc/include/asm/linkage.h
> > index b29f1a9fd6f7..3a5f13d65ee1 100644
> > --- a/arch/arc/include/asm/linkage.h
> > +++ b/arch/arc/include/asm/linkage.h
> > @@ -28,7 +28,7 @@
> > /* annotation for data we want in DCCM - if enabled in .config */
> > .macro ARCFP_CODE
> > #ifdef CONFIG_ARC_HAS_ICCM
> > - .section .text.arcfp, "ax",@progbits
> > + .section .text..arcfp, "ax",@progbits
>
> Why not turn this around and call it arcfp.text and arcfp.data etc - just like
> done for other special sections such as sched, cpuidle, lock... Just so we are
> consistent with normal kernel convention !
Right that looks much better!
Will do so in v2.
-Alexey
next prev parent reply other threads:[~2017-01-09 15:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-22 14:09 [PATCH 0/2] Minor fixes for CCMs Alexey Brodkin
2016-12-22 14:09 ` [PATCH 1/2] arc: rename xCCM sections so they are not merged in global .data/.text Alexey Brodkin
2016-12-23 0:25 ` Vineet Gupta
2017-01-09 15:08 ` Alexey Brodkin [this message]
2016-12-22 14:09 ` [PATCH 2/2] arc: Fix xCCM size check Alexey Brodkin
2016-12-23 0:34 ` Vineet Gupta
2017-01-09 15:12 ` Alexey Brodkin
2016-12-23 0:26 ` [PATCH 0/2] Minor fixes for CCMs Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1483974486.2890.36.camel@synopsys.com \
--to=alexey.brodkin@synopsys.com \
--cc=Igor.Guryanov@synopsys.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).