From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941043AbdAIUor (ORCPT ); Mon, 9 Jan 2017 15:44:47 -0500 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:49430 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932069AbdAIUom (ORCPT ); Mon, 9 Jan 2017 15:44:42 -0500 Date: Mon, 9 Jan 2017 15:44:20 -0500 From: Josef Bacik Subject: Re: [patch] nbd: blk_mq_init_queue returns an error code on failure, not NULL To: Jens Axboe CC: Omar Sandoval , Jeff Moyer , Markus Pargmann , , , Message-ID: <1483994660.22708.3@smtp.office365.com> In-Reply-To: References: <20170109202707.GA29762@vader.DHCP.thefacebook.com> X-Mailer: geary/0.11.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed X-Originating-IP: [2620:10d:c091:180::1:9095] X-ClientProxiedBy: BN3PR03CA0094.namprd03.prod.outlook.com (10.174.66.12) To BN6PR15MB1315.namprd15.prod.outlook.com (10.172.206.141) X-MS-Office365-Filtering-Correlation-Id: ec7fc36c-d405-42a6-2b38-08d438d04cc3 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BN6PR15MB1315; X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1315;3:ZxgwtlDlqzTMINy4YnvE/0DJN7curgTZEVDRNv/tz3viZiMy6PUOSMOBfX7G74M3htgxqtmoIRxOcQLo0x5v07tLt1hh1F6PTnhcv3gpxrY+xKVN6uuD78rn/6W8NLZwZkp6kmtRl2awZsE+Jh1xxOyeLJxpQ06mdkCSF40W87XbN8mAdXQzcJijsBlCsFqkWKuB3imrkdjsj2/RSe2NCuf7VvDSy1JI7aDLUur+aqXosMl3mN0YkSBiejAzHqQGL3fPaHqJRUcUI5BYBu+VPg==;25:4Ui6Kt9xEGnoDwqYkXrytaqe8+dwPDay9wnPUcipcL4hjEpDX3C95LlcaRvQwqwBoGHczKk6/C45CHPGFRKG+xTcmvuVkTxgwV1gp3+aG+/lvUQhbEg4jBQgwsjhkZCdlhXsUsx3RN8LW1F41wjos5+7Z0bbSCv2G3ruqeYC70scWIgTIcqoYILHwuyXEmcukaw68Ap7nn++P0H61PLpxEow2nW5qIxwAwhUE8N1UK3Bp1Hj02DuzGlgo27UgR9qk3BX/gIcHP0WrVVhcx5itrpxB8XfJLUQLavcULN/k+7QthBYJPhOZu8K/333/zt5nj7iDPGBSW7HtP52fzJp2ZoqmfxcYTZGYon9rpx3zAWacZsL+shgoyZrM4xZJ0eJehAeq49i15B33UhMZMdsEoGXUrQOSsHP1pfLMYZeNJER4rb8YnQgaajvlHBmde/3 X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1315;31:84ux+bgrZviY+FSKKlV1MUZ669xW2zYKg2pSubNv9QkvJe4mo8gpFW2hgm63odTg1QUj6VaszS/XcqI2ecU2m+APkDOK7sSOZRwT2VwgTUSAAHYq0PApkthaOi+oqjtJI5AWc/Dq5Zj/X4NXDvFjwFnnUHf3OxbHuebE41Np7TP2y2RWY5nx4fAyqur7veFAPlfvbJRtf4/Pps/a9R+DeohxRKJvn9UG2Ts9mfu1WOoUgJGKSpqvZfe1d8h71FRCkT+0r0Vsj8fh5ZkWIfh0HMzsGmIP3WBSAHL/QKh/Clc=;20:kV75Edd5aFHEvATfAsFWm1WhTCDUzv2g98C/pKIzL5CFZELymF/RySBJlc0C428N59u1AcG3Ur+4vuAYPw1j0aQtbuLVlCpAJQbwKjUqnAgO+bz/JAtL/jeZSfMLimjVaXZoyzMtqXzh10Ue/VO+MCo8Tj+j5fbOfdHxlhtIf2Y6nB6aOxSLtyHyP8pfux95MFuxH58n9tsi0pCjThOBy0vouNmIq5x8b6g8n2nAsDki+mMeT5EeoRlNs05jQ7HfZ+nyg4nw4AqBHpJQYDcAvdknwUnUqhIKKj4zboitCKqJCFlZsc3DR2VPPbK81oiQbl0XmtAOkGkX8IBbb/UffHk/Lvk5kiihAwo6uk3hMBC3T8pU7CDJD8pemrJEVgL8UKX5X8Qosq7hi/psN9k8eo0QhEHQxI7CkTEIFAC/wJ4OvJUg/PMoqcD2ud86PA1BEdX+5KUhQh7hw/zUu8JNs2nqWCIYaGyNVvzDDoX8WhxnASt8e2aoYd4qpNisIyzH X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(67672495146484); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6041248)(20161123555025)(20161123560025)(20161123564025)(20161123562025)(6072148);SRVR:BN6PR15MB1315;BCL:0;PCL:0;RULEID:;SRVR:BN6PR15MB1315; X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1315;4:+TKirgiWKxVknYtcv6I8p8KX3K2IDsBQswX2BBahARyxUpHSJnf1qwB4lQSuVyzBBV7ClU0yzmbsCsE+oSiY4jkd+y3EY/5I2TQCL9RKvaO64xfc5pUYUDZLGkveKORORNruxtYAoa3/URxI7lH2a3Ox2h2mlnZgTyAdOYTQNqxo8/tpTEEw+pd5+lrp1/4HFDxiu6mqj5Ym9xFTzkZQrlr4Ql80AjqOTporJljDD+yaTL5eXhcB/GdfXG/kBXqLkgBk6TnJmp0lbSaesPYco1KLUjhsUtKM3epbIdJ16utLyCfBGpiNrBoDbvVTcZw/+gT9myy4miZFkBx4fmNL4u/Igi+uIk51TZlkxkDjuDcAAHf8Ff3lV24kRuZdb3LGrTnlfjCNPY08vFQdqLeOTRVltHTFN4TwJIKFBbwZ/B6g5aO6OUFrKLxVFFJxTz2JUbhCmJfR61odpkWfPhNtEwL9XVnj2SD6r1KQ8cjt39xZsJVZOfV4WVhg4tkrDAenSG9rTjnEIyLmTUd8GZ5pGNFZZ/V+CAAHLpgdDvgRMuOYhimt5YHaxgnM+NxZ/k9PBItvCNns2nrrdK6b8wnUAM3gPd9Lape8dQsRsia/Kno= X-Forefront-PRVS: 0182DBBB05 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6069001)(7916002)(39450400003)(199003)(189002)(377454003)(24454002)(88526003)(7736002)(54906002)(68736007)(305945005)(38730400001)(97736004)(92566002)(47776003)(81166006)(105586002)(189998001)(86362001)(76176999)(6666003)(50986999)(50226002)(5660300001)(2950100002)(6512007)(81156014)(110136003)(229853002)(42186005)(8676002)(2906002)(4326007)(6506006)(6916009)(9686003)(23676002)(25786008)(101416001)(6116002)(106356001)(50466002)(6486002);DIR:OUT;SFP:1102;SCL:1;SRVR:BN6PR15MB1315;H:localhost.localdomain;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjE1TUIxMzE1OzIzOnVrLzk5eXl0NnhmQXR2WlBkWEFwUlhjVzlI?= =?utf-8?B?NG1BSjAwZ1FOdTBlYzdiYkdHVXR6NXRsQ0lNK3pMUWpHTWZsTEdUZ2NYK0JX?= =?utf-8?B?b1o4RVFxbTloV2VvMkZkVUdhRlRvVktEMWJ6TUs5NHpEMklWaEVoVVpPWStV?= =?utf-8?B?SHNKc0ZLWFVXMDQ3YW5PUHZKaEkxZzZRS2UweG56b0tIMzJtZ2c4SWNPNWVE?= =?utf-8?B?RXFNbDJYNDRtcFNibDF2N2tFdEZGYU8zQlVSZjludDhGMXdJTkZ0NXhJYkRw?= =?utf-8?B?UGxDWUxCT2Z4YU5zUjh0RWZoQ0Y5bG4yUW9JU3lnRHFuUmo1Z2xpT3VRODB2?= =?utf-8?B?cnp3VGJNam5NZ2ZPQ004amNjTG5NSG9lUjlXcEZwcGQ3enFBYWlQQXFSWTQy?= =?utf-8?B?R2FzVVFFMm16bTJHNUhsYnF5TVNrdWFaanU1eFc2a2JPYnZPUmltK3FNSU1E?= =?utf-8?B?bXVUQ1VnV0hFandyOG9iYXo3TzlpbXNDWjBKclh5S0ZXSE1WakhBc1lTKzUw?= =?utf-8?B?V1kxRmRjNkxpYk01Rk9XNncvRDk3cG1uNEFhSFRkd1RBai80dVV1OGlZQ2ZH?= =?utf-8?B?U05QdjRFVHZkZTN1dnRWczBuOVFnSTRvejBqbUNUWVJrSEhzTEFZY2xSbzhL?= =?utf-8?B?NFlUV2Exem5Ybm90NmNRdC9PbG9RMVdQRHdEOTRhUmZ2UjF5MFZkZTI2QkF5?= =?utf-8?B?bWRwNzJJcnZEQTFSK3I5SlFxdVFlSlZ4VTlMNHpyNkVNVlZHQ0NyZURtWHkv?= =?utf-8?B?Uy9qMnhMOTJUMnV3WHczQjFqTGc3QjZTekorNUlWSkZsWmNBVGUzQ0VieUtP?= =?utf-8?B?MmFKQmV5bDM0VG0rK3kwME5KdWpaaVQ0QW92MnVUZDZFL01zcjZhalVJaytC?= =?utf-8?B?Z2FpK05SNmJ3V2lOMTRzRm5ZRmZFOVdmV3lHeTRnWnVTdHBnTVhmM0hYaWg4?= =?utf-8?B?MmF5RG9CV0tFeVZnczJZT1hUdXJFRUtyeGcvZkFVMG5Sb2pJeG0waHUvdjNn?= =?utf-8?B?TWxCdkhTc3crZTJaNHN3WW1iM0o4dWx5YUdCeFhUTzdjc2hPVU9tNkhkRnRK?= =?utf-8?B?OEh6YzRTc3dDL0hTRWdRN0o2M3F4cjAxNU9aWGRiUHExZFhRbHA4Skp3SnVt?= =?utf-8?B?RXFQVG4vY1hIREpENEZ3QWd6WUZzWWdqSHlSWjhEWEVtSC95Q2JzaHRJeVRE?= =?utf-8?B?WEhGd2Nwa2thU1N2SGJKTEtGQXo1RjZRK2xkdDFOL0tSRWJIQUZoUnIyZTlu?= =?utf-8?B?WmE5ZEoxbVlnM1hrbWVxamFmZTFQVE9rZlJ4WWRuTE1pSWFJZXNQQUR5VFpu?= =?utf-8?B?enRPWVVpTXNhSkZQczh2V1RKY08xaFREYXdDWi9hMlJIOVk5RkorUmJaRndK?= =?utf-8?B?U3U0OHFVb0pLaW81aGpROUFEcURjUmFobHpyTE5tSnN1a1luSHR1TFBSRVRp?= =?utf-8?B?WW9MUFl1VHFGZ1YxQmZWN1Y1R2dRbVdXVzY2SXQra21ZWEhUQjVBSFRoOXFn?= =?utf-8?Q?eoZ1SB9lm5JnjXGezB9bmT7Dk=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1315;6:nCtpBRW5aXo8btO8lptxrITOOhNSq6yWOcO3XLZxwSuUwNVEx627y9Z9Vl8b5+1jcYi5RJdcbHJ+ckHIdLZIYU4nVg6dJWk9wnE8pROh9Id6xr9E1fpUQGojPdymxOYL/vLO/oKEQdms+G+1Q68naGzupJch4d2KUxWD1ElePl86zT7uE0e6qKZqO0j1i/eh7NVMsn9iBGmly9IWk5nJurSs0G2enEVH0vjzTBVIl41K0PSuTmOZrFMGWg3jxUkew0q4TLmidQrAaVkW99E6nHMQIAyNfJEOpw6GsrPq1eswWOG+Ch2DDpwaUQevhtI0H8GbI6muTUi7VggtfvvLoJ9jJeX1DiVME6691UxD7b6b2mzwZmJE9w8hXouC9oIY8JGoGCoy/U7IxGqP6XXRjtrzMUt1zRYBkYsT1RCcEz4=;5:RcmcwxcLBM3I1c85ED1TPNU1yAdV8ItcTBcr1uaAe/TFU185pryUh2FtAeTBbt3gLorH7WlDVtAV82rfgidlKb1rcfl0cNWi3zLxz+OddiEFGSHOUxxeQ5H6eeDK6Kh62v6YRC4KyEOjn4uwhkTx/A==;24:+nN8+6qq36CiBTpuxEeYoG/pXSe6HNVu64ymqgaPOKcCc/nga/473k9/tIoWRBBhD/YsteR55greJyhSSOUAAgddb8Bgatb2ZPO1cn7tecg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1315;7:4097zrn3AQycqvPkR5gqtGqzrM5KxGjb3RJnbnrQq+myizi8VViJ7Nl5aLOd0RU6WU93hppvs4H5hOV9TGFHEkD+q7UiXKt38NGf1VL2sdntEQY5r+3W326B61apVxGOY/0ztKgtQkd6LoPbS/xPbsl4atFDyo7VoHKqDzsro1MJ2IPkVmROzHjgQELuDv7BBX6+TaVZPdtqTcshzYpEFZpq4BRUM6HzjatMn76mNsJSuHvqd1r+dgIgX88Io5ZSG+Tp8sQpXrI3VsfNBE72ffwrVpzODBS5vMOeVkWhhb8X4c82lVj0kt93Rb9kfH0Suvzd7MYjzjDE9XPRKg/nFak9M6v0E0WUkOt7il9vuYTZpx8Kl5Rma5wakV20hELYGAokYLKfkpYKSdB2piz1KaCvygqPAjXRp8STxyLbDNM2TEE9mo8EqrSDa9mt5X7/L/jhRd4cOsuiDiG1jP/6oQ==;20:6AW/CN7Ig4sxAGtIkmM3u83u9YZCqOXYZZoX3iY+unHTUuIohoFDW1Q3qF2NZJ/8eBG/A7XBNtEBxlaJOsijz8bnSnuy3DT9mjodg5ym5CqR4iQXJVVLEJM+1g0IJkYrtR7XYcc5dR5v8GqPO//7CfOV5Y8JewDqsgKpqsG2/hc= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2017 20:44:24.3512 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR15MB1315 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-01-09_13:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 9, 2017 at 3:41 PM, Jens Axboe wrote: > On 01/09/2017 01:27 PM, Omar Sandoval wrote: >> On Mon, Jan 09, 2017 at 03:20:31PM -0500, Jeff Moyer wrote: >>> Additionally, don't assign directly to disk->queue, otherwise >>> blk_put_queue (called via put_disk) will choke (panic) on the errno >>> stored there. >>> >>> Bug found by code inspection after Omar found a similar issue in >>> virtio_blk. Compile-tested only. >>> >>> Signed-off-by: Jeff Moyer >> >> Reviewed-by: Omar Sandoval >> >> Compile-reviewed only :) Josef can probably test it if he cares >> enough, >> but it looks right. > > Looks good to me, too. Josef, you want me to queue this up directly? Y'all are hilarious. Reviewed-by: Josef Bacik Thanks, Josef