From: Logan Gunthorpe <logang@deltatee.com>
To: Xiangliang Yu <Xiangliang.Yu@amd.com>,
Jon Mason <jdmason@kudzu.us>, Dave Jiang <dave.jiang@intel.com>,
Allen Hubbe <Allen.Hubbe@emc.com>, Joe Perches <joe@perches.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-ntb@googlegroups.com, linux-kernel@vger.kernel.org,
Logan Gunthorpe <logang@deltatee.com>
Subject: [PATCH 0/2] Style fixes: open code obfuscating macros
Date: Tue, 10 Jan 2017 17:32:09 -0700 [thread overview]
Message-ID: <1484094731-15965-1-git-send-email-logang@deltatee.com> (raw)
Hi,
I had copied some poor code style from the NTB drivers into an unrelated
driver. Upon review of my new code, I learned it was not a good idea
to sweep dirty things under the rug^W macro. See [1], where Gregg k-h
suggested I fix the problem at the source.
Thus, please merge the following two patches to improve the style of
the NTB drivers.
Thanks,
Logan
[1] http://www.spinics.net/lists/linux-pci/msg56904.html
Logan Gunthorpe (2):
ntb_hw_amd: Style fixes: open code macros that just obfuscate code
ntb_hw_intel: Style fixes: open code macros that just obfuscate code
drivers/ntb/hw/amd/ntb_hw_amd.c | 59 ++++++++-------
drivers/ntb/hw/amd/ntb_hw_amd.h | 3 -
drivers/ntb/hw/intel/ntb_hw_intel.c | 145 ++++++++++++++++++------------------
drivers/ntb/hw/intel/ntb_hw_intel.h | 3 -
4 files changed, 104 insertions(+), 106 deletions(-)
--
2.1.4
next reply other threads:[~2017-01-11 0:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-11 0:32 Logan Gunthorpe [this message]
2017-01-11 0:32 ` [PATCH 1/2] ntb_hw_amd: Style fixes: open code macros that just obfuscate code Logan Gunthorpe
2017-01-11 0:32 ` [PATCH 2/2] ntb_hw_intel: " Logan Gunthorpe
2017-01-11 0:34 ` [PATCH 0/2] Style fixes: open code obfuscating macros Logan Gunthorpe
-- strict thread matches above, loose matches on Subject: below --
2017-01-03 1:30 Logan Gunthorpe
2017-01-10 21:55 ` Jon Mason
2017-01-10 21:59 ` Jon Mason
2017-01-10 23:06 ` Joe Perches
2017-01-10 23:34 ` Logan Gunthorpe
2017-01-11 6:50 ` Greg Kroah-Hartman
2017-01-11 17:48 ` Logan Gunthorpe
2017-01-15 22:38 ` jmrodriguezhw88
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484094731-15965-1-git-send-email-logang@deltatee.com \
--to=logang@deltatee.com \
--cc=Allen.Hubbe@emc.com \
--cc=Xiangliang.Yu@amd.com \
--cc=dave.jiang@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jdmason@kudzu.us \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).