From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750917AbdALVQ7 (ORCPT ); Thu, 12 Jan 2017 16:16:59 -0500 Received: from mail-by2nam01on0042.outbound.protection.outlook.com ([104.47.34.42]:14016 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750791AbdALVQt (ORCPT ); Thu, 12 Jan 2017 16:16:49 -0500 Authentication-Results: spf=pass (sender IP is 74.221.232.54) smtp.mailfrom=sandisk.com; osandov.com; dkim=none (message not signed) header.d=none;osandov.com; dmarc=bestguesspass action=none header.from=sandisk.com; X-AuditID: ac1c2133-4386e98000013ebf-00-58786d02d99a From: Bart Van Assche To: "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "axboe@fb.com" CC: "osandov@osandov.com" Subject: Re: [PATCHSET v6] blk-mq scheduling framework Thread-Topic: [PATCHSET v6] blk-mq scheduling framework Thread-Index: AQHSbRkpBrM5uoRQm0i/QoKHfASlKw== Date: Thu, 12 Jan 2017 21:16:38 +0000 Message-ID: <1484255784.2720.11.camel@sandisk.com> References: <1484170803-9311-1-git-send-email-axboe@fb.com> In-Reply-To: <1484170803-9311-1-git-send-email-axboe@fb.com> Accept-Language: nl-NL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.28.1.254] Content-Type: text/plain; charset="iso-8859-1" Content-ID: MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprHIsWRmVeSWpSXmKPExsWyRobxny5TbkWEwbGLGhb/9xxjs9h7S9vi 8q45bBZ7jpxhdGDxmNj8jt1jzp+DzB6fN8kFMEdx2aSk5mSWpRbp2yVwZWz5O5e14DFrxc/Z F9gbGM+zdDFyckgImEhsmNjNBGILCSxhkpj/payLkQvIvsQosXz9JEaQBJuAkcTsCXtYQBIi AgsZJeY9ncTaxcjBwSygL3Hlkx5IjbCAmcT/vQ/ZQMIiAuYSr39ZgIRFBPQkPq5+zg5iswio Smy43sEMUsILNPLcdHsQU0jAWuLSRS6QCk4BG4nWv5/AhjAKyEq0vOYGCTMLiEvcejKfCeJg AYkle84zQ9iiEi8f/2OFsBUkPq/4xwZRrydxY+oUKNtKYvrpXVC2tsSyha/BenkFBCVOznzC MoFRbBaSFbOQtM9C0j4LSfssJO0LGFlXMYoVJyYX56anFhia6BUn5qVkFmfrJefnbmIEx5qi 8Q7GfxvcDzEKcDAq8fCeCK+IEGJNLCuuzD3EKMHBrCTCy/KmPEKINyWxsiq1KD++qDQntfgQ ozQHi5I4r/yB3aFCAumJJanZqakFqUUwWSYOTqkGxmlypz7OuPFrVc8l3Yf3J53XWdy2/UWY hd3yn6tt2Tx1BDOehH5bsL7pg/2BCuWKq6d+/7v/5EvE1RuhrVb9dnlHDE4Iy5bZTEj0vtRU PuFYonDG2cUhQZeT7uWVrqjY2/us3DtYoC9lufIX0R0P1m59MEMzY1ro0sXvNyzoOs271fSO ++IsuzNKLMUZiYZazEXFiQCSj/DJsQIAAA== X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:74.221.232.54;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(39450400003)(39860400002)(39850400002)(39410400002)(39840400002)(2980300002)(438002)(189002)(377424004)(199003)(24454002)(86362001)(92566002)(2501003)(8676002)(5890100001)(356003)(7736002)(305945005)(50466002)(2900100001)(2201001)(2270400002)(8746002)(626004)(8936002)(2950100002)(4326007)(81156014)(81166006)(5660300001)(68736007)(2906002)(102836003)(76176999)(54356999)(33646002)(3846002)(50986999)(6116002)(36756003)(106116001)(106466001)(5001770100001)(23756003)(69596002)(189998001)(97736004)(103116003)(229853002)(38730400001)(47776003)(7099028);DIR:OUT;SFP:1101;SCL:1;SRVR:BN1PR02MB040;H:sacsmgep14.sandisk.com;FPR:;SPF:Pass;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD039;1:AxvDd4pnSWpfPHrZ1JaF5ShRar9bDXQKNlkqiH8xdRp+sznJxxSwD0GXshplhtPMfExN117U7nTHmLFZMoIboWcvq+g3lYsZZfUMtCgr3NsHX04SWyYIL2PQc9AOVnsWB+IYecM3/PilZOXt3DB6BgoWQOKEgum4emSnSThOG4Nt2vQ4vKMRRiclfmjCkGwSlA5OSdf2TNjVjZ+erAuhKcPNbWPTVeFVly/55mZSvr5tDdQ/GqcYlc+Vl+nRzGp0IUsfFEVwcVBE/g1pujI9P76VVEA2Qe3GDEl6FkuahU6Z23+AIo16gRctTmdzmtqAAq6affBmYZNTauzM2TwYwppAppvT+iUD3OZ6Vk+yGZXcVNKSFZ4RXzorPvM6VBsl1GtCfOaE8b52cTClotZeGJTb5YM+Cv52LUMTRNAWFnipbqI7Es2uwRjULVoX6wxu0aR76j/rWt3AW39/JnKEgmd4+7A1yOUmHR5kCUSZCniOB7mrUR5g0aYiHjt+1fDjKxcs2aUIaG33mu4ROwhTfqwsSOonjufp6wu1/mFjax9HnLXfDSSsA+Ih2qmxib4g X-MS-Office365-Filtering-Correlation-Id: 2cacdf6f-5e25-4797-e28f-08d43b304f51 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(8251501002);SRVR:BN1PR02MB040; X-Microsoft-Exchange-Diagnostics: 1;BN1PR02MB040;3:F23aGnr4YGojnK0mtQ3dGsKVehsDseSmb7G9znMXZ4U+KJdvsfU28ejhGXybJVjr5BfqNEdSRtsfGTlgh/E18BWINTN+MbR4MNiNzXzAXArzP7LWtTvcrfl7N9MB9QnSESUaW4Kd3sTdQQ9xqwCFkBeZIeO2+CnZLopb2cAltBlugTs/jZgobYeUPRQx8o+aU3sBc153W5QkvmyZUyvA3NRJ7b21N0oxKlngrj9hM2zqgS+ZiL7Ei5DGETgR0ZqhiDxwOxSfuadkNjsHWhu0CSHxXzvfjslrUlBeqKWJb1DIB/kobm8ZJVovd2bUtRH/adQtTHdBfFxdFtGg5KaLwL2IIheClkL9+3jZpzWMzvma26fUwfUw5x/aPVrrmVTlqkh5ZMYDTRKYD5P7+HugFA==;25:qlfILVYg8lgGLqN2bFgxmGXBL4ZndduChAtW9TxLizFqWIqktWLH8k2AI67pDpOdxFtkY9VcePRXhxhZ2p/5H2L+fX415bbYKtQwYpQJd0AXP199ptqsRyv4afLloagCZwESjvnKC6aLmrHykmOj5Pe1OI+XnyoY962axgniYKbjxlyudWNQWkT53zd+nfIdHz+PoIflyIGVgNw+C7IWus8JbIDjY5NpBY/5ENQPvTb5Sf92thB8iWCJDH/qmnKnUq/TChJyz7TCfvc93N3b7nG7HGElixGsRNs1TnLoj5zdKYnPa/1wz7V38lRsdu4sM2x6kRskzWrlQz1DhUB00PfCai4aVmBkhfU+bgjQxsoDbCFUC/dXVqCsyShG5/SF0UmFrH+5cB6LRsA0IFCr8osx0UuS+we8ltQhwK5jYrpODxROvmWYNfKLMupq31GwLVuoxvAnW3tvu5TNTi99Bg== X-Microsoft-Exchange-Diagnostics: 1;BN1PR02MB040;31:RNmnYhLKWBWCNxgdGejKaJ9065okW6ZgcW1gXOiujjkFoYFf8DNmYiWspl1GeqQH83LwSGzrqfM19XYxaZEJLiJl1tpFUSBOMKiq+GOoDdSoT6DXSSBkbZz2GjAZHi6ICqxjDxKiD0kSToF5gyI97OCWxiivoXSJ1eU5iP/JnD3WfFWylRcRO1snCiJ5yni+C5GWZ+tOTd/seo90obViUvm1J33Fz7q/Hn78a3RPs4sC8RY4zbrxEvrrvk1exTgIOuXGy+ck7BxIPdxHvEwAgQ==;20:1yR16BaPZIcu9mkXOAJvHjn+xBRtR6hqmGP1gIzuq89o7ZCssI5u/3KQNVsLvFnHmjFYNH9o6d4r6VcOisGFsQAWcTrWh/Ez/pXqbpJZbMdK5rOSRz/ro7SNMmkwPiUFmmwWOm+J2mNVfq9G+sQMR12qIIfRidP2pH8AuxOkah4nk7zdFwXgzwA57ujHTscFj9tMa214rLT8kKnbv9Bw/F+C1QGmMTfTM/NEfixX08erMxaYXwwhZIOGHT0nuRHB4/QAnSTmx4CPZeh2jxfey/JlYK7j1lXzh9xFEdzj8mQ077rVd5sIRQD8Y8siYLsfdySS7RaH0GTkyP41TEVssRJ93p1/ZSRXhGRCGqT+uV92SzQMbfZSM+zDD0Nh/za9/2bNpCG7nqcyqDIUsnpELjP/raVo+2631cW54OiEB+tN63aHBL+Y1uob4uvWIOCZeKpq3gHtNT0KwZBllojWa5c8Xyt9JplfyUudLjjco7Cq/b0USdMc/ij6aq8hdiPN X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(13017025)(13023025)(13024025)(13015025)(13018025)(10201501046)(3002001)(6055026)(6041248)(20161123555025)(20161123560025)(20161123564025)(20161123562025)(6072148);SRVR:BN1PR02MB040;BCL:0;PCL:0;RULEID:;SRVR:BN1PR02MB040; X-Microsoft-Exchange-Diagnostics: 1;BN1PR02MB040;4:bJWQXv+wulZ89FLpyU2diX7SuN/ZdMHS/2c8+WmdYoPwt73Funb+etymAcvioC5QhnaMElAEC83v53foNrhvbEU9ctFOcMbhbWHtaI6KaLloHeFRepWc9IITU4R4gxUNcpXQOquikDgGwy8jYhDc0J4BrqBWMPusftBvQuQ5YgKPnPM2gp6EhZg2sUQMsFlIGaNLGwtYAn8HA/Btpd3/ydbDsTZPdQUQOSlYSogqHYfsAZEg3gFIJO2GMOXfPn2gP/WNjvM06eMW/+QkifcTPz+XwbVp6Bpr7LleP2tiDAqHqESSvMCtKtLcGOGIaRa3GBPaE2cuCkaKNGZTudyWeWuVHsFWpAznRKp/fq20mFp/eNIfBHZfscPm4DQkmYeuQdBuRt0g/VcaQN/eJ9jVuXBhkOKJpQnW8neQFTraoNHLhPbLKBFqQfVpmP/g2dTu2pKIUzZDWAFlamoFsh4rCqdNCYlDvYrlFneMGwhEHQwGzSgH0tYA106Z8frePmas0c2uQIfCIZLMar09w6C5l+CHmzuKZzz8I2oTZLPvBz9sumqR1g5Ns4og+shymV9tlEruvlsnhmVQUlqjLi7bC/qV2FciOvfLECNncoUledg/UqQXRLRvFT32YAZmu/FRQAhyki7oJHmgbW9peJJfCwwO6jvG9ska98pVbG5eLNwvQoOtLWtQODHrRVAsJGn7 X-Forefront-PRVS: 018577E36E X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;BN1PR02MB040;23:KsttFxKUV8Py6Jk88/Oj9Si3aGsSFd9ssZGQ6Lpc?= =?iso-8859-1?Q?JnC/F0q+dbVseJVwvxpPkAVPqkjKulFfV/WlsQRpgr8TWUdaK3HtQs1ZOe?= =?iso-8859-1?Q?+RghKX0XmsD7xb9xmkcIqq2YJQABVHhmnjBma31fuOqliQQyChpnOI6Mnb?= =?iso-8859-1?Q?4Z02zRue4kYTPGNWfGnYoLLgintSkSmSsFa1fO7Kmh0vrqddQj6aYEEyJU?= =?iso-8859-1?Q?Q4v7gX7UW1zoBh7QAz/LvT3Hncq8HF9lFTGrhImac50cxiWTleL5cwigFv?= =?iso-8859-1?Q?wHb5eMXTXi8gErH/JSqDIC1MYUh0SkttxHQ9ost6XQh3argrLAHnYskFfR?= =?iso-8859-1?Q?N/QnwTi3u2zL/wuffb04/TjZfTS92wGFURymt49w+PgjC/v7FGM9SemMyd?= =?iso-8859-1?Q?y5ssWc4rdXs3F57OIVdzjQxTgftESX4TsMwXS8TrSCd7mORpyDwaQ2o27P?= =?iso-8859-1?Q?iQpRYwb8eCa72Y9VUg1wh0QWS3xxPMiqt/pQzUmWXnwfrahe5offgWuiTt?= =?iso-8859-1?Q?MuC5gEKhLV8a4bUe/6hMBV+I4o5jm9mgvYo2BFM0yQ6JXlTIEkejAjXVAi?= =?iso-8859-1?Q?RQ1XfyXV071HmMrDhFWbPfSreqQIoSLArj7d1jHZQgzrd2/wxIbFHw4UyN?= =?iso-8859-1?Q?6m6R2m6Ei1HKsmG+MHx2clShUNdzpYYTHFYw9YO6MiC/sU4hyst0MHL/G2?= =?iso-8859-1?Q?+Bw6MZcyHk5kMgTNLrgUZMWLkntMHUUbuDHnhCUcOpUY3ow4RX73jmyPJ9?= =?iso-8859-1?Q?51p3gIpx5MzUM2BBQRJ5CEU46GoaXeghgdLTTnDLJOiI1OzdkVeg6gk89L?= =?iso-8859-1?Q?Jmo3ErHAuMUH4IztdwB9QAJdBS5A1SxRXFq1XaAyPfY868JOYzOsIPkYZK?= =?iso-8859-1?Q?QGJi6FTnUGb08zpqAbcf4M+LlPK1Jj8ezHrirI3WjPHwXjBjeZPMg+Jno2?= =?iso-8859-1?Q?WKLxfchLZV3UeZB5041NfsIHp4ZAla7LWXMG9KE65GWw+eX4zfwyGbzeAZ?= =?iso-8859-1?Q?UG0R7pn5MNrTJsyQRmWArMVJL0YRpPZUEMuDM0WsYdYaBF6wnd7Yj255e3?= =?iso-8859-1?Q?LvC9wnjoVfNLkCgEq12HdyvVM0dGpNxBKOyaJKBwjRw4KutGpfZJw7mNaC?= =?iso-8859-1?Q?KSF3HRq+OVHqd9ceE8HGmpo/keIxmlWe9ZLQSYX+LWZBde8La6Aii5b8Ln?= =?iso-8859-1?Q?GaXSsIsbgKQ96rnw3fyZoyU00rERcDl+l8h4RLvswAhnGBP041Nratk95A?= =?iso-8859-1?Q?/IbD37Ju+Eu9nE3CtEgp8t1RA4QIgS6IpxwXDm5AMUcEwL5oIL3yBUWc/Z?= =?iso-8859-1?Q?78BVsnsFWilPNuUePn7TmY0AR9NFqjxKoPc7h2+70KDpeLeN15cz/KHiF+?= =?iso-8859-1?Q?/L6y6F18J/L6h0VKRY918kNOlxtX?= X-Microsoft-Exchange-Diagnostics: 1;BN1PR02MB040;6:cWHSqeDJgQjuJLEWNucZR1SSO9p8O5Z1gTr9PAOALB4UbndQ8y4TtPXaiYiMkg0QWBMUxyfdbtJ7dy5Zgi8/vOHak0zBXIuak3glzcVSZsk69zCoDwA+3QzhTHMNGtK54HA+ae9lGe9FM5STLPGZZEq0z0irEtrtGgUqPQdOnL5kbamS1BrX8s91U4GTp8hQEKRXQZVopCnXNVkyfxOuE/JJJox0oKmIPNiwgal1S20Bl83+EXRfSjoI9EvSFijlZnYVjmY2RN20vlYgDjDljMTCeCQwNkNH1DhWl878igM8waAOE/3X9EDhO9aGOsx5au4MK+FoGCFFOBxXuGTGZpaPKv4lplv/tp5o8ULugBCqoJNJtVUaLcB85ErQwprueKdqSXecKHMWQp56dEzjshZXnrYGx8Z9b6Zb3e+FbjKvTR5FpP+IzAsl4D1GrcAeP625JaC42HWVwaISsbskvA==;5:+9gqaLqxTVYpJeV0Gu2YtxFIfqkM1olJwCbXok35vI7kwKqpmkRCXTz9v5mHmT4HvlFpj5SY08slQhjkf++27NvLMlccdUOogoJVYTf1i256O9VcmKNV4yerDcux6M/Xgq8xehcQtGjT0UxAcjuhhaekBm4XGk8GMgHMZ2AjTeA=;24:zz1S+u/GJUTGl9/skpFebCKpUFRhOCBkASrERUqg9gXwWk6FjpDgXhEJRfFPjVZtEM/Eebrad5Y1FJArPqUoBRtH2ehDpX3S+0IshGmzcfI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN1PR02MB040;7:6SBwhmlDZAyIRg/4VoIUMlFpoR0tWmglLnYaRgN2Bm+pWtVCAmszi0tspuIrWICPoc8leWBGXd7y2dqW1WBe0DTBwvfy6isgB9oibfY+tNROcEFDQMGtW63fA4u3C4Hkm2FD7OTJ6+SKUa9GvB8CbP0kzEVLRD2jek7ZXmo9NntonuWXL+GedLkjNLzgRCRvLP8E6dNe+166IZ9FEDAY58FPkEmBql8myeFpQeUkcM4xrOS7Ff/LSPiDlnDPwggS31QuqQ9yIbPiJu3GwWGWdJBgcI//+OnRBW3pYAKzP+IsDXlmCxZV9AN0kBHWn6Pl0HE+ck54Y65cKyWOe0lS2wcQXRoGU+xMCCdkyghYX5hVoI84fNE5a7xYZ7v0v4CXK0JJO/oYdcgUTFzdG3qxAa2jY3qdsw5bItSMun7q/zPJWXGoOSx1cce7wnFfqEqeFV14GE6B9w1yOAGvKH0S0Q== X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2017 21:16:42.2442 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[74.221.232.54];Helo=[sacsmgep14.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR02MB040 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v0CLHC6Y019896 On Wed, 2017-01-11 at 14:39 -0700, Jens Axboe wrote: > I've reworked bits of this to get rid of the shadow requests, thanks > to Bart for the inspiration. The missing piece, for me, was the fact > that we have the tags->rqs[] indirection array already. I've done this > somewhat differently, though, by having the internal scheduler tag > map be allocated/torn down when an IO scheduler is attached or > detached. This also means that when we run without a scheduler, we > don't have to do double tag allocations, it'll work like before. Hello Jens, Thanks for having done the rework! This series looks great to me. I have a few small comments though. I will post these as replies to the individual patches. Bart.