From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751038AbdALV3L (ORCPT ); Thu, 12 Jan 2017 16:29:11 -0500 Received: from mail-sn1nam02on0073.outbound.protection.outlook.com ([104.47.36.73]:30624 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750733AbdALV3F (ORCPT ); Thu, 12 Jan 2017 16:29:05 -0500 Authentication-Results: spf=pass (sender IP is 74.221.232.54) smtp.mailfrom=sandisk.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=sandisk.com; X-AuditID: ac1c2133-0afff70000013ebf-21-58786fe7f3a0 From: Bart Van Assche To: "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "axboe@fb.com" CC: "osandov@osandov.com" Subject: Re: [PATCH 07/10] blk-mq: abstract out helpers for allocating/freeing tag maps Thread-Topic: [PATCH 07/10] blk-mq: abstract out helpers for allocating/freeing tag maps Thread-Index: AQHSbRrjTF8O3v/WekO965dsvFNYpw== Date: Thu, 12 Jan 2017 21:29:00 +0000 Message-ID: <1484256526.2720.19.camel@sandisk.com> References: <1484170803-9311-1-git-send-email-axboe@fb.com> <1484170803-9311-8-git-send-email-axboe@fb.com> In-Reply-To: <1484170803-9311-8-git-send-email-axboe@fb.com> Accept-Language: nl-NL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.28.1.254] Content-Type: text/plain; charset="iso-8859-1" Content-ID: MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrIIsWRmVeSWpSXmKPExsWyRobxn+7z/IoIg/5Hlhb/9xxjs9h7S9vi 8q45bBZ7jpxhdGDxmNj8jt1jzp+DzB6fN8kFMEdx2aSk5mSWpRbp2yVwZZy7tIO1YC9rxY5Z /xgbGDeydDFyckgImEh8+XibqYuRi0NIYAmTxMnNOxghnEuMEjdbP4NVsQkYScyesIcFJCEi sJBRYt7TSaxdjBwczAL6Elc+6YHUCAtEShz50skKYosIREmseNnBAmHrSZw+3csCUs4ioCpx bFMBSJgXaOS5/p3MILaQQJ7E0p5mRhCbU8BGouftYmaQckYBWYmW19wgYWYBcYlbT+YzQdws ILFkz3lmCFtU4uXjf6wQtoLE5xX/2CDq9SRuTJ0CZVtJ/Fi3lBnC1pZYtvA1M8QJghInZz5h mcAoNgvJillI2mchaZ+FpH0WkvYFjKyrGMWKE5OLc9NTCwxN9IoT81Iyi7P1kvNzNzGCI07R eAfjvw3uhxgFOBiVeHhPhFdECLEmlhVX5h5ilOBgVhLhPfG5PEKINyWxsiq1KD++qDQntfgQ ozQHi5I4r/yB3aFCAumJJanZqakFqUUwWSYOTqkGxtbjqwrKZ9fXSJZvfOlTlCBh6JJzPTbQ 8fHJ1jv3Wx4uNGBMafrBdSHe2P7H7eALPYJziz+oqaxqST3ukPF2gwjDl5TLVxzS0qdLLHQK XWAXYVhpEPOWc57ThdBbbf/27jeoTsgo+JvQsdBDtiLy7uOYPce2Rr+eHv61NFFJSFLi89Mz a+PtlViKMxINtZiLihMBdxk6vbQCAAA= X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:74.221.232.54;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(39850400002)(39410400002)(39450400003)(39860400002)(39840400002)(2980300002)(438002)(199003)(189002)(24454002)(377424004)(5660300001)(69596002)(50466002)(2950100002)(4326007)(103116003)(2270400002)(305945005)(86362001)(7736002)(229853002)(2201001)(38730400001)(356003)(76176999)(92566002)(33646002)(2900100001)(50986999)(106116001)(8936002)(8746002)(36756003)(3846002)(8676002)(47776003)(23756003)(81166006)(81156014)(5001770100001)(2501003)(97736004)(626004)(68736007)(54356999)(102836003)(106466001)(2906002)(6116002)(189998001)(7099028);DIR:OUT;SFP:1101;SCL:1;SRVR:DM2PR02MB1418;H:sacsmgep14.sandisk.com;FPR:;SPF:Pass;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11OLC016;1:Q+NC6NWKgy7Nsnnu9y3ydvLJyRaaCRpURzZtWwb30H2BH04YqzmC23Kb92doATag5f2uFXh6V25wngMb8JybYqsCaVHP0VR+fyFAGNSMPgog2zXg3qU9j1cQnr+lvIy9IEkPFejum3oGvAywi+M/FSAxvZhrRXEovg/4DuRjLLHP0WH4u/RJXaKLBV/yXSvbFWk4V0VhLKcLPxl3Yb27nyV0lJDaWj1735rHheiVoM4L55pPLiP7Dqc+yPXrH96j0FA0emvqrWQ9cpGsa7sRrb9mK2IEK9fmEZY6YvlVfKHF6zHzp+TrX5+cvhYxwObEWu/2ko7JPZDBMHhIwdtJngq1nvEjk6Fh1GhUG+1ZbA3qC+j7fdNqMgLDcO+nXz94F/h8mUYE8cSQpMxcAG5l1EZO+qrd0m16lUZI1xPxDwnz4j2B9oGL/LCS2TJf96WuHqfehlkOfmcNCHLjVkd8fJdMpWNnedCwc3UbY5zP+LKCy31hTb4fzmwJ+9H3ld4Ebu0MgHibtKdidA3nImDfvg== X-MS-Office365-Filtering-Correlation-Id: c4287bdb-e949-446c-680b-08d43b3207c8 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(8251501002);SRVR:DM2PR02MB1418; X-Microsoft-Exchange-Diagnostics: 1;DM2PR02MB1418;3:kbmcQjHRH1sjRujEAL71ilmiyIAenkGtl2XhXzoth50mIm1ifPv9eKjp+vz3U38nsODr11igOWlmsJOSUuCpjVpk5gQ5ubMm3MzpslNLlukQRBS98QungcsjittPBg2a5bCTVP29DxJ46Pz0YbC8HJ05hI/Az/kiD2Bb/Znxw9EFhAGAyh75KCD6SG66Dd/+tmEN79G7iE1AEsIlC/REdZWcvh2MnhBrq6nyNHERpWEgDTD8X1Azns6dr75uTvqvAnkSeYuoZfLo1C167bEIDyG8N9RJ1C7a34N0dBubQd4GpKFR7pMOKu2A9OnKYkba5ynDtj5bWitxaPQkfiL6/2t/uwgfC/N0QyvQPTn2EMmRKyZs6XXnOnmOODpaPUkdfbVzuonKzAWBZ+u5piIpAA== X-Microsoft-Exchange-Diagnostics: 1;DM2PR02MB1418;25:ejfnL8uAjMazrEs9L1+2BtB3zul4ZYzKXhKZgoyOzmrkxKAOIh36XCfC2dcZqxFtRZBt4/9uZIxI5TMwurRZ21wzNhAiVEkN9RKeIg1yG4LHtq5Dpv8Bv07UiUo5h1k+QszQVRx4zcQTAhaUGmPIBHeurxwb5bjAYpZ4Zj+HCCjuNkZaiqF4eSqMsQMB8tiXydVOiH5hn114YHiai8YAAgJ4SlJaN6rzV/n2VtgBJrDGS6ZT9FbHfWtgqMhfMfCl/8wyDt3og/h2YQT0n1BNlX2gIGkqGrwAyBzKaf8zNuu7tHwzpNfHMwTbFz0TooWy8SCdciwjiIRYQCUbnuSqTebEtpWKimsCDxw+hJa9/JoLdQ9ZgFQeKWQjKbUgQAYTFMEq/ZaALnHFWAG8m5ILOLsUG3j2LsJyjYx4qNnru0ma2nba8y8+0E2YvQ+yFyJ2Jg66cnQQkKIWrNe0GAdTFe+7+R9xtnzK26f1EmwuTECEFceL9C2ibu3PJ/RdAcIALDWTJQK4syRY1ft6uHPLVjygtif7yKO8uwMPolDu2lUG+VnOFTIu/O9bohTMl+/0MQaBu1ThbQKu8vilI3txG9n6LWRdJOn7DIpoleojSgncbMXkgYHwBtrWwaupbW4Fu9GIyfJ1GuZkWtcDeZJdcdhyrJxVvsnuFRcqTwCDYxWm2Ee8B8cMea+4kb1BKSqnTFhCHB8ZD7ASeO8xr64uTQ31x9IZsFAGeCIYqWlWl6v9lZk3uRunKU2LSr56I4vH3psgt3Mux2dJW/qLF0fE32lPEheOIB6J/p3PIiccACS21bfWBYN8pwSk5/lVbd0z X-Microsoft-Exchange-Diagnostics: 1;DM2PR02MB1418;31:mor5FXivTfozsC+Ot4do3RpCw0odGJAYLUjbUpQyo8VC85F02q626z2w+xx7OV3wIRKe1HvfEFB0LgMu9noKg2b5j9USV6i+3YKUdBIuxWNA7EFXzv/UVex0doQS1Tygfgh8k1/6JVgfs8ukkKJasortHt9gf2ik3E7yBfGq7bgKu2pFTBahcvzK6Lfb355E3sJoqZD9ovxoAD4vsGP2fGhfxWDpqf5Wd2r4IS+M3HnxNG4HbunaHdgV3L8rr9/GUwHFFF0XlByKP6Te9ozOlA==;20:yybM/kgwhmeo+nrYsJP3WidM2kIMSazoIrFeM6yMCPkKuY4MOvc+ohL9WxrmoZt7wbhiMGW3Vnkw1oYw/u+BrXG6xGNsGRpBGs7Sf44hpvCh9oiBRRSDXbcZYujkrVXki0qgylz4nsF8jSG7oKJ9lUz2wjQpWKHXkim1AXAqdtzvnIOlOvxUfJu2q/51+YmFIYs1r0yfbtoHKuuvOb0QUTDMugvEHr6dJObUVT3u44IzYKQTJKcIUlVOhxrcgo6aUM5bvnrmt2oscNBrguT7Nh6qh6SVHckJZO7cp6RbJzGcqgtlqZkFxj0CTxWfD6tUV02yjTfBQIo5axc8zvmEzHK5yPuAi/dwPNnaxmZBRPMq3q45Njn9CQvVdO8V727s5kZd9zjJTW09RnDyu+QQu0s8CxI00hpbykWqMXQNdlgs912hHHrXZ6HF6uCFdvcZN2xuK+Wy631f36aEk57KIC3oqa4kJgFSeyXYVHHDjZWVecNsTXGBNW7MkIqzB8e9 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(42932892334569); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(13023025)(13024025)(13017025)(13015025)(13018025)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6041248)(20161123562025)(20161123564025)(20161123560025)(20161123555025)(6072148);SRVR:DM2PR02MB1418;BCL:0;PCL:0;RULEID:;SRVR:DM2PR02MB1418; X-Microsoft-Exchange-Diagnostics: 1;DM2PR02MB1418;4:YQLwewPowt3vGIaj1SpqmlZIf5GNnzHbrnD1GIKDbnTfHf4Q+3423VnpQfvrnhlQbzL15cBpi4KTNM2vls5ckTQMmMHFY0TWc0oNaOrWCLq7yii86NyA6yWWMRsXNXeSczW+VusSd0P0+JOtb6G8amwA6xJJ+bPsAtTXhBoCrWRFzSMTNz28rZ2OEgSvzQDICin9U4GIgmz6dGXZqLnVdBPz3Szs5jmT25h9v/gv2L6srXfGaB2BddseC3dwLUmImjhLmJmf/03Xw1+mV+GYp9n6rE4zNEnivWbn0M3ZE00CUNUS1BsDuSmqDRyKbROs6gIsxZxGMBiEOC+WaPS+iL5+deGjvFRuuGMZjbMxgxCzWGECC/qkTl4sbLycZ/wvgZctk+ug4KrKvR+UQKrOuhPI2tflbMscWx/TeKcT0/c8e0DTPwuwDkDtexmFWl1I5D1Hew2w+g4zZjxEK3Ucr6zW/3+fU90fMSgEQoH3GmoWwfDaBj8tij4i9n1yltNKrtL9cS+vZyVVS0XC9Uc4nRa6hIGy+VoxU3NqVYgXXCQeDgrT2SLJbhGBUvdO0EWN3nh8T2m9E3HuvF3arXQFD89654pAftf8vvuGEmdI9qbkfT9rIy0i/QEh+IU4YJGirZeztzb4P9f3nM9MKWdQ8nydp+08KSLiwG//UUbBqXSZbpD2JYDJDfbmvzF9ph6IOPdepd+gZ/FQ4e0PeuasdN17wiGSSkU1EXt0SyyFfwo= X-Forefront-PRVS: 018577E36E X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;DM2PR02MB1418;23:kcTWhIBMbsLVQYJqsHWOY9c2obvdX5LlRmU7WVx?= =?iso-8859-1?Q?LwZtAAAgf0dS9+bYlepm02p8IwElYyumYxrhbXm3cMVSJb22RkFC4/kQ6y?= =?iso-8859-1?Q?kJSOhMug4Zn9f0LKHsdLvBCU3s1/2/Ka/NE24u16zfheGgeP85Z7KK08aW?= =?iso-8859-1?Q?iyT6BouNLg/jqz1VIJ92sI1UEekUtgHCMi5Sirm/bLBEKz+1POouNTh4Ta?= =?iso-8859-1?Q?5/pHUMNTDr1gsA32x5G0l6qfqknROVmq/gzMl/rZ2TAUHmP0FxmRhqsAuJ?= =?iso-8859-1?Q?7kcfopED0imt0shSaQf2gpefKkRFGoZg3HX5+138cGhr1/WXhfkbvASNfz?= =?iso-8859-1?Q?YJwuWcEI9dtSlsi6VWAShQnaxpXj5w4OSpgX+nkQ+22aWABZCzHOfHs92C?= =?iso-8859-1?Q?i68UzJe7i1sDxxcIllcuQ24wpd+Er5s+oOAOH8gprufkoZ8REDPrJcLEV4?= =?iso-8859-1?Q?AwCDpy7YIjB6fmBc19Z3vIg4diXQUOJoDGe1copySTrlBalgnEWU7YvrqM?= =?iso-8859-1?Q?pwIC2Fc7ZobRcng1Zr/dhTTUoQcxWs33MlWnEfW4OMZpjlW7MGEGfW+Ik4?= =?iso-8859-1?Q?G0+eu0GMJYXK9w6Yy7RNmzUCXrw1LmFGdqtG0jN5P64HdC4Jw2RVmS0KxX?= =?iso-8859-1?Q?KT83xXs/dMghXko6CHoGoXsehMzKBZO7WF/3CEQE7BjwiSSo5imhCglhJC?= =?iso-8859-1?Q?qhI1OXvwiGHWaJsnNmVfPPKXhZCdMbZmB/L9uPadLT1B9iuzl641Gco43E?= =?iso-8859-1?Q?YDeME0DoV49N1M4P/GsQCUD//cMZE75WIbk52Erj1LKVlIhlHZqY3ekq4R?= =?iso-8859-1?Q?cqK7lOmaH+LSpevJidb5truj4WHrXh/l0ms5IeCk7HIsfPKdShAomvfNbs?= =?iso-8859-1?Q?+llo52J+fVbursyoiuBh310xSYa9ArpNPTLMrzBmDn3Js4SZos/Dy5PZO4?= =?iso-8859-1?Q?hZesycuD3JvyzD0BTVvY4Q2SxzLCrsJB2LZSmLOuZnthtSAn9SwYEC1d5d?= =?iso-8859-1?Q?cNx9seFupR4yFtfFFi9Np66OM1d1AOdsGqhAjMpvet/8Cf3CTKrJY5FBQ1?= =?iso-8859-1?Q?BvnZLZjCPUrpleZDUN15zEAkU2VUZNbRgt5iFBVT2/+BL6JoCwc6JJMjLo?= =?iso-8859-1?Q?X1cOAD27n+qOXryEIJqc7ul6RvtlpqRAhh0BLvn+A8/aHSULn8XY3XVXSM?= =?iso-8859-1?Q?pvtNzTQgU8lq86O37DInO4C15DCloYHlDriXAhFR/XW/1cNVRPo/dbyuW6?= =?iso-8859-1?Q?QuwHV8DXGf+ecXa8bRGBVYEFaupW3ciocgiZ4eNketvVnY5qJgHRczRcmg?= =?iso-8859-1?Q?assRIcnO3IAevSzPgkWElIvev+xA2Oq2kWCuTEptzAHOsjLQ5p4jtBuQwt?= =?iso-8859-1?Q?B6ZTluZc=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM2PR02MB1418;6:0LZ++NeDhFbIxJi+zOZZhu9KWY+neyn3JJOVRCqosnLNf0grPXZO0pCZlSvh7EDtbiVV37GYFXuVJbPgEoIu4Atdd2ih8kXxmJL9VZuffFnq+8zMxp7tiusjiU3vn1nsJMUevvgeTF00DSPQYPppv3G1Gh0YOC4zz7ztjYuJ9gqMndJfgjwxoNZrqKf03PphoM1sD1GEtuMtF4qgbaNyfj2kis1f3iznLcDQMQnja3hJi9txJOAQCJ08og7CraB5UzOaG0RhLuz9p3oUhlnKwE60ZCp0OOCXRyf2xviXfqB5X5pTtmOlHf90+MmQrTnJ1X6zsv/iPJJACa2KPWAItBV2MDba/zNcz0y/0YNtQCD49pCagD9F5aV7UC22kCnvmAIUhctAIf/rS+kBIF4Qx2Vwft6fCC3+UWPDkpJNhXrA/37TKhX7dD3R4EUnTySOWhG1C1dOJqsie9mjxkncmg==;5:/tBGCemEcSrNssqoyQCMyLUi/nSjoUcCmK8izwl7FoDjBJXlkKBTnodGw1gN2Vq0O0chLqWQcozq484ECyIk0dg/8iIXhEFyKl0zsbM34WY4N75QIukn4ezoFG4lTlKTaYeOftbJ/WSxebQyF22u0+Jc22uRf2X1yq8E9p/yYJ8=;24:yZ82LsKKeUZ7FdMcwSX3OiJoee5FbX/MImQifdqFtKfpAixD4BeVWnGHEJf8+LJ2Dn4bypL4+1vB+BM0VTrNn3wZUvHbm4DzdsTs68b0ln4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM2PR02MB1418;7:XY8WfMG7czRh27rXbam8NkuljMAOP/48b5fHXsFdec4z4FR5v4HtPLw9/ReJTpwbH8brVSTm0TZJh0IIKjA5zAUqcVcCocAT84+kCsWQZhKVgwfKkuWJMMcTe1oyJhEgsEso9IZRmpMqisbY31yEYA48KtWeMG0icyuIcJBpNi1Ts+p/i8jroObPACy4H42RvBiyvVsWmDr2BcAn0ApmJlDFUjgdIepDtI/2MJrgwKsOE8HCt/dE/gkye7ILw4H32LgU05AiBCR/X4POrWmnntfqG1ZHT9oR7R4cmSK4T+xjOmEu2v6KV8/fgH8mq9EIgrXl/Xg82y4gTc0G8z79oa+5cxIdk2JO8iVWJPxo0m8EdzTTJ4LsbggFtCH9kcL6IdFHNNJUpcpOWiAXmAPmaww8aYFNt/eG6h9QvLvL5ZXw/V66F3J4SsBKZvTvpeoe8t4AVhy1jk7plcjhpSbIAw== X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2017 21:29:02.3728 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[74.221.232.54];Helo=[sacsmgep14.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR02MB1418 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v0CLTGqJ025977 On Wed, 2017-01-11 at 14:40 -0700, Jens Axboe wrote: > @@ -2392,12 +2425,12 @@ int blk_mq_alloc_tag_set(struct blk_mq_tag_set *set) > if (set->nr_hw_queues > nr_cpu_ids) > set->nr_hw_queues = nr_cpu_ids; > > + ret = -ENOMEM; > set->tags = kzalloc_node(nr_cpu_ids * sizeof(struct blk_mq_tags *), > GFP_KERNEL, set->numa_node); > if (!set->tags) > return -ENOMEM; > > - ret = -ENOMEM; > set->mq_map = kzalloc_node(sizeof(*set->mq_map) * nr_cpu_ids, > GFP_KERNEL, set->numa_node); > if (!set->mq_map) Not that it matters to me, but this change probably isn't needed? Anyway: Reviewed-by: Bart Van Assche