From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jan Kiszka <jan.kiszka@siemens.com>, Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
linux-kernel@vger.kernel.org,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Sascha Weisenberger <sascha.weisenberger@siemens.com>
Subject: Re: [PATCH v2 3/3] spi: pca2xx-pci: Allow MSI
Date: Mon, 16 Jan 2017 21:08:38 +0200 [thread overview]
Message-ID: <1484593718.2133.156.camel@linux.intel.com> (raw)
In-Reply-To: <9f5bc54a5842b383dc81fa8586d6774c03d2c452.1484592296.git.jan.kiszka@siemens.com>
On Mon, 2017-01-16 at 19:44 +0100, Jan Kiszka wrote:
> Now that the core is ready for edge-triggered interrupts, we can
> safely
> allow the PCI versions that provide this to enable the feature and,
> thus, have less shared interrupts.
>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> drivers/spi/spi-pxa2xx-pci.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-pxa2xx-pci.c b/drivers/spi/spi-pxa2xx-
> pci.c
> index 58d2d48..58dcadb 100644
> --- a/drivers/spi/spi-pxa2xx-pci.c
> +++ b/drivers/spi/spi-pxa2xx-pci.c
> @@ -203,10 +203,16 @@ static int pxa2xx_spi_pci_probe(struct pci_dev
> *dev,
> ssp = &spi_pdata.ssp;
> ssp->phys_base = pci_resource_start(dev, 0);
> ssp->mmio_base = pcim_iomap_table(dev)[0];
> - ssp->irq = dev->irq;
> ssp->port_id = (c->port_id >= 0) ? c->port_id : dev->devfn;
> ssp->type = c->type;
>
> + pci_set_master(dev);
> +
> + ret = pci_alloc_irq_vectors(dev, 1, 1, PCI_IRQ_ALL_TYPES);
> + if (ret < 0)
> + return ret;
+ perhaps an empty line?
> + ssp->irq = pci_irq_vector(dev, 0);
> +
> snprintf(buf, sizeof(buf), "pxa2xx-spi.%d", ssp->port_id);
> ssp->clk = clk_register_fixed_rate(&dev->dev, buf , NULL, 0,
c->max_clk_rate);
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2017-01-16 19:12 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-16 18:44 [PATCH v2 0/3] spi: pca2xx: Prepare for and enable MSI support Jan Kiszka
2017-01-16 18:44 ` [PATCH v2 1/3] spi: pxa2xx: Factor out handle_bad_msg Jan Kiszka
2017-01-17 11:18 ` Jarkko Nikula
2017-01-17 18:46 ` Applied "spi: pxa2xx: Factor out handle_bad_msg" to the spi tree Mark Brown
2017-01-16 18:44 ` [PATCH v2 2/3] spi: pxa2xx: Prepare for edge-triggered interrupts Jan Kiszka
2017-01-16 19:07 ` Andy Shevchenko
2017-01-16 19:46 ` Jan Kiszka
2017-01-17 18:52 ` Jan Kiszka
2017-01-17 7:54 ` Robert Jarzmik
2017-01-17 8:05 ` Jan Kiszka
2017-01-18 8:21 ` Robert Jarzmik
2017-01-18 9:33 ` Jan Kiszka
2017-01-18 12:46 ` Mark Brown
2017-01-19 15:34 ` Jan Kiszka
2017-01-19 19:37 ` [PATCH v3 " Jan Kiszka
2017-01-19 19:57 ` Mark Brown
2017-01-19 20:04 ` Andy Shevchenko
2017-01-20 12:21 ` Mark Brown
2017-01-20 15:29 ` Jan Kiszka
2017-01-20 16:14 ` Mark Brown
2017-01-20 7:42 ` Robert Jarzmik
2017-01-24 18:39 ` Applied "spi: pxa2xx: Prepare for edge-triggered interrupts" to the spi tree Mark Brown
2017-01-17 7:58 ` [PATCH v2 2/3] spi: pxa2xx: Prepare for edge-triggered interrupts Robert Jarzmik
2017-01-17 8:10 ` Jan Kiszka
2017-01-17 13:11 ` Jarkko Nikula
2017-01-17 14:43 ` Jan Kiszka
2017-01-16 18:44 ` [PATCH v2 3/3] spi: pca2xx-pci: Allow MSI Jan Kiszka
2017-01-16 19:08 ` Andy Shevchenko [this message]
2017-01-17 11:18 ` Jarkko Nikula
2017-01-24 18:39 ` Applied "spi: pca2xx-pci: Allow MSI" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484593718.2133.156.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=daniel@zonque.org \
--cc=haojian.zhuang@gmail.com \
--cc=jan.kiszka@siemens.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=robert.jarzmik@free.fr \
--cc=sascha.weisenberger@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).