From: Hanjun Guo <guohanjun@huawei.com>
To: Marc Zyngier <marc.zyngier@arm.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: <linux-acpi@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Greg KH <gregkh@linuxfoundation.org>,
Tomasz Nowicki <tn@semihalf.com>, Ma Jun <majun258@huawei.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
"Agustin Vega-Frias" <agustinv@codeaurora.org>,
Sinan Kaya <okaya@codeaurora.org>, <huxinwei@huawei.com>,
<yimin@huawei.com>, <linuxarm@huawei.com>,
"Matthias Brugger" <mbrugger@suse.com>,
Wei Xu <xuwei5@hisilicon.com>, Ming Lei <tom.leiming@gmail.com>,
Hanjun Guo <hanjun.guo@linaro.org>
Subject: [PATCH v8 14/15] irqchip: mbigen: introduce mbigen_of_create_domain()
Date: Wed, 18 Jan 2017 20:55:04 +0800 [thread overview]
Message-ID: <1484744105-53140-15-git-send-email-guohanjun@huawei.com> (raw)
In-Reply-To: <1484744105-53140-1-git-send-email-guohanjun@huawei.com>
From: Kefeng Wang <wangkefeng.wang@huawei.com>
Introduce mbigen_of_create_domain() to consolidate OF related
code and prepare for ACPI later, no funtional change.
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
Reviewed-by: Ma Jun <majun258@huawei.com>
Tested-by: Ming Lei <ming.lei@canonical.com>
Tested-by: Wei Xu <xuwei5@hisilicon.com>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
---
drivers/irqchip/irq-mbigen.c | 42 +++++++++++++++++++++++++++---------------
1 file changed, 27 insertions(+), 15 deletions(-)
diff --git a/drivers/irqchip/irq-mbigen.c b/drivers/irqchip/irq-mbigen.c
index c01ab41..4e11da5 100644
--- a/drivers/irqchip/irq-mbigen.c
+++ b/drivers/irqchip/irq-mbigen.c
@@ -236,27 +236,15 @@ static int mbigen_irq_domain_alloc(struct irq_domain *domain,
.free = irq_domain_free_irqs_common,
};
-static int mbigen_device_probe(struct platform_device *pdev)
+static int mbigen_of_create_domain(struct platform_device *pdev,
+ struct mbigen_device *mgn_chip)
{
- struct mbigen_device *mgn_chip;
+ struct device *parent;
struct platform_device *child;
struct irq_domain *domain;
struct device_node *np;
- struct device *parent;
- struct resource *res;
u32 num_pins;
- mgn_chip = devm_kzalloc(&pdev->dev, sizeof(*mgn_chip), GFP_KERNEL);
- if (!mgn_chip)
- return -ENOMEM;
-
- mgn_chip->pdev = pdev;
-
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- mgn_chip->base = devm_ioremap_resource(&pdev->dev, res);
- if (IS_ERR(mgn_chip->base))
- return PTR_ERR(mgn_chip->base);
-
for_each_child_of_node(pdev->dev.of_node, np) {
if (!of_property_read_bool(np, "interrupt-controller"))
continue;
@@ -280,6 +268,30 @@ static int mbigen_device_probe(struct platform_device *pdev)
return -ENOMEM;
}
+ return 0;
+}
+
+static int mbigen_device_probe(struct platform_device *pdev)
+{
+ struct mbigen_device *mgn_chip;
+ struct resource *res;
+ int err;
+
+ mgn_chip = devm_kzalloc(&pdev->dev, sizeof(*mgn_chip), GFP_KERNEL);
+ if (!mgn_chip)
+ return -ENOMEM;
+
+ mgn_chip->pdev = pdev;
+
+ res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+ mgn_chip->base = devm_ioremap(&pdev->dev, res->start, resource_size(res));
+ if (IS_ERR(mgn_chip->base))
+ return PTR_ERR(mgn_chip->base);
+
+ err = mbigen_of_create_domain(pdev, mgn_chip);
+ if (err)
+ return err;
+
platform_set_drvdata(pdev, mgn_chip);
return 0;
}
--
1.7.12.4
next prev parent reply other threads:[~2017-01-18 13:16 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 12:54 [PATCH v8 00/15] ACPI platform MSI support and its example mbigen Hanjun Guo
2017-01-18 12:54 ` [PATCH v8 01/15] ACPI: IORT: fix the indentation in iort_scan_node() Hanjun Guo
2017-01-18 12:54 ` [PATCH v8 02/15] ACPI: IORT: add missing comment for iort_dev_find_its_id() Hanjun Guo
2017-01-18 12:54 ` [PATCH v8 03/15] ACPI: IORT: minor cleanup for iort_match_node_callback() Hanjun Guo
2017-01-18 12:54 ` [PATCH v8 04/15] irqchip: gic-v3-its: keep the head file include in alphabetic order Hanjun Guo
2017-01-18 12:54 ` [PATCH v8 05/15] irqchip: gicv3-its: platform-msi: refactor its_pmsi_prepare() Hanjun Guo
2017-01-18 12:54 ` [PATCH v8 06/15] irqchip: gicv3-its: platform-msi: refactor its_pmsi_init() to prepare for ACPI Hanjun Guo
2017-01-18 12:54 ` [PATCH v8 07/15] irqchip: gicv3-its: platform-msi: scan MADT to create platform msi domain Hanjun Guo
2017-01-18 12:54 ` [PATCH v8 08/15] ACPI: IORT: rename iort_node_map_rid() to make it generic Hanjun Guo
2017-01-18 12:54 ` [PATCH v8 09/15] ACPI: IORT: introduce iort_node_map_platform_id() to retrieve dev id Hanjun Guo
2017-01-18 12:55 ` [PATCH v8 10/15] ACPI: platform-msi: retrieve dev id from IORT Hanjun Guo
2017-04-17 21:44 ` Sinan Kaya
2017-04-17 22:01 ` Sinan Kaya
2017-04-18 1:27 ` Hanjun Guo
2017-04-18 1:30 ` Sinan Kaya
2017-04-18 1:33 ` Hanjun Guo
2017-01-18 12:55 ` [PATCH v8 11/15] ACPI: platform: setup MSI domain for ACPI based platform device Hanjun Guo
2017-01-18 12:55 ` [PATCH v8 12/15] msi: platform: make platform_msi_create_device_domain() ACPI aware Hanjun Guo
2017-01-18 12:55 ` [PATCH v8 13/15] irqchip: mbigen: drop module owner Hanjun Guo
2017-01-18 12:55 ` Hanjun Guo [this message]
2017-01-18 12:55 ` [PATCH v8 15/15] irqchip: mbigen: Add ACPI support Hanjun Guo
2017-02-03 2:27 ` Hanjun Guo
2017-02-03 14:50 ` [PATCH v8 00/15] ACPI platform MSI support and its example mbigen Sinan Kaya
2017-02-03 15:11 ` Marc Zyngier
2017-02-03 15:35 ` Sinan Kaya
2017-02-03 15:49 ` Marc Zyngier
2017-02-03 15:57 ` Sinan Kaya
2017-02-03 16:40 ` Lorenzo Pieralisi
2017-02-03 16:52 ` Sinan Kaya
2017-02-04 3:59 ` Hanjun Guo
2017-02-03 18:36 ` Lorenzo Pieralisi
2017-02-04 7:02 ` Hanjun Guo
2017-02-06 14:22 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484744105-53140-15-git-send-email-guohanjun@huawei.com \
--to=guohanjun@huawei.com \
--cc=agustinv@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=hanjun.guo@linaro.org \
--cc=huxinwei@huawei.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=majun258@huawei.com \
--cc=marc.zyngier@arm.com \
--cc=mbrugger@suse.com \
--cc=okaya@codeaurora.org \
--cc=rafael@kernel.org \
--cc=tglx@linutronix.de \
--cc=tn@semihalf.com \
--cc=tom.leiming@gmail.com \
--cc=wangkefeng.wang@huawei.com \
--cc=xuwei5@hisilicon.com \
--cc=yimin@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).