From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: tpmdd-devel@lists.sourceforge.net,
open list <linux-kernel@vger.kernel.org>,
linux-security-module@vger.kernel.org
Subject: Re: [tpmdd-devel] [PATCH RFC v3 5/5] tpm2: expose resource manager via a device link /dev/tpms<n>
Date: Thu, 19 Jan 2017 07:19:40 -0500 [thread overview]
Message-ID: <1484828380.3140.11.camel@HansenPartnership.com> (raw)
In-Reply-To: <20170119104922.vhgz4rxw6yzdrxqt@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1118 bytes --]
On Thu, 2017-01-19 at 12:49 +0200, Jarkko Sakkinen wrote:
> On Wed, Jan 18, 2017 at 10:01:03AM -0500, James Bottomley wrote:
> > On Mon, 2017-01-16 at 15:12 +0200, Jarkko Sakkinen wrote:
> > > From: James Bottomley <James.Bottomley@HansenPartnership.com>
> > >
> > > Currently the Resource Manager (RM) is not exposed to userspace.
> > > Make this exposure via a separate device, which can now be
> > > opened multiple times because each read/write transaction goes
> > > separately via the RM.
> > >
> > > Concurrency is protected by the chip->tpm_mutex for each
> > > read/write transaction separately. The TPM is cleared of all
> > > transient objects by the time the mutex is dropped, so there
> > > should be no interference between the kernel and userspace.
> >
> > There's actually a missing kfree of context_buf on the tpms_release
> > path as well. This patch fixes it up.
>
> Can you send me a fresh version of the whole patch so that I can
> include to v4 that includes also changes that I requested in my
> recent comments + all the fixes?
Sure, I think the attached is basically it
James
[-- Attachment #2: Type: application/mbox, Size: 9092 bytes --]
next prev parent reply other threads:[~2017-01-19 12:19 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-16 13:12 [PATCH RFC v3 0/5] RFC: in-kernel resource manager Jarkko Sakkinen
2017-01-16 13:12 ` [PATCH RFC v3 1/5] tpm: validate TPM 2.0 commands Jarkko Sakkinen
2017-01-16 13:12 ` [PATCH RFC v3 2/5] tpm: export tpm2_flush_context_cmd Jarkko Sakkinen
2017-01-16 13:12 ` [PATCH RFC v3 3/5] tpm: infrastructure for TPM spaces Jarkko Sakkinen
2017-01-16 13:12 ` [PATCH RFC v3 4/5] tpm: split out tpm-dev.c into tpm-dev.c and tpm-common-dev.c Jarkko Sakkinen
2017-01-16 13:12 ` [PATCH RFC v3 5/5] tpm2: expose resource manager via a device link /dev/tpms<n> Jarkko Sakkinen
2017-01-16 16:14 ` Jason Gunthorpe
2017-01-16 17:24 ` Jarkko Sakkinen
2017-01-16 17:28 ` [tpmdd-devel] " James Bottomley
2017-01-17 7:14 ` Jarkko Sakkinen
2017-01-18 15:01 ` James Bottomley
2017-01-19 10:49 ` Jarkko Sakkinen
2017-01-19 12:19 ` James Bottomley [this message]
2017-01-20 13:39 ` Jarkko Sakkinen
2017-01-20 21:05 ` Jarkko Sakkinen
2017-01-21 19:28 ` James Bottomley
2017-01-22 14:49 ` Jarkko Sakkinen
2017-01-21 20:38 ` James Bottomley
2017-01-22 14:49 ` Jarkko Sakkinen
2017-01-22 17:49 ` James Bottomley
2017-01-22 18:48 ` James Bottomley
2017-01-22 20:30 ` Jarkko Sakkinen
2017-01-22 21:01 ` Jarkko Sakkinen
2017-01-22 21:04 ` Jarkko Sakkinen
2017-01-22 21:36 ` James Bottomley
2017-01-23 14:09 ` Jarkko Sakkinen
2017-01-23 16:14 ` James Bottomley
2017-01-24 12:03 ` Jarkko Sakkinen
2017-01-23 16:58 ` Jarkko Sakkinen
2017-01-23 21:42 ` Jarkko Sakkinen
2017-01-23 22:16 ` James Bottomley
2017-01-25 13:40 ` Jarkko Sakkinen
2017-01-25 13:42 ` Jarkko Sakkinen
2017-01-27 0:29 ` James Bottomley
2017-01-27 6:45 ` Jarkko Sakkinen
2017-01-25 20:23 ` Jarkko Sakkinen
2017-01-22 20:24 ` Jarkko Sakkinen
2017-01-19 10:42 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484828380.3140.11.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).