From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "chaitra.basappa@broadcom.com" <chaitra.basappa@broadcom.com>,
"JBottomley@Parallels.com" <JBottomley@Parallels.com>,
"jejb@kernel.org" <jejb@kernel.org>,
"hch@infradead.org" <hch@infradead.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Sathya.Prakash@broadcom.com" <Sathya.Prakash@broadcom.com>,
"suganath-prabu.subramani@broadcom.com"
<suganath-prabu.subramani@broadcom.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"krishnaraddi.mankani@broadcom.com"
<krishnaraddi.mankani@broadcom.com>,
"kashyap.desai@broadcom.com" <kashyap.desai@broadcom.com>,
"sreekanth.reddy@broadcom.com" <sreekanth.reddy@broadcom.com>
Subject: Re: [PATCH 2/4] mpt3sas: Fix for Crusader to achieve product targets with SAS devices.
Date: Thu, 19 Jan 2017 16:05:38 +0000 [thread overview]
Message-ID: <1484841924.2634.1.camel@sandisk.com> (raw)
In-Reply-To: <1484840950-13656-3-git-send-email-chaitra.basappa@broadcom.com>
On Thu, 2017-01-19 at 21:19 +0530, Chaitra P B wrote:
> diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
> index 5ffbfb1..b3f9f7a 100644
> --- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c
> +++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
> @@ -1096,6 +1096,27 @@ _scsih_scsi_lookup_get_clear(struct MPT3SAS_ADAPTER *ioc, u16 smid)
> }
>
> /**
> + * _scsih_scsi_lookup_get_clear_without_lock - returns scmd entry without
> + * holding any lock.
> + * @ioc: per adapter object
> + * @smid: system request message index
> + *
> + * Returns the smid stored scmd pointer.
> + * Then will derefrence the stored scmd pointer.
> + */
> +static inline struct scsi_cmnd *
> +_scsih_scsi_lookup_get_clear_without_lock(struct MPT3SAS_ADAPTER *ioc,
> + u16 smid)
> +{
> + struct scsi_cmnd *scmd;
> +
> + scmd = ioc->scsi_lookup[smid - 1].scmd;
> + ioc->scsi_lookup[smid - 1].scmd = NULL;
> +
> + return scmd;
> +}
Please make the following changes in the above code:
* Use swap() instead of open-coding it.
* Call _scsih_scsi_lookup_get_clear_without_lock() from
_scsih_scsi_lookup_get_clear() to avoid code duplication.
* Fix the spelling of "dereference".
Thanks,
Bart.
next prev parent reply other threads:[~2017-01-19 16:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 15:49 [PATCH 0/4] mpt3sas driver Enhancements and Chaitra P B
2017-01-19 15:49 ` [PATCH 1/4] mpt3sas: Added print to notify cable running at a degraded speed Chaitra P B
2017-01-20 8:51 ` Johannes Thumshirn
2017-01-19 15:49 ` [PATCH 2/4] mpt3sas: Fix for Crusader to achieve product targets with SAS devices Chaitra P B
2017-01-19 16:05 ` Bart Van Assche [this message]
2017-01-19 15:49 ` [PATCH 3/4] mpt3sas: Fix Firmware fault state 0x2100 during heavy 4K RR FIO stress test Chaitra P B
2017-01-19 15:49 ` [PATCH 4/4] mpt3sas: Bump driver version to 15.100.00.00 Chaitra P B
2017-01-20 8:53 ` [PATCH 0/4] mpt3sas driver Enhancements and Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484841924.2634.1.camel@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=JBottomley@Parallels.com \
--cc=Sathya.Prakash@broadcom.com \
--cc=chaitra.basappa@broadcom.com \
--cc=hch@infradead.org \
--cc=jejb@kernel.org \
--cc=kashyap.desai@broadcom.com \
--cc=krishnaraddi.mankani@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sreekanth.reddy@broadcom.com \
--cc=suganath-prabu.subramani@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).