linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guochun Mao <guochun.mao@mediatek.com>
To: Rob Herring <robh@kernel.org>,
	Boris Brezillon <boris.brezillon@free-electrons.com>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	Marek Vasut <marek.vasut@gmail.com>,
	Matthias Brugger <matthias.bgg@gmail.com>
Cc: "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	Mark Rutland <mark.rutland@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Richard Weinberger <richard@nod.at>,
	"Russell King" <linux@armlinux.org.uk>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	Cyrille Pitchen <cyrille.pitchen@atmel.com>,
	Brian Norris <computersforpeace@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH v1 2/2] arm: dts: mt2701: add nor flash node
Date: Sun, 22 Jan 2017 10:36:40 +0800	[thread overview]
Message-ID: <1485052600.19995.10.camel@mhfsdcap03> (raw)
In-Reply-To: <CAL_Jsq+S-FYy4SmjJ3fWzBugw2zCj5TQkkfUA8QVL7SLJW3E1g@mail.gmail.com>

Hi,
On Thu, 2017-01-19 at 08:18 -0600, Rob Herring wrote:
> On Thu, Jan 19, 2017 at 2:14 AM, Boris Brezillon
> > One last question and I'm done: is something like that acceptable?
> >
> >         compatible = "<vendor>,<old-soc>","<vendor>,<new-soc>";
> >
> > This can happen when someone adds support for an unsupported feature
> > on a brand new SoC, and then someone else use the same driver for an
> > older SoC embedding the same IP but still wants to add a new compatible
> > just in case these 2 IPs appear to be slightly different.
> 
> Yes, it's old and new compatible strings in this case and it's newest
> compatible string first.
> 
> > Here the order of compat strings is no longer following a clear rule
> > like 'most-specific compatible first' or 'newest IP/SoC version first',
> > it's completely dependent on the order these IPs were supported in the
> > OS (Linux). I'm perfectly fine with that BTW, just want to make sure
> > this is authorized.
> 
> I guess we should say "newest compatible for IP first" instead. There
> are some exceptions where we add fallbacks later on, but that falls
> under the most-specific part.
> 
> It's order that the bindings are defined, not Linux support really,
> but in practice those are the same.
> 
> Rob

Thanks for all your effort for code reviewing.
Our mt2701-nor's hardware is designed base on mt8713-nor,
even so, there would be some slight difference.
If I don't misunderstand your viewpoint in this discussion,
there's no need to drop mt2701-nor compatible.
And if not, is there any other suggestion?

Thanks.

  reply	other threads:[~2017-01-22  2:36 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-13  7:13 [PATCH v1 0/2] add nor flash node for mt2701 Guochun Mao
2017-01-13  7:13 ` [PATCH v1 1/2] Documentation: mtk-quadspi: update DT bindings Guochun Mao
2017-01-13 14:13   ` Boris Brezillon
2017-01-18 22:08     ` Rob Herring
2017-01-13  7:13 ` [PATCH v1 2/2] arm: dts: mt2701: add nor flash node Guochun Mao
2017-01-13 12:49   ` Marek Vasut
2017-01-13 14:17   ` Boris Brezillon
2017-01-13 15:12     ` Matthias Brugger
2017-01-13 15:21       ` Boris Brezillon
2017-01-13 16:13       ` Marek Vasut
2017-01-13 16:28         ` Boris Brezillon
2017-01-13 16:44           ` Marek Vasut
2017-01-13 16:56             ` Boris Brezillon
2017-01-13 17:33               ` Marek Vasut
2017-01-14  8:29                 ` Boris Brezillon
2017-01-15  0:23                   ` Marek Vasut
2017-01-16  8:40                     ` Boris Brezillon
2017-01-16 16:09                       ` Marek Vasut
2017-01-17  3:36                       ` Thomas Petazzoni
2017-01-18 22:20                         ` Rob Herring
2017-01-18 23:38                           ` Thomas Petazzoni
2017-01-19  2:51                             ` Rob Herring
2017-01-19  8:14                               ` Boris Brezillon
2017-01-19 14:18                                 ` Rob Herring
2017-01-22  2:36                                   ` Guochun Mao [this message]
2017-01-24 10:31                                     ` Boris Brezillon
2017-01-24 10:38                                       ` John Crispin
2017-01-19  7:53                           ` Boris Brezillon
2017-01-17  3:32               ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1485052600.19995.10.camel@mhfsdcap03 \
    --to=guochun.mao@mediatek.com \
    --cc=boris.brezillon@free-electrons.com \
    --cc=computersforpeace@gmail.com \
    --cc=cyrille.pitchen@atmel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux@armlinux.org.uk \
    --cc=marek.vasut@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=richard@nod.at \
    --cc=robh@kernel.org \
    --cc=thomas.petazzoni@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).