From: Eric Dumazet <eric.dumazet@gmail.com>
To: Hayes Wang <hayeswang@realtek.com>
Cc: netdev@vger.kernel.org, nic_swsd@realtek.com,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH net v2 3/4] r8152: re-schedule napi for tx
Date: Wed, 25 Jan 2017 05:57:17 -0800 [thread overview]
Message-ID: <1485352637.5145.4.camel@edumazet-glaptop3.roam.corp.google.com> (raw)
In-Reply-To: <1394712342-15778-245-Taiwan-albertk@realtek.com>
On Wed, 2017-01-25 at 16:13 +0800, Hayes Wang wrote:
> Re-schedule napi after napi_complete() for tx, if it is necessay.
>
> In r8152_poll(), if the tx is completed after tx_bottom() and before
> napi_complete(), the scheduling of napi would be lost. Then, no
> one handles the next tx until the next napi_schedule() is called.
>
> Signed-off-by: Hayes Wang <hayeswang@realtek.com>
> ---
> drivers/net/usb/r8152.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
> index ec882be..45d168e 100644
> --- a/drivers/net/usb/r8152.c
> +++ b/drivers/net/usb/r8152.c
> @@ -1936,6 +1936,9 @@ static int r8152_poll(struct napi_struct *napi, int budget)
> napi_complete(napi);
> if (!list_empty(&tp->rx_done))
> napi_schedule(napi);
> + else if (!skb_queue_empty(&tp->tx_queue) &&
> + !list_empty(&tp->tx_free))
> + napi_schedule(&tp->napi);
Why using &tp->napi instead of napi here, as done 3 lines above ?
next prev parent reply other threads:[~2017-01-25 13:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 2:50 [PATCH net 0/4] r8152: fix scheduling napi Hayes Wang
2017-01-25 2:50 ` [PATCH net 1/4] r8152: avoid start_xmit to call napi_schedule during autosuspend Hayes Wang
2017-01-25 5:02 ` Stephen Hemminger
2017-01-25 2:50 ` [PATCH net 2/4] r8152: avoid start_xmit to schedule napi when napi is disabled Hayes Wang
2017-01-25 2:50 ` [PATCH net 3/4] r8152: re-schedule napi for tx Hayes Wang
2017-01-25 2:50 ` [PATCH net 4/4] r8152: check rx after napi is enabled Hayes Wang
2017-01-25 8:13 ` [PATCH net v2 0/4] r8152: fix scheduling napi Hayes Wang
2017-01-25 8:13 ` [PATCH net v2 1/4] r8152: avoid start_xmit to call napi_schedule during autosuspend Hayes Wang
2017-01-25 8:13 ` [PATCH net v2 2/4] r8152: avoid start_xmit to schedule napi when napi is disabled Hayes Wang
2017-01-25 8:13 ` [PATCH net v2 3/4] r8152: re-schedule napi for tx Hayes Wang
2017-01-25 13:57 ` Eric Dumazet [this message]
2017-01-26 1:22 ` Hayes Wang
2017-01-25 8:13 ` [PATCH net v2 4/4] r8152: check rx after napi is enabled Hayes Wang
2017-01-25 19:31 ` [PATCH net v2 0/4] r8152: fix scheduling napi David Miller
2017-01-26 3:04 ` Hayes Wang
2017-01-26 3:46 ` David Miller
2017-01-26 1:38 ` [PATCH net v3 " Hayes Wang
2017-01-26 1:38 ` [PATCH net v3 1/4] r8152: avoid start_xmit to call napi_schedule during autosuspend Hayes Wang
2017-01-26 1:38 ` [PATCH net v3 2/4] r8152: avoid start_xmit to schedule napi when napi is disabled Hayes Wang
2017-01-26 1:38 ` [PATCH net v3 3/4] r8152: re-schedule napi for tx Hayes Wang
2017-01-26 1:38 ` [PATCH net v3 4/4] r8152: check rx after napi is enabled Hayes Wang
2017-01-26 3:47 ` [PATCH net v3 0/4] r8152: fix scheduling napi David Miller
2017-01-26 3:52 ` Hayes Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485352637.5145.4.camel@edumazet-glaptop3.roam.corp.google.com \
--to=eric.dumazet@gmail.com \
--cc=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).