From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753258AbdAZJfs (ORCPT ); Thu, 26 Jan 2017 04:35:48 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:35325 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751774AbdAZJfp (ORCPT ); Thu, 26 Jan 2017 04:35:45 -0500 From: Taeung Song To: Arnaldo Carvalho de Melo Cc: linux-kernel@vger.kernel.org, Jiri Olsa , Namhyung Kim , Ingo Molnar , Peter Zijlstra , Wang Nan , Taeung Song Subject: [PATCH 1/3] perf ftrace: Remove needless code setting default tracer Date: Thu, 26 Jan 2017 18:35:37 +0900 Message-Id: <1485423339-22780-1-git-send-email-treeze.taeung@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Lately commit a349764 made 'function_graph' be the default tracer. So ftrace.tracer variable can't be NULL but the other code setting default tracer remained. For this reason, remove it as below. And use existing DEFAULT_TRACER instead of "function_graph". Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Taeung Song --- tools/perf/builtin-ftrace.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tools/perf/builtin-ftrace.c b/tools/perf/builtin-ftrace.c index d05658d..414444d 100644 --- a/tools/perf/builtin-ftrace.c +++ b/tools/perf/builtin-ftrace.c @@ -202,7 +202,7 @@ int cmd_ftrace(int argc, const char **argv, const char *prefix __maybe_unused) { int ret; struct perf_ftrace ftrace = { - .tracer = "function_graph", + .tracer = DEFAULT_TRACER, .target = { .uid = UINT_MAX, }, }; const char * const ftrace_usage[] = { @@ -231,9 +231,6 @@ int cmd_ftrace(int argc, const char **argv, const char *prefix __maybe_unused) if (ret < 0) goto out_delete_evlist; - if (ftrace.tracer == NULL) - ftrace.tracer = DEFAULT_TRACER; - ret = __cmd_ftrace(&ftrace, argc, argv); out_delete_evlist: -- 2.7.4