From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751401AbdA0VAg (ORCPT ); Fri, 27 Jan 2017 16:00:36 -0500 Received: from s3.sipsolutions.net ([5.9.151.49]:37140 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751272AbdA0VA2 (ORCPT ); Fri, 27 Jan 2017 16:00:28 -0500 Message-ID: <1485550820.14579.2.camel@sipsolutions.net> Subject: Re: [PATCH] cfg80211 debugfs: Cleanup some checkpatch issues From: Johannes Berg To: Pichugin Dmitry , davem@davemloft.net Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 27 Jan 2017 22:00:20 +0100 In-Reply-To: <20170127192603.GA13522@gmail.com> (sfid-20170127_203712_578214_221D21FF) References: <20170127192603.GA13522@gmail.com> (sfid-20170127_203712_578214_221D21FF) Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.2-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-01-27 at 22:26 +0300, Pichugin Dmitry wrote: > This fixes the checkpatch.pl warnings: > * Macros should not use a trailing semicolon. > * Spaces required around that '='. > * Symbolic permissions 'S_IRUGO' are not preferred. > * Macro argument reuse 'buflen' - possible side-effects I really see no point in any of this. johannes