From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751464AbdA0VMP (ORCPT ); Fri, 27 Jan 2017 16:12:15 -0500 Received: from smtprelay0124.hostedemail.com ([216.40.44.124]:41474 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750839AbdA0VKo (ORCPT ); Fri, 27 Jan 2017 16:10:44 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:1801:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3868:3870:3874:4321:4605:5007:7875:7974:10004:10400:10848:11026:11232:11473:11658:11914:12043:12438:12740:12760:12895:13069:13141:13230:13311:13357:13439:14096:14097:14181:14659:14721:21080:21325,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:5,LUA_SUMMARY:none X-HE-Tag: ring41_404747083e052 X-Filterd-Recvd-Size: 1918 Message-ID: <1485551440.12563.140.camel@perches.com> Subject: Re: [PATCH] cfg80211 debugfs: Cleanup some checkpatch issues From: Joe Perches To: Johannes Berg , Pichugin Dmitry , davem@davemloft.net Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 27 Jan 2017 13:10:40 -0800 In-Reply-To: <1485550820.14579.2.camel@sipsolutions.net> References: <20170127192603.GA13522@gmail.com> (sfid-20170127_203712_578214_221D21FF) <1485550820.14579.2.camel@sipsolutions.net> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-01-27 at 22:00 +0100, Johannes Berg wrote: > On Fri, 2017-01-27 at 22:26 +0300, Pichugin Dmitry wrote: > > This fixes the checkpatch.pl warnings: > > * Macros should not use a trailing semicolon. > > * Spaces required around that '='. > > * Symbolic permissions 'S_IRUGO' are not preferred. > > * Macro argument reuse 'buflen' - possible side-effects > > I really see no point in any of this. Look at the uses of DEBUGFS_READONLY_FILE and see if they are consistent before and after. DEBUGFS_READONLY_FILE(rts_threshold, 20, "%d", - wiphy->rts_threshold) + wiphy->rts_threshold); DEBUGFS_READONLY_FILE(fragmentation_threshold, 20, "%d", wiphy->frag_threshold); DEBUGFS_READONLY_FILE(short_retry_limit, 20, "%d", - wiphy->retry_short) + wiphy->retry_short); DEBUGFS_READONLY_FILE(long_retry_limit, 20, "%d", wiphy->retry_long);