From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752092AbdA3EsF (ORCPT ); Sun, 29 Jan 2017 23:48:05 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:45524 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751523AbdA3ErY (ORCPT ); Sun, 29 Jan 2017 23:47:24 -0500 X-AuditID: b6c32a49-f79e16d000001a35-f4-588ec545e3ab From: Shailendra Verma To: Boris Brezillon , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , Cyrille Pitchen , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, p.shailesh@samsung.com, ashish.kalra@samsung.com, Shailendra Verma , Shailendra Verma Subject: [PATCH] Mtd: nand - Fix possible NULL derefrence. Date: Mon, 30 Jan 2017 10:16:52 +0530 Message-id: <1485751612-28915-1-git-send-email-shailendra.v@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrDIsWRmVeSWpSXmKPExsWy7bCmma7r0b4IgxP3RSzuT/vGbnHgxUIW iyMX1jJb3Pt+ntli4srJzBaXd81hs9jdtIzd4uiee8wWO6a0slhM3vmG0eLWvJlsFou+vWJ2 4PFY8Gsri8eTTRcZPXbOusvusXmFlsfmJfUeN+cVevRtWcXo8XmTXABHFJdNSmpOZllqkb5d AlfG3Ovz2Av+c1a8ufqdqYFxNUcXIyeHhICJxLMNF5khbDGJC/fWs3UxcnEICexglPh3+xWU 85lRon/hajaYjnWbLjBCJFYyStyY0skOkmATMJR43feXCSQhInCXWeLG6/1MIAlhASuJ811b GUFsFgFVicb/c8DivAIeEnN+/QSaygE0VUFiziQbkF4Jge9sEjuPrWSFiMtKbDoAdZ6LxKR/ N9khbGGJV8e3QNlSEq92XGOG6D3GKPH4+WImCOcyo8SW08ugquwlrt16DWYzC/BJdBz+yw6x gFeio00IosRDovnwHahljhLnPkxnAbGFBGIlNk6ezTiBUXIBI8MqRrHUguLc9NRiowJTveLE 3OLSvHS95PzcTYzgONby3ME465zPIUYBDkYlHt4Fh/sihFgTy4orcw8xSnAwK4nwlu8ECvGm JFZWpRblxxeV5qQWH2KU5mBREueVWG8dISSQnliSmp2aWpBaBJNl4uCUamBc+vx+6l/tr9Ut STsCl611UX/z9OPxUPGEsvV3DX6oFpb/3iMutSOi5/DxHe8EeUODmPirHFY9u2/xsl3RIL5q jUBxcsKF90uuRr33WVnzavJ2masc7EvZnmbLX9586eanJIGFZi+UXP1qI1yeN+YK/oljDjus Uuhuv/LaLvfNP69dn5P0hNNFiaU4I9FQi7moOBEAOTNA4d8CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrPLMWRmVeSWpSXmKPExsWSnbNCVdf1aF+Ewak5LBb3p31jtzjwYiGL xZELa5kt7n0/z2wxceVkZovLu+awWexuWsZucXTPPWaLHVNaWSwm73zDaHFr3kw2i0XfXjE7 8Hgs+LWVxePJpouMHjtn3WX32LxCy2PzknqPm/MKPfq2rGL0+LxJLoAjys0mIzUxJbVIITUv OT8lMy/dVik0xE3XQkkhLzE31VYpQtc3JEhJoSwxpxTIMzJAAw7OAe7BSvp2CW4Zc6/PYy/4 z1nx5up3pgbG1RxdjJwcEgImEus2XWCEsMUkLtxbz9bFyMUhJLCcUeLhrXZWkASbgKHE676/ TCAJEYHnzBIT/twE6xAWsJI437UVzGYRUJVo/D+HCcTmFfCQmPPrJ9AkDqCpChJzJtlMYORc wMiwilEstaA4Nz23uMDASK84Mbe4NC9dLzk/dxMjMHC3HVYS38E4a4XXIUYBDkYlHl6LjL4I IdbEsuLK3EOMEhzMSiK85TuBQrwpiZVVqUX58UWlOanFhxhNgbZPZJYSTc4HRlVeSbyhiamF hYWJpbGxsYWJkjhv7PRn4UIC6YklqdmpqQWpRTB9TBycUg2McUEtr+52axp6ZPuLNu9975z9 3t6j3vHIgZVeRQadsjbOblvlj+X0zymcv2DOy7il76fktbZ84Cr6ttWS42uHz6bgzdEdHN67 AjW5X5S3HPuvm7FkJb/x5Ocn3/I4mbFkCa3nd90eURgu68RmU/33QG79nflFvwvtP/U62ucq q0zpWcPf6q3EUpyRaKjFXFScCAA2UxFQcgIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170130044701epcas2p327897c254334e190e982c208de1c034c X-Msg-Generator: CA X-Sender-IP: 182.195.34.23 X-Local-Sender: =?UTF-8?B?U2hhaWxlbmRyYSBWZXJtYRtTUkktTm9pZGEtQ29tbWVyY2lh?= =?UTF-8?B?bCBSJkQgIFN5c3RlbSBTL1cgR3JvdXAb7IK87ISx7KCE7J6QG0xlYWQgRW5n?= =?UTF-8?B?aW5lZXIvQ29ycG9yYXRlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?U2hhaWxlbmRyYSBWZXJtYRtTUkktTm9pZGEtQ29tbWVyY2lh?= =?UTF-8?B?bCBSJkQgIFN5c3RlbSBTL1cgR3JvdXAbU2Ftc3VuZyBFbGVjdHJvbmljcxtM?= =?UTF-8?B?ZWFkIEVuZ2luZWVyL0NvcnBvcmF0ZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1NXQUhRG0MxMElaMDFJWjAxODEyMA==?= CMS-TYPE: 102P X-HopCount: 7 X-CMS-RootMailID: 20170130044701epcas2p327897c254334e190e982c208de1c034c X-RootMTR: 20170130044701epcas2p327897c254334e190e982c208de1c034c References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org of_match_device could return NULL, and so can cause a NULL pointer dereference later. Signed-off-by: Shailendra Verma --- drivers/mtd/nand/mxc_nand.c | 4 ++++ drivers/mtd/nand/vf610_nfc.c | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c index d7f724b..ca1b8ad 100644 --- a/drivers/mtd/nand/mxc_nand.c +++ b/drivers/mtd/nand/mxc_nand.c @@ -1596,6 +1596,10 @@ static int __init mxcnd_probe_dt(struct mxc_nand_host *host) if (!np) return 1; + if (!of_id) { + dev_err(host->dev, "Error: No device match found\n"); + return -ENODEV; + } host->devtype_data = of_id->data; return 0; diff --git a/drivers/mtd/nand/vf610_nfc.c b/drivers/mtd/nand/vf610_nfc.c index 3ad514c..0e09c11 100644 --- a/drivers/mtd/nand/vf610_nfc.c +++ b/drivers/mtd/nand/vf610_nfc.c @@ -674,6 +674,10 @@ static int vf610_nfc_probe(struct platform_device *pdev) } of_id = of_match_device(vf610_nfc_dt_ids, &pdev->dev); + if (!of_id) { + dev_err(&pdev->dev, "Error: No device match found\n"); + return -ENODEV; + } nfc->variant = (enum vf610_nfc_variant)of_id->data; for_each_available_child_of_node(nfc->dev->of_node, child) { -- 1.7.9.5