From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752047AbdA3GFv (ORCPT ); Mon, 30 Jan 2017 01:05:51 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:48562 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751032AbdA3GFp (ORCPT ); Mon, 30 Jan 2017 01:05:45 -0500 X-AuditID: b6c32a10-f79d26d00000132e-2d-588ec669f68d From: Shailendra Verma To: Linus Walleij , Laxman Dewangan , Thomas Petazzoni , Andreas Klinger , Sebastian Hesselbarth , Andrew Lunn , Jamie Lentin , Rob Herring , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, p.shailesh@samsung.com, ashish.kalra@samsung.com, Shailendra Verma , Shailendra Verma Subject: [PATCH] Pinctrl: mvebu - Fix possible NULL derefrence. Date: Mon, 30 Jan 2017 10:21:43 +0530 Message-id: <1485751903-29284-1-git-send-email-shailendra.v@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrAIsWRmVeSWpSXmKPExsWy7bCmsG7Wsb4IgzurWC0ap21htzh/9xCz xf1p39gt3nZMYLZYum81i8WUP8uZLDbP/8NocXnXHDaLHVNaWSz+79nBbvH+p6PFrXkz2SwW fXvFbPH0QROTA5/Hk00XGT12zrrL7jHh2y12j02rOtk8bs7ay+px59oeNo+dOz4zefQ2v2Pz 6NuyitHj8ya5AK4oLpuU1JzMstQifbsEroxD348wFrQJVjSeesLcwHicr4uRg0NCwETiz1XX LkZOIFNM4sK99WxdjFwcQgJLGSXenfzACuF8ZpTYu3k5K0zD100eEPGVjBK/5j9hBelmEzCU eN33lwkkISKwiEXi5fXFYAlhAXuJKwd+s4PYLAKqEt/fdYDFeQU8JNa9fwQ1VEFiziQbkF4J gXnsElvW3mGBiMtKbDrADHGdi8TdW9ugbGGJV8e3sEPYUhJNt0+xQPQeY5R4/HwxE4RzmVFi y+llUFX2EtduvQazmQX4JBavf8AGsYBXoqNNCKLEQ+Llst1sELajxPH9DYwgtpBArMS0c9eZ JjBKLmBkWMUollpQnJueWmxcYKRXnJhbXJqXrpecn7uJERzvWgI7GKes8DrEKMDBqMTD++No X4QQa2JZcWXuIUYJDmYlEd7ynUAh3pTEyqrUovz4otKc1OJDjNIcLErivB8rrSOEBNITS1Kz U1MLUotgskwcnFINjJky93vD9uuy6+hUzTIWTSoKV9u8KmmqVIiI06vCGwtv+X03578clveK 5bXuDLP0TfJBKd0aC59Lxmzcscza+404P//dPeoP9fJeXYnRfsbncvwQT2fGxFiO2bEPI/u3 7Hcr9NnK12Z1d+OnFcoHnvrfeMP1SFS2zM3jeSxX3cVJ1qvuX/O6p8RSnJFoqMVcVJwIACbA t+bzAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrCLMWRmVeSWpSXmKPExsWSnbNCVTfzWF+EwY3TehaN07awW5y/e4jZ 4v60b+wWbzsmMFss3beaxWLKn+VMFpvn/2G0uLxrDpvFjimtLBb/9+xgt3j/09Hi1ryZbBaL vr1itnj6oInJgc/jyaaLjB47Z91l95jw7Ra7x6ZVnWweN2ftZfW4c20Pm8fOHZ+ZPHqb37F5 9G1ZxejxeZNcAFeUm01GamJKapFCal5yfkpmXrqtUmiIm66FkkJeYm6qrVKErm9IkJJCWWJO KZBnZIAGHJwD3IOV9O0S3DIOfT/CWNAmWNF46glzA+Nxvi5GDg4JAROJr5s8uhg5gUwxiQv3 1rN1MXJxCAksZ5Q4fGspO0iCTcBQ4nXfXyaQhIjAGhaJWZvXsoEkhAXsJa4c+A1WxCKgKvH9 XQcriM0r4CGx7v0jVogFChJzJtlMYORcwMiwilEstaA4Nz23uMDAWK84Mbe4NC9dLzk/dxMj MMS3HVaS2MG4YIXXIUYBDkYlHt4fR/sihFgTy4orcw8xSnAwK4nwlu8ECvGmJFZWpRblxxeV 5qQWH2I0Bdo+kVlKNDkfGH95JfGGJqYWFhYmlsbGxhYmSuK8sdOfhQsJpCeWpGanphakFsH0 MXFwSjUw7jh3dJKZy88M54gdsSkxApw71spptTdM32pZPY3xuGpTuJnyscLQFX51F2UP/dsl JCjz7I9NyuZ9//l3RF9m/HtF7c7f50VZS510f97Kqj+5frbC1IJHVxsyIt6oenB+PqR22jZs RtfUrCL2d55H5r5+/GzWEefral9vseVN2Ch+d1bIzHv3byixFGckGmoxFxUnAgDW1w9FhwIA AA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170130045153epcas3p37f0c1815f13d6701dd4da3c50c54b35a X-Msg-Generator: CA X-Sender-IP: 182.195.34.24 X-Local-Sender: =?UTF-8?B?U2hhaWxlbmRyYSBWZXJtYRtTUkktTm9pZGEtQ29tbWVyY2lh?= =?UTF-8?B?bCBSJkQgIFN5c3RlbSBTL1cgR3JvdXAb7IK87ISx7KCE7J6QG0xlYWQgRW5n?= =?UTF-8?B?aW5lZXIvQ29ycG9yYXRlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?U2hhaWxlbmRyYSBWZXJtYRtTUkktTm9pZGEtQ29tbWVyY2lh?= =?UTF-8?B?bCBSJkQgIFN5c3RlbSBTL1cgR3JvdXAbU2Ftc3VuZyBFbGVjdHJvbmljcxtM?= =?UTF-8?B?ZWFkIEVuZ2luZWVyL0NvcnBvcmF0ZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1NXQUhRG0MxMElaMDFJWjAxODEyMA==?= CMS-TYPE: 103P X-HopCount: 7 X-CMS-RootMailID: 20170130045153epcas3p37f0c1815f13d6701dd4da3c50c54b35a X-RootMTR: 20170130045153epcas3p37f0c1815f13d6701dd4da3c50c54b35a References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org of_match_device could return NULL, and so can cause a NULL pointer dereference later. Signed-off-by: Shailendra Verma --- drivers/pinctrl/mvebu/pinctrl-dove.c | 4 ++++ drivers/pinctrl/mvebu/pinctrl-kirkwood.c | 4 ++++ drivers/pinctrl/mvebu/pinctrl-orion.c | 4 ++++ 3 files changed, 12 insertions(+) diff --git a/drivers/pinctrl/mvebu/pinctrl-dove.c b/drivers/pinctrl/mvebu/pinctrl-dove.c index f93ae0d..f9fe6d4 100644 --- a/drivers/pinctrl/mvebu/pinctrl-dove.c +++ b/drivers/pinctrl/mvebu/pinctrl-dove.c @@ -769,6 +769,10 @@ static int dove_pinctrl_probe(struct platform_device *pdev) struct resource fb_res; const struct of_device_id *match = of_match_device(dove_pinctrl_of_match, &pdev->dev); + if (!match) { + dev_err(&pdev->dev, "Error: No device match found\n"); + return -ENODEV; + } pdev->dev.platform_data = (void *)match->data; /* diff --git a/drivers/pinctrl/mvebu/pinctrl-kirkwood.c b/drivers/pinctrl/mvebu/pinctrl-kirkwood.c index 5f89c26..75efb83 100644 --- a/drivers/pinctrl/mvebu/pinctrl-kirkwood.c +++ b/drivers/pinctrl/mvebu/pinctrl-kirkwood.c @@ -472,6 +472,10 @@ static int kirkwood_pinctrl_probe(struct platform_device *pdev) struct resource *res; const struct of_device_id *match = of_match_device(kirkwood_pinctrl_of_match, &pdev->dev); + if (!match) { + dev_err(&pdev->dev, "Error: No device match found\n"); + return -ENODEV; + } pdev->dev.platform_data = (void *)match->data; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); diff --git a/drivers/pinctrl/mvebu/pinctrl-orion.c b/drivers/pinctrl/mvebu/pinctrl-orion.c index 84e1441..559ac32 100644 --- a/drivers/pinctrl/mvebu/pinctrl-orion.c +++ b/drivers/pinctrl/mvebu/pinctrl-orion.c @@ -225,6 +225,10 @@ static int orion_pinctrl_probe(struct platform_device *pdev) of_match_device(orion_pinctrl_of_match, &pdev->dev); struct resource *res; + if (!match) { + dev_err(&pdev->dev, "Error: No device match found\n"); + return -ENODEV; + } pdev->dev.platform_data = (void*)match->data; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); -- 1.7.9.5