From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751995AbdA3EyB (ORCPT ); Sun, 29 Jan 2017 23:54:01 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:58050 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750850AbdA3Exn (ORCPT ); Sun, 29 Jan 2017 23:53:43 -0500 X-AuditID: b6c32a39-f79c86d000001a4c-79-588ec699dba2 From: Shailendra Verma To: Thierry Reding , Maxime Ripard , Chen-Yu Tsai , Stephen Warren , Alexandre Courbot , linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, p.shailesh@samsung.com, ashish.kalra@samsung.com, Shailendra Verma , Shailendra Verma Subject: [PATCH] pwm - Fix possible NULL derefrence. Date: Mon, 30 Jan 2017 10:22:33 +0530 Message-id: <1485751953-29341-1-git-send-email-shailendra.v@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrDIsWRmVeSWpSXmKPExsWy7bCmge6sY30RBmceMFrcn/aN3eLcq0cs FpseX2O1uLxrDpvF3burGC06v8xis9i6aS+zxY4prSwWt+bNZLNY9O0Vs8Wrg20sFj93zQMS h84zOfB6bHi0mtXjyaaLjB47Z91l99i8pN6jb8sqRo/Pm+Q8Ns4NDWCP4rJJSc3JLEst0rdL 4Mq4+OEZW0EPV8WdT2tZGhg3cXQxcnJICJhILFz0mgnCFpO4cG89WxcjF4eQwA5GiT3/bjFB OJ8ZJdoXNLLAdHz+sA2sQ0hgJaPEjUUJIDabgKHE676/YA0iAs+ZJX53N4M1CAM17Pi/jxXE ZhFQlbhx9Rc7iM0r4CEx48FJoDgH0FAFiTmTbEB6JQQ+s0l0bv7EBBGXldh0gBlir4vEhzUX oWxhiVfHt7BD2FISzR8/sEL0HmOUePx8MROEc5lRYsvpZVBV9hLXbr0Gs5kF+CTefe2BWswr 0dEmBFHiIbG54Q4rhO0oseTJJ0aIJ2MlLlw9wDaBUXIBI8MqRrHUguLc9NRiwwJTveLE3OLS vHS95PzcTYzgONay3MF47JzPIUYBDkYlHt4bwn0RQqyJZcWVuYcYJTiYlUR4y3cChXhTEiur Uovy44tKc1KLDzFKc7AoifMubrSOEBJITyxJzU5NLUgtgskycXBKNTCultt8T2uV+9JGjTaN lIsLvy23urYpyH/NjpvzTXdcvLDsQTRvueVN38JdskpcvkK7akICry62ZvfmYTAX5FjwxMDY 5ETe4bIXHK08N3/Hnz8Q3LNl0rzAHCtR/w0Hdm6vl5fUdlw1kTt10xnml//7Djd192nu3z9v bThTSUNbV9XxHWvf/vuqxFKckWioxVxUnAgARyZXPN8CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrPLMWRmVeSWpSXmKPExsWSnbNCVXfmsb4Ig3v/tC3uT/vGbnHu1SMW i02Pr7FaXN41h83i7t1VjBadX2axWWzdtJfZYseUVhaLW/Nmslks+vaK2eLVwTYWi5+75gGJ Q+eZHHg9NjxazerxZNNFRo+ds+6ye2xeUu/Rt2UVo8fnTXIeG+eGBrBHudlkpCampBYppOYl 56dk5qXbKoWGuOlaKCnkJeam2ipF6PqGBCkplCXmlAJ5RgZowME5wD1YSd8uwS3j4odnbAU9 XBV3Pq1laWDcxNHFyMkhIWAi8fnDNiYIW0ziwr31bCC2kMByRonVB9NBbDYBQ4nXfX+Barg4 RAQ+MkvsX7OSBSQhDNS84/8+VhCbRUBV4sbVX+wgNq+Ah8SMByeB4hxAQxUk5kyymcDIuYCR YRWjWGpBcW56bnGBgaFecWJucWleul5yfu4mRmDgbjusJLaDsW2F1yFGAQ5GJR5egzV9EUKs iWXFlbmHGCU4mJVEeMt3AoV4UxIrq1KL8uOLSnNSiw8xmgJtn8gsJZqcD4yqvJJ4QxNTCwsL E0tjY2MLEyVx3tjpz8KFBNITS1KzU1MLUotg+pg4OKUaGLtV9jxdfnWNz4GQOlvXFs52vUbF Japhk9QazKwY8oOupPC1n1rXdvo/y73grMr5vp4Pr55ZoDkrs5zj6KwZjz9ue30uQ15ua1qo zcKPlgvblV0+t3NcCVTb75gubbR3iWiSX7XZ+/pVaoqh8yasull6JfGWU0Axz7v3RRN/hK6w rPrh27/tmhJLcUaioRZzUXEiAJDf1v1yAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170130045241epcas1p2a5a0625327e4caab59236ec85551f95e X-Msg-Generator: CA X-Sender-IP: 182.195.34.22 X-Local-Sender: =?UTF-8?B?U2hhaWxlbmRyYSBWZXJtYRtTUkktTm9pZGEtQ29tbWVyY2lh?= =?UTF-8?B?bCBSJkQgIFN5c3RlbSBTL1cgR3JvdXAb7IK87ISx7KCE7J6QG0xlYWQgRW5n?= =?UTF-8?B?aW5lZXIvQ29ycG9yYXRlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?U2hhaWxlbmRyYSBWZXJtYRtTUkktTm9pZGEtQ29tbWVyY2lh?= =?UTF-8?B?bCBSJkQgIFN5c3RlbSBTL1cgR3JvdXAbU2Ftc3VuZyBFbGVjdHJvbmljcxtM?= =?UTF-8?B?ZWFkIEVuZ2luZWVyL0NvcnBvcmF0ZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1NXQUhRG0MxMElaMDFJWjAxODEyMA==?= CMS-TYPE: 101P X-HopCount: 7 X-CMS-RootMailID: 20170130045241epcas1p2a5a0625327e4caab59236ec85551f95e X-RootMTR: 20170130045241epcas1p2a5a0625327e4caab59236ec85551f95e References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org of_match_device could return NULL, and so can cause a NULL pointer dereference later. Signed-off-by: Shailendra Verma --- drivers/pwm/pwm-sun4i.c | 4 ++++ drivers/pwm/pwm-tegra.c | 5 +++++ 2 files changed, 9 insertions(+) diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c index b0803f6..9b5c6fe 100644 --- a/drivers/pwm/pwm-sun4i.c +++ b/drivers/pwm/pwm-sun4i.c @@ -321,6 +321,10 @@ static int sun4i_pwm_probe(struct platform_device *pdev) const struct of_device_id *match; match = of_match_device(sun4i_pwm_dt_ids, &pdev->dev); + if (!match) { + dev_err(&pdev->dev, "Error: No device match found\n"); + return -ENODEV; + } pwm = devm_kzalloc(&pdev->dev, sizeof(*pwm), GFP_KERNEL); if (!pwm) diff --git a/drivers/pwm/pwm-tegra.c b/drivers/pwm/pwm-tegra.c index e464784..a5eb224 100644 --- a/drivers/pwm/pwm-tegra.c +++ b/drivers/pwm/pwm-tegra.c @@ -185,6 +185,11 @@ static int tegra_pwm_probe(struct platform_device *pdev) return -ENOMEM; pwm->soc = of_device_get_match_data(&pdev->dev); + if (!pwm->soc) { + dev_err(&pdev->dev, "no device match found\n"); + return -ENODEV; + } + pwm->dev = &pdev->dev; r = platform_get_resource(pdev, IORESOURCE_MEM, 0); -- 1.7.9.5