From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751984AbdA3Ezl (ORCPT ); Sun, 29 Jan 2017 23:55:41 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:35812 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751523AbdA3Eze (ORCPT ); Sun, 29 Jan 2017 23:55:34 -0500 X-AuditID: b6c32a45-f79966d000001a3f-9b-588ec73fbe3a From: Shailendra Verma To: Mark Brown , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, p.shailesh@samsung.com, ashish.kalra@samsung.com, Shailendra Verma , Shailendra Verma Subject: [PATCH] spi - Fix possible NULL derefrence. Date: Mon, 30 Jan 2017 10:25:13 +0530 Message-id: <1485752113-29581-1-git-send-email-shailendra.v@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrEIsWRmVeSWpSXmKPExsWy7bCmha798b4Igx2PrS3uT/vGbjH14RM2 i8u75rBZNH68yW6xY0ori8WteTPZLBZ9e8XswO6xc9Zddo9NqzrZPPq2rGL0+LxJLoAlissm JTUnsyy1SN8ugSvjyrUZrAWvWCuO/P7J2sD4iKWLkZNDQsBE4sjHjUwQtpjEhXvr2boYuTiE BHYwSqzpusoC4XxmlPgwrYsZpmPJ5w52iMRKRon3zVPYQBJsAoYSr/v+MoEkRAS+MEp0PGsH SwgDdUxsbgOzWQRUJW7+/cwOYvMKeEic7fnM2sXIATRVQWLOJBuQXgmBLWwSB+dOYYGIy0ps OgC12EVi4+YlUGcLS7w6voUdwpaSeLXjGjNE7zFGicfPFzNBOJcZJbacXgZVZS9x7dZrMJtZ gE+i4/BfdogFvBIdbUIQJR4SN3a3QcPCUWL/ti9gi4UEYiX6Pz9ln8AouYCRYRWjWGpBcW56 arFRgaFecWJucWleul5yfu4mRnDMabnuYJxxzucQowAHoxIP7w3hvggh1sSy4srcQ4wSHMxK IrzlO4FCvCmJlVWpRfnxRaU5qcWHGKU5WJTEef+ts44QEkhPLEnNTk0tSC2CyTJxcEo1MN5d onC/U3W22qLO+f6fgu3PKZ46/dT6tZ/ll2mhVTl+IUFcv6TuigT78XecPlLbxXql8FlpzPXl 36dVPHzVHHysapbN483LI3wqJ0y+3qvbztP9wSJ4/YMX7y+Knt9/eNVf24lq/21nTFgknJ6+ f+LK2/phym/6n5VlLt9Wcduoxzp/1ZJFUdJKLMUZiYZazEXFiQANv+h7tQIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrKLMWRmVeSWpSXmKPExsWSnbNCVdf+eF+EQWOzocX9ad/YLaY+fMJm cXnXHDaLxo832S12TGllsbg1byabxaJvr5gd2D12zrrL7rFpVSebR9+WVYwenzfJBbBEudlk pCampBYppOYl56dk5qXbKoWGuOlaKCnkJeam2ipF6PqGBCkplCXmlAJ5RgZowME5wD1YSd8u wS3jyrUZrAWvWCuO/P7J2sD4iKWLkZNDQsBEYsnnDnYIW0ziwr31bF2MXBxCAssZJTrutIMl 2AQMJV73/WUCSYgI/GKUeNv7ng0kIQzUPbG5DcxmEVCVuPn3M1gDr4CHxNmez6xdjBxAUxUk 5kyymcDIuYCRYRWjWGpBcW56bnGBgZFecWJucWleul5yfu4mRmCQbTusJL6DcdYKr0OMAhyM Sjy8Fhl9EUKsiWXFlbmHGCU4mJVEeMt3AoV4UxIrq1KL8uOLSnNSiw8xmgJtn8gsJZqcD4yA vJJ4QxNTCwsLE0tjY2MLEyVx3tjpz8KFBNITS1KzU1MLUotg+pg4OKUaGHnLGcocl1s1LGUs q7ji/qNzDt/NxaL6c9fOPcneNKlcw+7h/Sj5i2/mVIrsS+IKrJO4MKNmh2cR/7K5DSUX5MvW +y9ZKDSPrSpng8mtFJG5/Il7/v/jlygJ2l6i43N25XTu2j+Rr5MKLv49GFHpuPfpBqbYCGu1 5F9xIhubGu2rN19dtSv9rRJLcUaioRZzUXEiAA7w/+5IAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170130045527epcas2p18ca90e9cd6b0a6153bf941eec4f40ddf X-Msg-Generator: CA X-Sender-IP: 182.195.34.23 X-Local-Sender: =?UTF-8?B?U2hhaWxlbmRyYSBWZXJtYRtTUkktTm9pZGEtQ29tbWVyY2lh?= =?UTF-8?B?bCBSJkQgIFN5c3RlbSBTL1cgR3JvdXAb7IK87ISx7KCE7J6QG0xlYWQgRW5n?= =?UTF-8?B?aW5lZXIvQ29ycG9yYXRlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?U2hhaWxlbmRyYSBWZXJtYRtTUkktTm9pZGEtQ29tbWVyY2lh?= =?UTF-8?B?bCBSJkQgIFN5c3RlbSBTL1cgR3JvdXAbU2Ftc3VuZyBFbGVjdHJvbmljcxtM?= =?UTF-8?B?ZWFkIEVuZ2luZWVyL0NvcnBvcmF0ZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1NXQUhRG0MxMElaMDFJWjAxODEyMA==?= CMS-TYPE: 102P X-HopCount: 7 X-CMS-RootMailID: 20170130045527epcas2p18ca90e9cd6b0a6153bf941eec4f40ddf X-RootMTR: 20170130045527epcas2p18ca90e9cd6b0a6153bf941eec4f40ddf References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org of_match_device could return NULL, and so can cause a NULL pointer dereference later. Signed-off-by: Shailendra Verma --- drivers/spi/spi-mxs.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/spi/spi-mxs.c b/drivers/spi/spi-mxs.c index 5b0e9a3..c3aea7e 100644 --- a/drivers/spi/spi-mxs.c +++ b/drivers/spi/spi-mxs.c @@ -470,6 +470,11 @@ static int mxs_spi_probe(struct platform_device *pdev) */ const int clk_freq_default = 160000000; + if (!of_id) { + dev_err(&pdev->dev, "Error: No device match found\n"); + return -ENODEV; + } + iores = platform_get_resource(pdev, IORESOURCE_MEM, 0); irq_err = platform_get_irq(pdev, 0); if (irq_err < 0) -- 1.7.9.5