From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752130AbdA3FDz (ORCPT ); Mon, 30 Jan 2017 00:03:55 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:49933 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751507AbdA3FDh (ORCPT ); Mon, 30 Jan 2017 00:03:37 -0500 X-AuditID: b6c32a13-f79106d000001318-a6-588ec91cabd9 From: Shailendra Verma To: Laxman Dewangan , Wolfram Sang , Stephen Warren , Thierry Reding , Alexandre Courbot , linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, p.shailesh@samsung.com, ashish.kalra@samsung.com, Shailendra Verma , Shailendra Verma Subject: [PATCH] I2c: busses - Fix possible NULL derefrence. Date: Mon, 30 Jan 2017 10:33:07 +0530 Message-id: <1485752587-30107-1-git-send-email-shailendra.v@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrIIsWRmVeSWpSXmKPExsWy7bCmsK7Myb4Ig4fHlSzuT/vGbnHu1SMW i6X7VrNYdPz9wmhxedccNovOL7PYLHZMaWWxuDVvJpvFom+vmC1eHWxjsfi5ax6LxcoTs5gd eDx2zrrL7tHb/I7No2/LKkaPk6eesHh83iTnsXFuaABbFJdNSmpOZllqkb5dAlfG91VH2Qru sFVcX/mQtYHxNmsXIyeHhICJxJtLB1ggbDGJC/fWs3UxcnEICSxllDizaD0ThPOZUeLDzjVs MB2PPq1nBLGFBFYySpzdrghiswkYSrzu+wvWICKwk1li+5KbTCAJYQEbiTd39oOtYxFQlWj4 uh5sEK+Ah8TWrcuA4hxAQxUk5kyyAemVEHjNJrH1/BKouKzEpgPMEHtdJK4fv8oOYQtLvDq+ BcqWkmi6fYoFovcYo8Tj54uZIJzLjBJbTi+DqrKXuHbrNZjNLMAnsXj9AzaIBbwSHW1CEKaH xMo7WhCmo8SEd84QL8ZKfGw9zTiBUXIBI8MqRrHUguLc9NRi4wJTveLE3OLSvHS95PzcTYzg iNUS3sG4boXXIUYBDkYlHt4V9X0RQqyJZcWVuYcYJTiYlUR4y3cChXhTEiurUovy44tKc1KL DzFKc7AoifN+rLSOEBJITyxJzU5NLUgtgskycXBKNTBKxtjdbQ9Z6a/x27/9jqt2dc7ZsyW3 FvDs4poe1rV+/69bnXL/Xgl2X93J2/VEyPvExi+rJWRtrpXnzji2LOHTwfacx8kz5j0szd29 QnKVMtP9RMHeU0a3Ai386z44tlyccIZxv+2DwDuVP09MK10YYv44WvjQI7mLD9/mzOc9ssTq xMQVqYsdlViKMxINtZiLihMBXbdDvNQCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrOLMWRmVeSWpSXmKPExsWSnbNCVVfmZF+Ewa1eQYv7076xW5x79YjF Yum+1SwWHX+/MFpc3jWHzaLzyyw2ix1TWlksbs2byWax6NsrZotXB9tYLH7umsdisfLELGYH Ho+ds+6ye/Q2v2Pz6NuyitHj5KknLB6fN8l5bJwbGsAW5WaTkZqYklqkkJqXnJ+SmZduqxQa 4qZroaSQl5ibaqsUoesbEqSkUJaYUwrkGRmgAQfnAPdgJX27BLeM76uOshXcYau4vvIhawPj bdYuRk4OCQETiUef1jNC2GISF+6tZ+ti5OIQEljOKLFuzUKwBJuAocTrvr9MIAkRgcPMEncn LmADSQgL2Ei8ubMfbBKLgKpEw9f1YHFeAQ+JrVuXAcU5gKYqSMyZZDOBkXMBI8MqRrHUguLc 9NziAgNjveLE3OLSvHS95PzcTYzAQN12WEliB+OCFV6HGAU4GJV4eH8c7YsQYk0sK67MPcQo wcGsJMJbvhMoxJuSWFmVWpQfX1Sak1p8iNEUaPtEZinR5HxgFOWVxBuamFpYWJhYGhsbW5go ifPGTn8WLiSQnliSmp2aWpBaBNPHxMEp1cC4vYv/RlPFotxNHlXep0667Ra1vT77hSH/uYXz TG9bBL5nX58sK1q+cO6ex+rarlISZ3/kbPPK9fjzo6XFNnlq9dSU27NOWtx49X1aQpjm8xg7 i0pVn6wAj5CW+FZfHUW5xbv8uxeXNhkfXCjN+M76dPETXkXevQ3ye+bax/cseLRVq1a4N1yJ pTgj0VCLuag4EQCHUGrIagIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170130050324epcas3p28c9adcffd7bc40e1733cdeef1e5240d5 X-Msg-Generator: CA X-Sender-IP: 182.195.34.24 X-Local-Sender: =?UTF-8?B?U2hhaWxlbmRyYSBWZXJtYRtTUkktTm9pZGEtQ29tbWVyY2lh?= =?UTF-8?B?bCBSJkQgIFN5c3RlbSBTL1cgR3JvdXAb7IK87ISx7KCE7J6QG0xlYWQgRW5n?= =?UTF-8?B?aW5lZXIvQ29ycG9yYXRlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?U2hhaWxlbmRyYSBWZXJtYRtTUkktTm9pZGEtQ29tbWVyY2lh?= =?UTF-8?B?bCBSJkQgIFN5c3RlbSBTL1cgR3JvdXAbU2Ftc3VuZyBFbGVjdHJvbmljcxtM?= =?UTF-8?B?ZWFkIEVuZ2luZWVyL0NvcnBvcmF0ZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1NXQUhRG0MxMElaMDFJWjAxODEyMA==?= CMS-TYPE: 103P X-HopCount: 7 X-CMS-RootMailID: 20170130050324epcas3p28c9adcffd7bc40e1733cdeef1e5240d5 X-RootMTR: 20170130050324epcas3p28c9adcffd7bc40e1733cdeef1e5240d5 References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org of_device_get_match_data could return NULL, and so can cause a NULL pointer dereference later. Signed-off-by: Shailendra Verma --- drivers/i2c/busses/i2c-tegra.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c index 4af9bba..93ac1e1 100644 --- a/drivers/i2c/busses/i2c-tegra.c +++ b/drivers/i2c/busses/i2c-tegra.c @@ -920,6 +920,10 @@ static int tegra_i2c_probe(struct platform_device *pdev) tegra_i2c_parse_dt(i2c_dev); i2c_dev->hw = of_device_get_match_data(&pdev->dev); + if (!i2c_dev->hw) { + dev_err(&pdev->dev, "no device match found\n"); + return -ENODEV; + } i2c_dev->is_dvc = of_device_is_compatible(pdev->dev.of_node, "nvidia,tegra20-i2c-dvc"); init_completion(&i2c_dev->msg_complete); -- 1.7.9.5