From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752261AbdA3FFi (ORCPT ); Mon, 30 Jan 2017 00:05:38 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:38809 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752221AbdA3FF2 (ORCPT ); Mon, 30 Jan 2017 00:05:28 -0500 X-AuditID: b6c32a36-f79dd6d000001a4f-09-588ec9956611 From: Shailendra Verma To: Zhang Rui , Eduardo Valentin , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, p.shailesh@samsung.com, ashish.kalra@samsung.com, Shailendra Verma , Shailendra Verma Subject: [PATCH] Thermal - Fix possible NULL derefrence. Date: Mon, 30 Jan 2017 10:34:58 +0530 Message-id: <1485752698-30248-1-git-send-email-shailendra.v@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrGIsWRmVeSWpSXmKPExsWy7bCmru7Uk30RBq3nzS3uT/vGbjH/yjVW i8u75rBZfO49wmixY0ori8WTh31sFrfmzWSzWPTtFbMDh8fOWXfZPRbvecnk0bdlFaPH501y ASxRXDYpqTmZZalF+nYJXBmztzxjKjjEVrHs/lWmBsYdrF2MnBwSAiYSa0/+ZoKwxSQu3FvP 1sXIxSEksINRYsOPmYwQzmdGibmTDsF13Dv8GcwWEljJKHFrMweIzSZgKPG67y8TSIOIwFwm ifVrjrKAJIQFLCRm/rkJtoJFQFXiyo2j7CA2r4CHRO/ubiCbA2iogsScSTYgvRICB9gk+qZd YYSIy0psOsAMsddFov3GW6hLhSVeHd/CDmFLSTR//MAK0XuMUeLx88VMEM5lRoktp5dBVdlL XLv1GsxmFuCTePe1hxViAa9ER5sQRImHxIzfm6CWOUo0/1sL9WSsxLEnU1knMEouYGRYxSiW WlCcm55abFhgpFecmFtcmpeul5yfu4kRHHtaZjsYF53zOcQowMGoxMN7Q7gvQog1say4MvcQ owQHs5IIb/lOoBBvSmJlVWpRfnxRaU5q8SFGaQ4WJXHexY3WEUIC6YklqdmpqQWpRTBZJg5O qQbG6inZx63Sb/5P1JXdy7g786nANAeBpZd+nEnyXW+c7jLd5n6rSfLPT1P3pR7xqDCr38q3 uUdxRYr1mXRdj5sC71z+2fy6FVL+xOGl7PfOb6v5S1RmtSjKK57dsYt3xsLVX05EBmzcuzxV wqAtJ97kXYrFu8VyIt3lbFl7XzlKvl2arcTX5eyoxFKckWioxVxUnAgAuGiL8bkCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrFLMWRmVeSWpSXmKPExsWSnbNCVXfqyb4Ig837FSzuT/vGbjH/yjVW i8u75rBZfO49wmixY0ori8WTh31sFrfmzWSzWPTtFbMDh8fOWXfZPRbvecnk0bdlFaPH501y ASxRbjYZqYkpqUUKqXnJ+SmZeem2SqEhbroWSgp5ibmptkoRur4hQUoKZYk5pUCekQEacHAO cA9W0rdLcMuYveUZU8Ehtopl968yNTDuYO1i5OSQEDCRuHf4M5QtJnHh3nq2LkYuDiGB5YwS C1uOsYEk2AQMJV73/WUCSYgILGaS6Hh3BKxDWMBCYuafm0wgNouAqsSVG0fZQWxeAQ+J3t3d QDYH0FQFiTmTbCYwci5gZFjFKJZaUJybnltcYGCoV5yYW1yal66XnJ+7iREYbtsOK4ntYGxb 4XWIUYCDUYmH12BNX4QQa2JZcWXuIUYJDmYlEd7ynUAh3pTEyqrUovz4otKc1OJDjKZA2ycy S4km5wNjIa8k3tDE1MLCwsTS2NjYwkRJnDd2+rNwIYH0xJLU7NTUgtQimD4mDk6pBkZD59mZ +e5fuvyPBk/8lRB32WMBz6zrHOE7VhfWPz9sw6V9bO1L66bsDZ2W0Wt5a1czpPrtWBwU2P+e 1Z2rW/O0yDofeaXIBYvuy637WZSsWfrP8f2jB41n8psFpwR9VH946rBQpPbRj/ePfNjQt7VF 69a0DRd6LQ7rt6ucTT2ocr/o4iQD45tKLMUZiYZazEXFiQADeFZxTQIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170130050525epcas1p3686ebf52f0215eef64a358338843305d X-Msg-Generator: CA X-Sender-IP: 182.195.34.22 X-Local-Sender: =?UTF-8?B?U2hhaWxlbmRyYSBWZXJtYRtTUkktTm9pZGEtQ29tbWVyY2lh?= =?UTF-8?B?bCBSJkQgIFN5c3RlbSBTL1cgR3JvdXAb7IK87ISx7KCE7J6QG0xlYWQgRW5n?= =?UTF-8?B?aW5lZXIvQ29ycG9yYXRlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?U2hhaWxlbmRyYSBWZXJtYRtTUkktTm9pZGEtQ29tbWVyY2lh?= =?UTF-8?B?bCBSJkQgIFN5c3RlbSBTL1cgR3JvdXAbU2Ftc3VuZyBFbGVjdHJvbmljcxtM?= =?UTF-8?B?ZWFkIEVuZ2luZWVyL0NvcnBvcmF0ZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1NXQUhRG0MxMElaMDFJWjAxODEyMA==?= CMS-TYPE: 101P X-HopCount: 7 X-CMS-RootMailID: 20170130050525epcas1p3686ebf52f0215eef64a358338843305d X-RootMTR: 20170130050525epcas1p3686ebf52f0215eef64a358338843305d References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org of_device_get_match_data could return NULL, and so can cause a NULL pointer dereference later. Signed-off-by: Shailendra Verma --- drivers/thermal/imx_thermal.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/thermal/imx_thermal.c b/drivers/thermal/imx_thermal.c index 06912f0..fb648a4 100644 --- a/drivers/thermal/imx_thermal.c +++ b/drivers/thermal/imx_thermal.c @@ -489,6 +489,10 @@ static int imx_thermal_probe(struct platform_device *pdev) data->tempmon = map; data->socdata = of_device_get_match_data(&pdev->dev); + if (!data->socdata) { + dev_err(&pdev->dev, "no device match found\n"); + return -ENODEV; + } /* make sure the IRQ flag is clear before enabling irq on i.MX6SX */ if (data->socdata->version == TEMPMON_IMX6SX) { -- 1.7.9.5